Profilers use pthread when they could use std::thread instead.
Details
Details
- Reviewers
- None
- Group Reviewers
Windows Developers Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22608: Pthread -> std::thread (2/7) - Remove pthread in Profilers
Compile, actually test (haven't done that), particularly that saving to file still works.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/differential/1490/display/redirect
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/ps/Profiler2.h | 96| class·CProfiler2 | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCProfiler2{' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/296/display/redirect
Comment Actions
Remove some usage of auto in the for-range loop in favour of writing std::unique_ptr<ThreadStorage>
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/ps/Profiler2.h | 96| class·CProfiler2 | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCProfiler2{' is invalid C code. Use --std or --language to configure the language. Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/300/display/redirect