Page MenuHomeWildfire Games

pthread -> std::thread (2/7) - Remove dependencies in Profilers
ClosedPublic

Authored by wraitii on May 25 2019, 7:16 PM.

Details

Reviewers
None
Group Reviewers
Windows Developers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22608: Pthread -> std::thread (2/7) - Remove pthread in Profilers
Summary

Profilers use pthread when they could use std::thread instead.

Test Plan

Compile, actually test (haven't done that), particularly that saving to file still works.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.May 25 2019, 7:16 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1490/display/redirect

wraitii updated this revision to Diff 9208.Aug 3 2019, 1:53 PM
wraitii retitled this revision from pthread -> std::thread (2/?) - Remove dependencies in Profilers to pthread -> std::thread (2/7) - Remove dependencies in Profilers.

Actually working version™

Vulcan added a comment.Aug 3 2019, 2:24 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/ps/Profiler2.h
|  96| class·CProfiler2
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCProfiler2{' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/296/display/redirect

wraitii updated this revision to Diff 9212.Aug 4 2019, 9:15 AM

Remove some usage of auto in the for-range loop in favour of writing std::unique_ptr<ThreadStorage>

Vulcan added a comment.Aug 4 2019, 9:55 AM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/ps/Profiler2.h
|  96| class·CProfiler2
|    | [MAJOR] CPPCheckBear (syntaxError):
|    | Code 'classCProfiler2{' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/300/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Aug 4 2019, 10:12 AM
This revision was automatically updated to reflect the committed changes.