This removes pthread mutexes/threads from other core 0A.D. files. Remain the mongoose file and the x86_64 weird computation, as well as the message passing with atlas.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22666: pthread -> std::thread (4/7) - Replace pthread in remaining files
Compile, test.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- temp
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 8830 Build 14484: Vulcan Build Jenkins Build 14483: arc lint + arc unit
Event Timeline
Comment Actions
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/differential/1513/display/redirect
source/network/NetServer.cpp | ||
---|---|---|
263 | er, should have made this into return;, I went too quickly. |
source/network/NetServer.cpp | ||
---|---|---|
359 | Any reason by the way why it can't be a general worker ? |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/network/NetServer.h | 46| » //·The·worker·thread·has·not·been·started. | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCNetFileReceiveTask{' is invalid C code. Use --std or --language to configure the language. source/lib/posix/posix.h | 1| /*·Copyright·(C)·2010·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2010" source/lib/file/vfs/vfs.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/lib/file/vfs/vfs.h | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/lib/file/vfs/vfs.h | 34| namespace·ERR | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespaceERR{' is invalid C code. Use --std or --language to configure the language. source/lib/res/h_mgr.cpp | 1| /*·Copyright·(C)·2013·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2013" Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/369/display/redirect
source/lib/file/vfs/vfs.cpp | ||
---|---|---|
45 | Missing an include ? |
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/network/NetServer.h | 46| » //·The·worker·thread·has·not·been·started. | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'classCNetFileReceiveTask{' is invalid C code. Use --std or --language to configure the language. source/lib/file/vfs/vfs.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/lib/file/vfs/vfs.h | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" source/lib/file/vfs/vfs.h | 34| namespace·ERR | | [MAJOR] CPPCheckBear (syntaxError): | | Code 'namespaceERR{' is invalid C code. Use --std or --language to configure the language. source/lib/posix/posix.h | 1| /*·Copyright·(C)·2010·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2010" source/lib/res/h_mgr.cpp | 1| /*·Copyright·(C)·2013·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2013" Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/378/display/redirect