Page MenuHomeWildfire Games

pthread -> std::thread (6/7) - Replace semaphores in the atlas-game interface
Needs ReviewPublic

Authored by wraitii on May 26 2019, 7:08 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Named posix semaphores are used for the atlas-game interface. This seems to be set up for inter-process communication... Only all callers are in the same process. So for now, use the usual condition_variable.

I'm removing plenty of dead-code and some wrong encapsulation while at it.

Only use for our pthread wrapper is now the x86_64 timing stuff which I'll try and remove next.

Test Plan

Compile, review.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
_threadutil_cleanup
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7627
Build 12440: Vulcan BuildJenkins
Build 12439: arc lint + arc unit

Event Timeline

wraitii created this revision.May 26 2019, 7:08 PM
Owners added a subscriber: Restricted Owners Package.May 26 2019, 7:08 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1515/display/redirect

Stan added inline comments.
source/tools/atlas/GameInterface/MessagesSetup.h
211

CPP check doesn't like that at all, but I don't know how to fix that @vladislavbelov and @wraitii can you fix it/ make me understand which macro it closes ?