Differential D1922

7) - Replace semaphores in the atlas-game interface
AbandonedPublic
Actions

Authored by wraitii on May 26 2019, 7:08 PM.

Details

Reviewers

None

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

Named posix semaphores are used for the atlas-game interface. This seems to be set up for inter-process communication... Only all callers are in the same process. So for now, use the usual condition_variable.

I'm removing plenty of dead-code and some wrong encapsulation while at it.

Only use for our pthread wrapper is now the x86_64 timing stuff which I'll try and remove next.

Test Plan

Compile, review.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

_threadutil_cleanup

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 7627
Build 12440: Vulcan Build	Jenkins
Build 12439: arc lint + arc unit

Event Timeline

wraitii created this revision.May 26 2019, 7:08 PM

Owners added a subscriber: Restricted Owners Package.May 26 2019, 7:08 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1515/display/redirect

Harbormaster failed remote builds in B7627: Diff 8165!May 26 2019, 7:08 PM

wraitii added a child revision: D1923: pthread -> std::thread - Remove clock frequency calculations.May 26 2019, 7:29 PM

wraitii added a parent revision: D1921: pthread -> std::thread (5/7) - Replace sdl semaphore with condition variable.

Stan added subscribers: vladislavbelov, Stan.May 27 2019, 8:53 PM

Stan added inline comments.

source/tools/atlas/GameInterface/MessagesSetup.h
211	CPP check doesn't like that at all, but I don't know how to fix that @vladislavbelov and @wraitii can you fix it/ make me understand which macro it closes ?