Just refactoring, it'll be used to add more functions for a graphics debugging.
I tried to save the current functionality, but it could be extended later.
Differential D1928
Refactors Developer Overlay vladislavbelov on May 27 2019, 10:50 PM. Authored by
Details
Just refactoring, it'll be used to add more functions for a graphics debugging. I tried to save the current functionality, but it could be extended later.
Diff Detail
Event TimelineThere are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | 873| 873| Engine.GetGUIObjectByName("barterHelp").hidden = !canBarter; | 874| 874| | 875| 875| if (canBarter) | 876| |- g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer) }); | | 876|+ g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer); }); | 877| 877| } | 878| 878| | 879| 879| function getIdleLandTradersText(traderNumber) binaries/data/mods/public/gui/session/menu.js | 482| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 557| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 876| » » g_ResourceData.GetCodes().forEach((resCode,·i)·=>·{·barterUpdateCommon(resCode,·i,·"barter",·g_ViewedPlayer)·}); | | [NORMAL] JSHintBear: | | Missing semicolon. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 401| 401| // Players see colors depending on diplomacy | 402| 402| g_DisplayedPlayerColors[i] = | 403| 403| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 404| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 404|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 405| 405| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 406| 406| getDiplomacyColor("enemy"); | 407| 407| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 402| 402| g_DisplayedPlayerColors[i] = | 403| 403| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 404| 404| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 405| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 405|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 406| 406| getDiplomacyColor("enemy"); | 407| 407| | 408| 408| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 403| 403| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 404| 404| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 405| 405| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 406| |- getDiplomacyColor("enemy"); | | 406|+ getDiplomacyColor("enemy"); | 407| 407| | 408| 408| g_DisplayedPlayerColors[0] = g_Players[0].color; | 409| 409| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 653| 653| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 654| 654| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 655| 655| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 656| |- }); | | 656|+ }); | 657| 657| } | 658| 658| | 659| 659| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1204|1204| |1205|1205| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1206|1206| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1207| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTags), | |1207|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1208|1208| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1209|1209| }); |1210|1210| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1205|1205| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1206|1206| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1207|1207| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1208| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1208|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1209|1209| }); |1210|1210| |1211|1211| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1206|1206| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1207|1207| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1208|1208| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1209| |- }); | |1209|+ }); |1210|1210| |1211|1211| let resCodes = g_ResourceData.GetCodes(); |1212|1212| for (let r = 0; r < resCodes.length; ++r) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1689|1689| for (let rct of resourcesCounterTypes) |1690|1690| for (let rt of resourcesTypes) |1691|1691| reportObject[rt + rct.substr(9)] = playerStatistics[rct][rt]; |1692| |- // eg. rt = food rct.substr = Gathered rct = resourcesGathered | |1692|+ // eg. rt = food rct.substr = Gathered rct = resourcesGathered |1693|1693| |1694|1694| reportObject.vegetarianFoodGathered = playerStatistics.resourcesGathered.vegetarianFood; |1695|1695| for (let type of unitsClasses) binaries/data/mods/public/gui/session/session.js |1065| » let·getPanelEntNameTooltip·=·panelEntState·=>·"[font=\"sans-bold-16\"]"·+·template.name.specific·+·"[/font]"; | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1140| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1141| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1142| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 181| 181| } | 182| 182| } | 183| 183| else if (placementSupport.mode === "wall") | 184| |- { | | 184|+ | 185| 185| if (placementSupport.wallSet && placementSupport.position) | 186| 186| { | 187| 187| // Fetch an updated list of snapping candidate entities | 199| 199| "snapEntities": placementSupport.wallSnapEntities, // snapping entities (towers) for starting a wall segment | 200| 200| }); | 201| 201| } | 202| |- } | | 202|+ | 203| 203| | 204| 204| return false; | 205| 205| } | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 288| 288| } | 289| 289| | 290| 290| if (!updateBuildingPlacementPreview()) | 291| |- { | | 291|+ | 292| 292| // invalid location - don't build it | 293| 293| // TODO: play a sound? | 294| 294| return false; | 295| |- } | | 295|+ | 296| 296| | 297| 297| var selection = g_Selection.toList(); | 298| 298| | | [NORMAL] ESLintBear (space-unary-ops): | | Unary word operator 'typeof' must be followed by whitespace. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 327| 327| } | 328| 328| | 329| 329| var wallPlacementInfo = updateBuildingPlacementPreview(); // entities making up the wall (wall segments, towers, ...) | 330| |- if (!(wallPlacementInfo === false || typeof(wallPlacementInfo) === "object")) | | 330|+ if (!(wallPlacementInfo === false || typeof (wallPlacementInfo) === "object")) | 331| 331| { | 332| 332| error("Invalid updateBuildingPlacementPreview return value: " + uneval(wallPlacementInfo)); | 333| 333| return false; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'for-of'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 354| 354| // (this is somewhat non-ideal and hardcode-ish) | 355| 355| var hasWallSegment = false; | 356| 356| for (let piece of cmd.pieces) | 357| |- { | | 357|+ | 358| 358| if (piece.template != cmd.wallSet.templates.tower) // TODO: hardcode-ish :( | 359| 359| { | 360| 360| hasWallSegment = true; | 361| 361| break; | 362| 362| } | 363| |- } | | 363|+ | 364| 364| | 365| 365| if (hasWallSegment) | 366| 366| { | | [NORMAL] ESLintBear (operator-linebreak): | | '&&' should be placed at the end of the line. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 477| 477| mouseIsOverObject = (hoveredObject != null); | 478| 478| | 479| 479| // Close the menu when interacting with the game world | 480| |- if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") | 481| |- && (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | | 480|+ if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") && | | 481|+ (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | 482| 482| closeMenu(); | 483| 483| | 484| 484| // State-machine processing: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 518| 518| | 519| 519| // Update the list of selected units | 520| 520| if (Engine.HotkeyIsPressed("selection.add")) | 521| |- { | | 521|+ | 522| 522| g_Selection.addList(ents); | 523| |- } | | 523|+ | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| 525| { | 526| 526| g_Selection.removeList(ents); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 522| 522| g_Selection.addList(ents); | 523| 523| } | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| |- { | | 525|+ | 526| 526| g_Selection.removeList(ents); | 527| |- } | | 527|+ | 528| 528| else | 529| 529| { | 530| 530| g_Selection.reset(); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 578| 578| // If shift is down, let the player continue placing another of the same building | 579| 579| var queued = Engine.HotkeyIsPressed("session.queue"); | 580| 580| if (tryPlaceBuilding(queued)) | 581| |- { | | 581|+ | 582| 582| if (queued) | 583| 583| inputState = INPUT_BUILDING_PLACEMENT; | 584| 584| else | 585| 585| inputState = INPUT_NORMAL; | 586| |- } | | 586|+ | 587| 587| else | 588| 588| { | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 585| 585| inputState = INPUT_NORMAL; | 586| 586| } | 587| 587| else | 588| |- { | | 588|+ | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | 590| |- } | | 590|+ | 591| 591| return true; | 592| 592| } | 593| 593| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 638| 638| // user to continue building walls. | 639| 639| switch (ev.type) | 640| 640| { | 641| |- case "mousemotion": | | 641|+ case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 639| 639| switch (ev.type) | 640| 640| { | 641| 641| case "mousemotion": | 642| |- placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | | 642|+ placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 641| 641| case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| |- // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | 644|+ // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| |- // the ending point and the starting point to snap to. | | 645|+ // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| |- // | | 646|+ // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| |- // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | 647|+ // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| |- // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | 648|+ // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| |- // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | 649|+ // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| |- // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | 650|+ // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| |- // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | 651|+ // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| |- // points. | | 652|+ // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| |- placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | 654|+ placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| |- var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | 655|+ var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| |- if (result && result.cost) | | 657|+ if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| |- { | | 658|+ { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | 659| |- var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | | 659|+ var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 657| 657| if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| |- placementSupport.tooltipMessage = [ | | 660|+ placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| |- getEntityCostTooltip(result), | | 661|+ getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| |- getNeededResourcesTooltip(neededResources) | | 662|+ getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| |- ].filter(tip => tip).join("\n"); | | 663|+ ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| 666| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| |- } | | 664|+ } | 665| 665| | 666| 666| break; | 667| 667| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| |- break; | | 666|+ break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 665| 665| | 666| 666| break; | 667| 667| | 668| |- case "mousebuttondown": | | 668|+ case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 666| 666| break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| |- if (ev.button == SDL_BUTTON_LEFT) | | 669|+ if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| |- { | | 670|+ { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| |- var queued = Engine.HotkeyIsPressed("session.queue"); | | 671|+ var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| |- if (tryPlaceWall(queued)) | | 672|+ if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| 675| { | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ { | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| |- if (queued) | | 674|+ if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| |- { | | 675|+ { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 673| 673| { | 674| 674| if (queued) | 675| 675| { | 676| |- // continue building, just set a new starting position where we left off | | 676|+ // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| |- placementSupport.position = placementSupport.wallEndPosition; | | 677|+ placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| |- placementSupport.wallEndPosition = undefined; | | 678|+ placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| |- inputState = INPUT_BUILDING_WALL_CLICK; | | 680|+ inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| 683| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| |- } | | 681|+ } | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| |- else | | 682|+ else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| |- { | | 683|+ { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 681| 681| } | 682| 682| else | 683| 683| { | 684| |- placementSupport.Reset(); | | 684|+ placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| |- inputState = INPUT_NORMAL; | | 685|+ inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| 688| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| |- } | | 686|+ } | 687| 687| } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| |- else | | 688|+ else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 686| 686| } | 687| 687| } | 688| 688| else | 689| |- placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | 689|+ placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| |- updateBuildingPlacementPreview(); | | 691|+ updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| |- return true; | | 692|+ return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| |- } | | 693|+ } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| |- else if (ev.button == SDL_BUTTON_RIGHT) | | 694|+ else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| |- { | | 695|+ { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| |- // reset to normal input mode | | 696|+ // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| |- placementSupport.Reset(); | | 697|+ placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| |- updateBuildingPlacementPreview(); | | 698|+ updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| |- inputState = INPUT_NORMAL; | | 700|+ inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| 703| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| |- return true; | | 701|+ return true; | 702| 702| } | 703| 703| break; | 704| 704| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| |- } | | 702|+ } | 703| 703| break; | 704| 704| } | 705| 705| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| |- break; | | 703|+ break; | 704| 704| } | 705| 705| break; | 706| 706| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 710| 710| case "mousemotion": | 711| 711| let maxDragDelta = 16; | 712| 712| if (g_DragStart.distanceTo(ev) >= maxDragDelta) | 713| |- { | | 713|+ | 714| 714| // Rotate in the direction of the mouse | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| |- } | | 716|+ | 717| 717| else | 718| 718| { | 719| 719| // If the mouse is near the center, snap back to the default orientation | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| 716| } | 717| 717| else | 718| |- { | | 718|+ | 719| 719| // If the mouse is near the center, snap back to the default orientation | 720| 720| placementSupport.SetDefaultAngle(); | 721| |- } | | 721|+ | 722| 722| | 723| 723| var snapData = Engine.GuiInterfaceCall("GetFoundationSnapData", { | 724| 724| "template": placementSupport.template, | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 741| 741| // If shift is down, let the player continue placing another of the same building | 742| 742| var queued = Engine.HotkeyIsPressed("session.queue"); | 743| 743| if (tryPlaceBuilding(queued)) | 744| |- { | | 744|+ | 745| 745| if (queued) | 746| 746| inputState = INPUT_BUILDING_PLACEMENT; | 747| 747| else | 748| 748| inputState = INPUT_NORMAL; | 749| |- } | | 749|+ | 750| 750| else | 751| 751| { | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 748| 748| inputState = INPUT_NORMAL; | 749| 749| } | 750| 750| else | 751| |- { | | 751|+ | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | 753| |- } | | 753|+ | 754| 754| return true; | 755| 755| } | 756| 756| break; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 797| 797| | 798| 798| // Handle the time-warp testing features, restricted to single-player | 799| 799| if (!g_IsNetworked && g_DeveloperOverlay.isTimeWarpEnabled()) | 800| |- { | | 800|+ | 801| 801| if (ev.type == "hotkeydown" && ev.hotkey == "session.timewarp.fastforward") | 802| 802| Engine.SetSimRate(20.0); | 803| 803| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.fastforward") | 804| 804| Engine.SetSimRate(1.0); | 805| 805| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.rewind") | 806| 806| Engine.RewindTimeWarp(); | 807| |- } | | 807|+ | 808| 808| | 809| 809| if (ev.hotkey == "session.highlightguarding") | 810| 810| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 856| 856| break; | 857| 857| | 858| 858| case "hotkeydown": | 859| |- if (ev.hotkey.indexOf("selection.group.") == 0) | | 859|+ if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 857| 857| | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| |- { | | 860|+ { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| |- let now = Date.now(); | | 861|+ let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| |- if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | 862|+ if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| |- { | | 863|+ { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| |- if (ev.hotkey.indexOf("selection.group.select.") == 0) | | 864|+ if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| |- { | | 865|+ { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| |- var sptr = ev.hotkey.split("."); | | 866|+ var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| |- performGroup("snap", sptr[3]); | | 867|+ performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| 870| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| |- } | | 868|+ } | 869| 869| } | 870| 870| else | 871| 871| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| |- } | | 869|+ } | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| |- else | | 870|+ else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 868| 868| } | 869| 869| } | 870| 870| else | 871| |- { | | 871|+ { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 869| 869| } | 870| 870| else | 871| 871| { | 872| |- var sptr = ev.hotkey.split("."); | | 872|+ var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| |- performGroup(sptr[2], sptr[3]); | | 873|+ performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| |- doublePressTimer = now; | | 875|+ doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| |- prevHotkey = ev.hotkey; | | 876|+ prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| 879| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| |- } | | 877|+ } | 878| 878| } | 879| 879| break; | 880| 880| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| |- } | | 878|+ } | 879| 879| break; | 880| 880| } | 881| 881| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| |- break; | | 879|+ break; | 880| 880| } | 881| 881| break; | 882| 882| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1044|1044| placementSupport.position = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); |1045|1045| |1046|1046| if (placementSupport.mode === "wall") |1047| |- { | |1047|+ |1048|1048| // Including only the on-screen towers in the next snap candidate list is sufficient here, since the user is |1049|1049| // still selecting a starting point (which must necessarily be on-screen). (The update of the snap entities |1050|1050| // itself happens in the call to updateBuildingPlacementPreview below). |1051|1051| placementSupport.wallSnapEntitiesIncludeOffscreen = false; |1052| |- } | |1052|+ |1053|1053| else |1054|1054| { |1055|1055| // cancel if not enough resources | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1316|1316| if (templateData.attack && |1317|1317| templateData.attack.Ranged && |1318|1318| templateData.attack.Ranged.maxRange) |1319| |- { | |1319|+ |1320|1320| // add attack information to display a good tooltip |1321|1321| placementSupport.attack = templateData.attack; |1322| |- } | |1322|+ |1323|1323| } |1324|1324| |1325|1325| // Batch training: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1404|1404| if (Engine.HotkeyIsPressed("session.batchtrain") && (canBeAddedCount == undefined || canBeAddedCount > 1)) |1405|1405| { |1406|1406| if (inputState == INPUT_BATCHTRAINING) |1407| |- { | |1407|+ |1408|1408| // Check if we are training in the same building(s) as the last batch |1409|1409| // NOTE: We just check if the arrays are the same and if the order is the same |1410|1410| // If the order changed, we have a new selection and we should create a new batch. |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439|1439| // fall through to create the new batch |1440| |- } | |1440|+ |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. |1443|1443| if (decrement || Engine.GuiInterfaceCall("GetNeededResources", { "cost": | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1436|1436| // Otherwise start a new one |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439| |- // fall through to create the new batch | |1439|+ // fall through to create the new batch |1440|1440| } |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. | | [NORMAL] ESLintBear (space-in-parens): | | There should be no spaces inside this paren. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1514|1514| g_BatchTrainingEntityAllowedCount < batchedSize * appropriateBuildings.length) |1515|1515| { |1516|1516| // Train as many full batches as we can |1517| |- let buildingsCountToTrainFullBatch = Math.floor( g_BatchTrainingEntityAllowedCount / batchedSize); | |1517|+ let buildingsCountToTrainFullBatch = Math.floor(g_BatchTrainingEntityAllowedCount / batchedSize); |1518|1518| Engine.PostNetworkCommand({ |1519|1519| "type": "train", |1520|1520| "entities": appropriateBuildings.slice(0, buildingsCountToTrainFullBatch), | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1593|1593| var selectall = Engine.HotkeyIsPressed("selection.offscreen"); |1594|1594| |1595|1595| // Reset the last idle unit, etc., if the selection type has changed. |1596| |- if (selectall || classes.length != lastIdleClasses.length || !classes.every((v,i) => v === lastIdleClasses[i])) | |1596|+ if (selectall || classes.length != lastIdleClasses.length || !classes.every((v, i) => v === lastIdleClasses[i])) |1597|1597| resetIdleUnit(); |1598|1598| lastIdleClasses = classes; |1599|1599| binaries/data/mods/public/gui/session/input.js | 228| » » var·entState·=·GetEntityState(ent); | | [NORMAL] ESLintBear (no-shadow): | | 'entState' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'target' to undefined. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'actionInfo' to undefined. binaries/data/mods/public/gui/session/input.js | 466| » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 493| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 497| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 552| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 562| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 610| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 639| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 708| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 825| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 828| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 928| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1017| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1031| » » » » let·action·=·determineAction(ev.x,·ev.y); | | [NORMAL] ESLintBear (no-shadow): | | 'action' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js |1040| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1109| » » » switch·(ev.hotkey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1544| » switch·(action) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'target' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'actionInfo' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 263| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 266| » » » var·r·=·g_UnitActions[action].hotkeyActionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 271| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 274| » » » var·r·=·g_UnitActions[action].actionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 481| » » &&·(ev.button·==·SDL_BUTTON_LEFT·||·ev.button·==·SDL_BUTTON_RIGHT)) | | [NORMAL] JSHintBear: | | Misleading line break before '&&'; readers may interpret this as an expression boundary. binaries/data/mods/public/gui/session/input.js | 511| » » » » var·rect·=·updateBandbox(bandbox,·ev,·true); | | [NORMAL] JSHintBear: | | 'rect' is already defined. binaries/data/mods/public/gui/session/input.js | 514| » » » » var·ents·=·getPreferredEntities(Engine.PickPlayerEntitiesInRect(rect[0],·rect[1],·rect[2],·rect[3],·g_ViewedPlayer)); | | [NORMAL] JSHintBear: | | 'ents' is already defined. binaries/data/mods/public/gui/session/input.js | 671| » » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 711| » » » let·maxDragDelta·=·16; | | [MAJOR] JSHintBear: | | 'maxDragDelta' has already been declared. binaries/data/mods/public/gui/session/input.js | 742| » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 872| » » » » » » var·sptr·=·ev.hotkey.split("."); | | [NORMAL] JSHintBear: | | 'sptr' is already defined. binaries/data/mods/public/gui/session/input.js | 888| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/gui/session/input.js | 914| » » » } | | [NORMAL] JSHintBear: | | Expected a 'break' statement before 'default'. binaries/data/mods/public/gui/session/input.js | 938| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1621/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | 873| 873| Engine.GetGUIObjectByName("barterHelp").hidden = !canBarter; | 874| 874| | 875| 875| if (canBarter) | 876| |- g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer) }); | | 876|+ g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer); }); | 877| 877| } | 878| 878| | 879| 879| function getIdleLandTradersText(traderNumber) binaries/data/mods/public/gui/session/menu.js | 482| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 557| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 876| » » g_ResourceData.GetCodes().forEach((resCode,·i)·=>·{·barterUpdateCommon(resCode,·i,·"barter",·g_ViewedPlayer)·}); | | [NORMAL] JSHintBear: | | Missing semicolon. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 400| 400| // Players see colors depending on diplomacy | 401| 401| g_DisplayedPlayerColors[i] = | 402| 402| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 403| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 403|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 404| 404| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 405| 405| getDiplomacyColor("enemy"); | 406| 406| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 401| 401| g_DisplayedPlayerColors[i] = | 402| 402| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 403| 403| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 404| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 404|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 405| 405| getDiplomacyColor("enemy"); | 406| 406| | 407| 407| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 402| 402| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 403| 403| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 404| 404| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 405| |- getDiplomacyColor("enemy"); | | 405|+ getDiplomacyColor("enemy"); | 406| 406| | 407| 407| g_DisplayedPlayerColors[0] = g_Players[0].color; | 408| 408| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 652| 652| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 653| 653| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 654| 654| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 655| |- }); | | 655|+ }); | 656| 656| } | 657| 657| | 658| 658| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1202|1202| |1203|1203| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1204|1204| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1205| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTags), | |1205|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1206|1206| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1207|1207| }); |1208|1208| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1203|1203| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1204|1204| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1205|1205| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1206| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1206|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1207|1207| }); |1208|1208| |1209|1209| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1204|1204| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1205|1205| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1206|1206| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1207| |- }); | |1207|+ }); |1208|1208| |1209|1209| let resCodes = g_ResourceData.GetCodes(); |1210|1210| for (let r = 0; r < resCodes.length; ++r) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1687|1687| for (let rct of resourcesCounterTypes) |1688|1688| for (let rt of resourcesTypes) |1689|1689| reportObject[rt + rct.substr(9)] = playerStatistics[rct][rt]; |1690| |- // eg. rt = food rct.substr = Gathered rct = resourcesGathered | |1690|+ // eg. rt = food rct.substr = Gathered rct = resourcesGathered |1691|1691| |1692|1692| reportObject.vegetarianFoodGathered = playerStatistics.resourcesGathered.vegetarianFood; |1693|1693| for (let type of unitsClasses) binaries/data/mods/public/gui/session/session.js |1063| » let·getPanelEntNameTooltip·=·panelEntState·=>·"[font=\"sans-bold-16\"]"·+·template.name.specific·+·"[/font]"; | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1138| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1139| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1140| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 181| 181| } | 182| 182| } | 183| 183| else if (placementSupport.mode === "wall") | 184| |- { | | 184|+ | 185| 185| if (placementSupport.wallSet && placementSupport.position) | 186| 186| { | 187| 187| // Fetch an updated list of snapping candidate entities | 199| 199| "snapEntities": placementSupport.wallSnapEntities, // snapping entities (towers) for starting a wall segment | 200| 200| }); | 201| 201| } | 202| |- } | | 202|+ | 203| 203| | 204| 204| return false; | 205| 205| } | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 288| 288| } | 289| 289| | 290| 290| if (!updateBuildingPlacementPreview()) | 291| |- { | | 291|+ | 292| 292| // invalid location - don't build it | 293| 293| // TODO: play a sound? | 294| 294| return false; | 295| |- } | | 295|+ | 296| 296| | 297| 297| var selection = g_Selection.toList(); | 298| 298| | | [NORMAL] ESLintBear (space-unary-ops): | | Unary word operator 'typeof' must be followed by whitespace. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 327| 327| } | 328| 328| | 329| 329| var wallPlacementInfo = updateBuildingPlacementPreview(); // entities making up the wall (wall segments, towers, ...) | 330| |- if (!(wallPlacementInfo === false || typeof(wallPlacementInfo) === "object")) | | 330|+ if (!(wallPlacementInfo === false || typeof (wallPlacementInfo) === "object")) | 331| 331| { | 332| 332| error("Invalid updateBuildingPlacementPreview return value: " + uneval(wallPlacementInfo)); | 333| 333| return false; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'for-of'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 354| 354| // (this is somewhat non-ideal and hardcode-ish) | 355| 355| var hasWallSegment = false; | 356| 356| for (let piece of cmd.pieces) | 357| |- { | | 357|+ | 358| 358| if (piece.template != cmd.wallSet.templates.tower) // TODO: hardcode-ish :( | 359| 359| { | 360| 360| hasWallSegment = true; | 361| 361| break; | 362| 362| } | 363| |- } | | 363|+ | 364| 364| | 365| 365| if (hasWallSegment) | 366| 366| { | | [NORMAL] ESLintBear (operator-linebreak): | | '&&' should be placed at the end of the line. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 477| 477| mouseIsOverObject = (hoveredObject != null); | 478| 478| | 479| 479| // Close the menu when interacting with the game world | 480| |- if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") | 481| |- && (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | | 480|+ if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") && | | 481|+ (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | 482| 482| closeMenu(); | 483| 483| | 484| 484| // State-machine processing: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 518| 518| | 519| 519| // Update the list of selected units | 520| 520| if (Engine.HotkeyIsPressed("selection.add")) | 521| |- { | | 521|+ | 522| 522| g_Selection.addList(ents); | 523| |- } | | 523|+ | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| 525| { | 526| 526| g_Selection.removeList(ents); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 522| 522| g_Selection.addList(ents); | 523| 523| } | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| |- { | | 525|+ | 526| 526| g_Selection.removeList(ents); | 527| |- } | | 527|+ | 528| 528| else | 529| 529| { | 530| 530| g_Selection.reset(); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 578| 578| // If shift is down, let the player continue placing another of the same building | 579| 579| var queued = Engine.HotkeyIsPressed("session.queue"); | 580| 580| if (tryPlaceBuilding(queued)) | 581| |- { | | 581|+ | 582| 582| if (queued) | 583| 583| inputState = INPUT_BUILDING_PLACEMENT; | 584| 584| else | 585| 585| inputState = INPUT_NORMAL; | 586| |- } | | 586|+ | 587| 587| else | 588| 588| { | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 585| 585| inputState = INPUT_NORMAL; | 586| 586| } | 587| 587| else | 588| |- { | | 588|+ | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | 590| |- } | | 590|+ | 591| 591| return true; | 592| 592| } | 593| 593| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 638| 638| // user to continue building walls. | 639| 639| switch (ev.type) | 640| 640| { | 641| |- case "mousemotion": | | 641|+ case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 639| 639| switch (ev.type) | 640| 640| { | 641| 641| case "mousemotion": | 642| |- placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | | 642|+ placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 641| 641| case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| |- // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | 644|+ // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| |- // the ending point and the starting point to snap to. | | 645|+ // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| |- // | | 646|+ // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| |- // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | 647|+ // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| |- // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | 648|+ // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| |- // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | 649|+ // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| |- // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | 650|+ // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| |- // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | 651|+ // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| |- // points. | | 652|+ // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| |- placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | 654|+ placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| |- var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | 655|+ var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| |- if (result && result.cost) | | 657|+ if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| |- { | | 658|+ { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | 659| |- var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | | 659|+ var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 657| 657| if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| |- placementSupport.tooltipMessage = [ | | 660|+ placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| |- getEntityCostTooltip(result), | | 661|+ getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| |- getNeededResourcesTooltip(neededResources) | | 662|+ getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| |- ].filter(tip => tip).join("\n"); | | 663|+ ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| 666| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| |- } | | 664|+ } | 665| 665| | 666| 666| break; | 667| 667| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| |- break; | | 666|+ break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 665| 665| | 666| 666| break; | 667| 667| | 668| |- case "mousebuttondown": | | 668|+ case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 666| 666| break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| |- if (ev.button == SDL_BUTTON_LEFT) | | 669|+ if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| |- { | | 670|+ { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| |- var queued = Engine.HotkeyIsPressed("session.queue"); | | 671|+ var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| |- if (tryPlaceWall(queued)) | | 672|+ if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| 675| { | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ { | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| |- if (queued) | | 674|+ if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| |- { | | 675|+ { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 673| 673| { | 674| 674| if (queued) | 675| 675| { | 676| |- // continue building, just set a new starting position where we left off | | 676|+ // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| |- placementSupport.position = placementSupport.wallEndPosition; | | 677|+ placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| |- placementSupport.wallEndPosition = undefined; | | 678|+ placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| |- inputState = INPUT_BUILDING_WALL_CLICK; | | 680|+ inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| 683| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| |- } | | 681|+ } | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| |- else | | 682|+ else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| |- { | | 683|+ { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 681| 681| } | 682| 682| else | 683| 683| { | 684| |- placementSupport.Reset(); | | 684|+ placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| |- inputState = INPUT_NORMAL; | | 685|+ inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| 688| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| |- } | | 686|+ } | 687| 687| } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| |- else | | 688|+ else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 686| 686| } | 687| 687| } | 688| 688| else | 689| |- placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | 689|+ placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| |- updateBuildingPlacementPreview(); | | 691|+ updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| |- return true; | | 692|+ return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| |- } | | 693|+ } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| |- else if (ev.button == SDL_BUTTON_RIGHT) | | 694|+ else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| |- { | | 695|+ { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| |- // reset to normal input mode | | 696|+ // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| |- placementSupport.Reset(); | | 697|+ placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| |- updateBuildingPlacementPreview(); | | 698|+ updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| |- inputState = INPUT_NORMAL; | | 700|+ inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| 703| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| |- return true; | | 701|+ return true; | 702| 702| } | 703| 703| break; | 704| 704| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| |- } | | 702|+ } | 703| 703| break; | 704| 704| } | 705| 705| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| |- break; | | 703|+ break; | 704| 704| } | 705| 705| break; | 706| 706| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 710| 710| case "mousemotion": | 711| 711| let maxDragDelta = 16; | 712| 712| if (g_DragStart.distanceTo(ev) >= maxDragDelta) | 713| |- { | | 713|+ | 714| 714| // Rotate in the direction of the mouse | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| |- } | | 716|+ | 717| 717| else | 718| 718| { | 719| 719| // If the mouse is near the center, snap back to the default orientation | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| 716| } | 717| 717| else | 718| |- { | | 718|+ | 719| 719| // If the mouse is near the center, snap back to the default orientation | 720| 720| placementSupport.SetDefaultAngle(); | 721| |- } | | 721|+ | 722| 722| | 723| 723| var snapData = Engine.GuiInterfaceCall("GetFoundationSnapData", { | 724| 724| "template": placementSupport.template, | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 741| 741| // If shift is down, let the player continue placing another of the same building | 742| 742| var queued = Engine.HotkeyIsPressed("session.queue"); | 743| 743| if (tryPlaceBuilding(queued)) | 744| |- { | | 744|+ | 745| 745| if (queued) | 746| 746| inputState = INPUT_BUILDING_PLACEMENT; | 747| 747| else | 748| 748| inputState = INPUT_NORMAL; | 749| |- } | | 749|+ | 750| 750| else | 751| 751| { | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 748| 748| inputState = INPUT_NORMAL; | 749| 749| } | 750| 750| else | 751| |- { | | 751|+ | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | 753| |- } | | 753|+ | 754| 754| return true; | 755| 755| } | 756| 756| break; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 797| 797| | 798| 798| // Handle the time-warp testing features, restricted to single-player | 799| 799| if (!g_IsNetworked && g_DeveloperOverlay.isTimeWarpEnabled()) | 800| |- { | | 800|+ | 801| 801| if (ev.type == "hotkeydown" && ev.hotkey == "session.timewarp.fastforward") | 802| 802| Engine.SetSimRate(20.0); | 803| 803| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.fastforward") | 804| 804| Engine.SetSimRate(1.0); | 805| 805| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.rewind") | 806| 806| Engine.RewindTimeWarp(); | 807| |- } | | 807|+ | 808| 808| | 809| 809| if (ev.hotkey == "session.highlightguarding") | 810| 810| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 856| 856| break; | 857| 857| | 858| 858| case "hotkeydown": | 859| |- if (ev.hotkey.indexOf("selection.group.") == 0) | | 859|+ if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 857| 857| | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| |- { | | 860|+ { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| |- let now = Date.now(); | | 861|+ let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| |- if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | 862|+ if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| |- { | | 863|+ { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| |- if (ev.hotkey.indexOf("selection.group.select.") == 0) | | 864|+ if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| |- { | | 865|+ { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| |- var sptr = ev.hotkey.split("."); | | 866|+ var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| |- performGroup("snap", sptr[3]); | | 867|+ performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| 870| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| |- } | | 868|+ } | 869| 869| } | 870| 870| else | 871| 871| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| |- } | | 869|+ } | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| |- else | | 870|+ else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 868| 868| } | 869| 869| } | 870| 870| else | 871| |- { | | 871|+ { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 869| 869| } | 870| 870| else | 871| 871| { | 872| |- var sptr = ev.hotkey.split("."); | | 872|+ var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| |- performGroup(sptr[2], sptr[3]); | | 873|+ performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| |- doublePressTimer = now; | | 875|+ doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| |- prevHotkey = ev.hotkey; | | 876|+ prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| 879| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| |- } | | 877|+ } | 878| 878| } | 879| 879| break; | 880| 880| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| |- } | | 878|+ } | 879| 879| break; | 880| 880| } | 881| 881| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| |- break; | | 879|+ break; | 880| 880| } | 881| 881| break; | 882| 882| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1044|1044| placementSupport.position = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); |1045|1045| |1046|1046| if (placementSupport.mode === "wall") |1047| |- { | |1047|+ |1048|1048| // Including only the on-screen towers in the next snap candidate list is sufficient here, since the user is |1049|1049| // still selecting a starting point (which must necessarily be on-screen). (The update of the snap entities |1050|1050| // itself happens in the call to updateBuildingPlacementPreview below). |1051|1051| placementSupport.wallSnapEntitiesIncludeOffscreen = false; |1052| |- } | |1052|+ |1053|1053| else |1054|1054| { |1055|1055| // cancel if not enough resources | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1316|1316| if (templateData.attack && |1317|1317| templateData.attack.Ranged && |1318|1318| templateData.attack.Ranged.maxRange) |1319| |- { | |1319|+ |1320|1320| // add attack information to display a good tooltip |1321|1321| placementSupport.attack = templateData.attack; |1322| |- } | |1322|+ |1323|1323| } |1324|1324| |1325|1325| // Batch training: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1404|1404| if (Engine.HotkeyIsPressed("session.batchtrain") && (canBeAddedCount == undefined || canBeAddedCount > 1)) |1405|1405| { |1406|1406| if (inputState == INPUT_BATCHTRAINING) |1407| |- { | |1407|+ |1408|1408| // Check if we are training in the same building(s) as the last batch |1409|1409| // NOTE: We just check if the arrays are the same and if the order is the same |1410|1410| // If the order changed, we have a new selection and we should create a new batch. |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439|1439| // fall through to create the new batch |1440| |- } | |1440|+ |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. |1443|1443| if (decrement || Engine.GuiInterfaceCall("GetNeededResources", { "cost": | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1436|1436| // Otherwise start a new one |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439| |- // fall through to create the new batch | |1439|+ // fall through to create the new batch |1440|1440| } |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. | | [NORMAL] ESLintBear (space-in-parens): | | There should be no spaces inside this paren. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1514|1514| g_BatchTrainingEntityAllowedCount < batchedSize * appropriateBuildings.length) |1515|1515| { |1516|1516| // Train as many full batches as we can |1517| |- let buildingsCountToTrainFullBatch = Math.floor( g_BatchTrainingEntityAllowedCount / batchedSize); | |1517|+ let buildingsCountToTrainFullBatch = Math.floor(g_BatchTrainingEntityAllowedCount / batchedSize); |1518|1518| Engine.PostNetworkCommand({ |1519|1519| "type": "train", |1520|1520| "entities": appropriateBuildings.slice(0, buildingsCountToTrainFullBatch), | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1593|1593| var selectall = Engine.HotkeyIsPressed("selection.offscreen"); |1594|1594| |1595|1595| // Reset the last idle unit, etc., if the selection type has changed. |1596| |- if (selectall || classes.length != lastIdleClasses.length || !classes.every((v,i) => v === lastIdleClasses[i])) | |1596|+ if (selectall || classes.length != lastIdleClasses.length || !classes.every((v, i) => v === lastIdleClasses[i])) |1597|1597| resetIdleUnit(); |1598|1598| lastIdleClasses = classes; |1599|1599| binaries/data/mods/public/gui/session/input.js | 228| » » var·entState·=·GetEntityState(ent); | | [NORMAL] ESLintBear (no-shadow): | | 'entState' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'target' to undefined. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'actionInfo' to undefined. binaries/data/mods/public/gui/session/input.js | 466| » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 493| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 497| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 552| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 562| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 610| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 639| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 708| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 825| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 828| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 928| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1017| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1031| » » » » let·action·=·determineAction(ev.x,·ev.y); | | [NORMAL] ESLintBear (no-shadow): | | 'action' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js |1040| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1109| » » » switch·(ev.hotkey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1544| » switch·(action) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'target' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'actionInfo' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 263| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 266| » » » var·r·=·g_UnitActions[action].hotkeyActionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 271| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 274| » » » var·r·=·g_UnitActions[action].actionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 481| » » &&·(ev.button·==·SDL_BUTTON_LEFT·||·ev.button·==·SDL_BUTTON_RIGHT)) | | [NORMAL] JSHintBear: | | Misleading line break before '&&'; readers may interpret this as an expression boundary. binaries/data/mods/public/gui/session/input.js | 511| » » » » var·rect·=·updateBandbox(bandbox,·ev,·true); | | [NORMAL] JSHintBear: | | 'rect' is already defined. binaries/data/mods/public/gui/session/input.js | 514| » » » » var·ents·=·getPreferredEntities(Engine.PickPlayerEntitiesInRect(rect[0],·rect[1],·rect[2],·rect[3],·g_ViewedPlayer)); | | [NORMAL] JSHintBear: | | 'ents' is already defined. binaries/data/mods/public/gui/session/input.js | 671| » » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 711| » » » let·maxDragDelta·=·16; | | [MAJOR] JSHintBear: | | 'maxDragDelta' has already been declared. binaries/data/mods/public/gui/session/input.js | 742| » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 872| » » » » » » var·sptr·=·ev.hotkey.split("."); | | [NORMAL] JSHintBear: | | 'sptr' is already defined. binaries/data/mods/public/gui/session/input.js | 888| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/gui/session/input.js | 914| » » » } | | [NORMAL] JSHintBear: | | Expected a 'break' statement before 'default'. binaries/data/mods/public/gui/session/input.js | 938| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1623/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | 873| 873| Engine.GetGUIObjectByName("barterHelp").hidden = !canBarter; | 874| 874| | 875| 875| if (canBarter) | 876| |- g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer) }); | | 876|+ g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer); }); | 877| 877| } | 878| 878| | 879| 879| function getIdleLandTradersText(traderNumber) binaries/data/mods/public/gui/session/menu.js | 482| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 557| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 876| » » g_ResourceData.GetCodes().forEach((resCode,·i)·=>·{·barterUpdateCommon(resCode,·i,·"barter",·g_ViewedPlayer)·}); | | [NORMAL] JSHintBear: | | Missing semicolon. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 400| 400| // Players see colors depending on diplomacy | 401| 401| g_DisplayedPlayerColors[i] = | 402| 402| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 403| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 403|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 404| 404| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 405| 405| getDiplomacyColor("enemy"); | 406| 406| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 401| 401| g_DisplayedPlayerColors[i] = | 402| 402| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 403| 403| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 404| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 404|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 405| 405| getDiplomacyColor("enemy"); | 406| 406| | 407| 407| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 402| 402| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 403| 403| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 404| 404| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 405| |- getDiplomacyColor("enemy"); | | 405|+ getDiplomacyColor("enemy"); | 406| 406| | 407| 407| g_DisplayedPlayerColors[0] = g_Players[0].color; | 408| 408| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 652| 652| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 653| 653| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 654| 654| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 655| |- }); | | 655|+ }); | 656| 656| } | 657| 657| | 658| 658| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1202|1202| |1203|1203| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1204|1204| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1205| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTags), | |1205|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1206|1206| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1207|1207| }); |1208|1208| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1203|1203| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1204|1204| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1205|1205| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1206| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1206|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1207|1207| }); |1208|1208| |1209|1209| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1204|1204| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1205|1205| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1206|1206| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1207| |- }); | |1207|+ }); |1208|1208| |1209|1209| let resCodes = g_ResourceData.GetCodes(); |1210|1210| for (let r = 0; r < resCodes.length; ++r) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1687|1687| for (let rct of resourcesCounterTypes) |1688|1688| for (let rt of resourcesTypes) |1689|1689| reportObject[rt + rct.substr(9)] = playerStatistics[rct][rt]; |1690| |- // eg. rt = food rct.substr = Gathered rct = resourcesGathered | |1690|+ // eg. rt = food rct.substr = Gathered rct = resourcesGathered |1691|1691| |1692|1692| reportObject.vegetarianFoodGathered = playerStatistics.resourcesGathered.vegetarianFood; |1693|1693| for (let type of unitsClasses) binaries/data/mods/public/gui/session/session.js |1063| » let·getPanelEntNameTooltip·=·panelEntState·=>·"[font=\"sans-bold-16\"]"·+·template.name.specific·+·"[/font]"; | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1138| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1139| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1140| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 181| 181| } | 182| 182| } | 183| 183| else if (placementSupport.mode === "wall") | 184| |- { | | 184|+ | 185| 185| if (placementSupport.wallSet && placementSupport.position) | 186| 186| { | 187| 187| // Fetch an updated list of snapping candidate entities | 199| 199| "snapEntities": placementSupport.wallSnapEntities, // snapping entities (towers) for starting a wall segment | 200| 200| }); | 201| 201| } | 202| |- } | | 202|+ | 203| 203| | 204| 204| return false; | 205| 205| } | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 288| 288| } | 289| 289| | 290| 290| if (!updateBuildingPlacementPreview()) | 291| |- { | | 291|+ | 292| 292| // invalid location - don't build it | 293| 293| // TODO: play a sound? | 294| 294| return false; | 295| |- } | | 295|+ | 296| 296| | 297| 297| var selection = g_Selection.toList(); | 298| 298| | | [NORMAL] ESLintBear (space-unary-ops): | | Unary word operator 'typeof' must be followed by whitespace. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 327| 327| } | 328| 328| | 329| 329| var wallPlacementInfo = updateBuildingPlacementPreview(); // entities making up the wall (wall segments, towers, ...) | 330| |- if (!(wallPlacementInfo === false || typeof(wallPlacementInfo) === "object")) | | 330|+ if (!(wallPlacementInfo === false || typeof (wallPlacementInfo) === "object")) | 331| 331| { | 332| 332| error("Invalid updateBuildingPlacementPreview return value: " + uneval(wallPlacementInfo)); | 333| 333| return false; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'for-of'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 354| 354| // (this is somewhat non-ideal and hardcode-ish) | 355| 355| var hasWallSegment = false; | 356| 356| for (let piece of cmd.pieces) | 357| |- { | | 357|+ | 358| 358| if (piece.template != cmd.wallSet.templates.tower) // TODO: hardcode-ish :( | 359| 359| { | 360| 360| hasWallSegment = true; | 361| 361| break; | 362| 362| } | 363| |- } | | 363|+ | 364| 364| | 365| 365| if (hasWallSegment) | 366| 366| { | | [NORMAL] ESLintBear (operator-linebreak): | | '&&' should be placed at the end of the line. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 477| 477| mouseIsOverObject = (hoveredObject != null); | 478| 478| | 479| 479| // Close the menu when interacting with the game world | 480| |- if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") | 481| |- && (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | | 480|+ if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") && | | 481|+ (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | 482| 482| closeMenu(); | 483| 483| | 484| 484| // State-machine processing: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 518| 518| | 519| 519| // Update the list of selected units | 520| 520| if (Engine.HotkeyIsPressed("selection.add")) | 521| |- { | | 521|+ | 522| 522| g_Selection.addList(ents); | 523| |- } | | 523|+ | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| 525| { | 526| 526| g_Selection.removeList(ents); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 522| 522| g_Selection.addList(ents); | 523| 523| } | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| |- { | | 525|+ | 526| 526| g_Selection.removeList(ents); | 527| |- } | | 527|+ | 528| 528| else | 529| 529| { | 530| 530| g_Selection.reset(); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 578| 578| // If shift is down, let the player continue placing another of the same building | 579| 579| var queued = Engine.HotkeyIsPressed("session.queue"); | 580| 580| if (tryPlaceBuilding(queued)) | 581| |- { | | 581|+ | 582| 582| if (queued) | 583| 583| inputState = INPUT_BUILDING_PLACEMENT; | 584| 584| else | 585| 585| inputState = INPUT_NORMAL; | 586| |- } | | 586|+ | 587| 587| else | 588| 588| { | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 585| 585| inputState = INPUT_NORMAL; | 586| 586| } | 587| 587| else | 588| |- { | | 588|+ | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | 590| |- } | | 590|+ | 591| 591| return true; | 592| 592| } | 593| 593| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 638| 638| // user to continue building walls. | 639| 639| switch (ev.type) | 640| 640| { | 641| |- case "mousemotion": | | 641|+ case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 639| 639| switch (ev.type) | 640| 640| { | 641| 641| case "mousemotion": | 642| |- placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | | 642|+ placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 641| 641| case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| |- // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | 644|+ // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| |- // the ending point and the starting point to snap to. | | 645|+ // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| |- // | | 646|+ // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| |- // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | 647|+ // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| |- // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | 648|+ // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| |- // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | 649|+ // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| |- // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | 650|+ // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| |- // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | 651|+ // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| |- // points. | | 652|+ // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| |- placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | 654|+ placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| |- var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | 655|+ var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| |- if (result && result.cost) | | 657|+ if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| |- { | | 658|+ { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | 659| |- var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | | 659|+ var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 657| 657| if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| |- placementSupport.tooltipMessage = [ | | 660|+ placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| |- getEntityCostTooltip(result), | | 661|+ getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| |- getNeededResourcesTooltip(neededResources) | | 662|+ getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| |- ].filter(tip => tip).join("\n"); | | 663|+ ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| 666| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| |- } | | 664|+ } | 665| 665| | 666| 666| break; | 667| 667| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| |- break; | | 666|+ break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 665| 665| | 666| 666| break; | 667| 667| | 668| |- case "mousebuttondown": | | 668|+ case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 666| 666| break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| |- if (ev.button == SDL_BUTTON_LEFT) | | 669|+ if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| |- { | | 670|+ { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| |- var queued = Engine.HotkeyIsPressed("session.queue"); | | 671|+ var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| |- if (tryPlaceWall(queued)) | | 672|+ if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| 675| { | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ { | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| |- if (queued) | | 674|+ if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| |- { | | 675|+ { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 673| 673| { | 674| 674| if (queued) | 675| 675| { | 676| |- // continue building, just set a new starting position where we left off | | 676|+ // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| |- placementSupport.position = placementSupport.wallEndPosition; | | 677|+ placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| |- placementSupport.wallEndPosition = undefined; | | 678|+ placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| |- inputState = INPUT_BUILDING_WALL_CLICK; | | 680|+ inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| 683| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| |- } | | 681|+ } | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| |- else | | 682|+ else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| |- { | | 683|+ { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 681| 681| } | 682| 682| else | 683| 683| { | 684| |- placementSupport.Reset(); | | 684|+ placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| |- inputState = INPUT_NORMAL; | | 685|+ inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| 688| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| |- } | | 686|+ } | 687| 687| } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| |- else | | 688|+ else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 686| 686| } | 687| 687| } | 688| 688| else | 689| |- placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | 689|+ placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| |- updateBuildingPlacementPreview(); | | 691|+ updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| |- return true; | | 692|+ return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| |- } | | 693|+ } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| |- else if (ev.button == SDL_BUTTON_RIGHT) | | 694|+ else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| |- { | | 695|+ { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| |- // reset to normal input mode | | 696|+ // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| |- placementSupport.Reset(); | | 697|+ placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| |- updateBuildingPlacementPreview(); | | 698|+ updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| |- inputState = INPUT_NORMAL; | | 700|+ inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| 703| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| |- return true; | | 701|+ return true; | 702| 702| } | 703| 703| break; | 704| 704| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| |- } | | 702|+ } | 703| 703| break; | 704| 704| } | 705| 705| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| |- break; | | 703|+ break; | 704| 704| } | 705| 705| break; | 706| 706| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 710| 710| case "mousemotion": | 711| 711| let maxDragDelta = 16; | 712| 712| if (g_DragStart.distanceTo(ev) >= maxDragDelta) | 713| |- { | | 713|+ | 714| 714| // Rotate in the direction of the mouse | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| |- } | | 716|+ | 717| 717| else | 718| 718| { | 719| 719| // If the mouse is near the center, snap back to the default orientation | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| 716| } | 717| 717| else | 718| |- { | | 718|+ | 719| 719| // If the mouse is near the center, snap back to the default orientation | 720| 720| placementSupport.SetDefaultAngle(); | 721| |- } | | 721|+ | 722| 722| | 723| 723| var snapData = Engine.GuiInterfaceCall("GetFoundationSnapData", { | 724| 724| "template": placementSupport.template, | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 741| 741| // If shift is down, let the player continue placing another of the same building | 742| 742| var queued = Engine.HotkeyIsPressed("session.queue"); | 743| 743| if (tryPlaceBuilding(queued)) | 744| |- { | | 744|+ | 745| 745| if (queued) | 746| 746| inputState = INPUT_BUILDING_PLACEMENT; | 747| 747| else | 748| 748| inputState = INPUT_NORMAL; | 749| |- } | | 749|+ | 750| 750| else | 751| 751| { | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 748| 748| inputState = INPUT_NORMAL; | 749| 749| } | 750| 750| else | 751| |- { | | 751|+ | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | 753| |- } | | 753|+ | 754| 754| return true; | 755| 755| } | 756| 756| break; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 797| 797| | 798| 798| // Handle the time-warp testing features, restricted to single-player | 799| 799| if (!g_IsNetworked && g_DeveloperOverlay.isTimeWarpEnabled()) | 800| |- { | | 800|+ | 801| 801| if (ev.type == "hotkeydown" && ev.hotkey == "session.timewarp.fastforward") | 802| 802| Engine.SetSimRate(20.0); | 803| 803| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.fastforward") | 804| 804| Engine.SetSimRate(1.0); | 805| 805| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.rewind") | 806| 806| Engine.RewindTimeWarp(); | 807| |- } | | 807|+ | 808| 808| | 809| 809| if (ev.hotkey == "session.highlightguarding") | 810| 810| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 856| 856| break; | 857| 857| | 858| 858| case "hotkeydown": | 859| |- if (ev.hotkey.indexOf("selection.group.") == 0) | | 859|+ if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 857| 857| | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| |- { | | 860|+ { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| |- let now = Date.now(); | | 861|+ let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| |- if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | 862|+ if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| |- { | | 863|+ { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| |- if (ev.hotkey.indexOf("selection.group.select.") == 0) | | 864|+ if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| |- { | | 865|+ { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| |- var sptr = ev.hotkey.split("."); | | 866|+ var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| |- performGroup("snap", sptr[3]); | | 867|+ performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| 870| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| |- } | | 868|+ } | 869| 869| } | 870| 870| else | 871| 871| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| |- } | | 869|+ } | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| |- else | | 870|+ else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 868| 868| } | 869| 869| } | 870| 870| else | 871| |- { | | 871|+ { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 869| 869| } | 870| 870| else | 871| 871| { | 872| |- var sptr = ev.hotkey.split("."); | | 872|+ var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| |- performGroup(sptr[2], sptr[3]); | | 873|+ performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| |- doublePressTimer = now; | | 875|+ doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| |- prevHotkey = ev.hotkey; | | 876|+ prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| 879| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| |- } | | 877|+ } | 878| 878| } | 879| 879| break; | 880| 880| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| |- } | | 878|+ } | 879| 879| break; | 880| 880| } | 881| 881| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| |- break; | | 879|+ break; | 880| 880| } | 881| 881| break; | 882| 882| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1044|1044| placementSupport.position = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); |1045|1045| |1046|1046| if (placementSupport.mode === "wall") |1047| |- { | |1047|+ |1048|1048| // Including only the on-screen towers in the next snap candidate list is sufficient here, since the user is |1049|1049| // still selecting a starting point (which must necessarily be on-screen). (The update of the snap entities |1050|1050| // itself happens in the call to updateBuildingPlacementPreview below). |1051|1051| placementSupport.wallSnapEntitiesIncludeOffscreen = false; |1052| |- } | |1052|+ |1053|1053| else |1054|1054| { |1055|1055| // cancel if not enough resources | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1316|1316| if (templateData.attack && |1317|1317| templateData.attack.Ranged && |1318|1318| templateData.attack.Ranged.maxRange) |1319| |- { | |1319|+ |1320|1320| // add attack information to display a good tooltip |1321|1321| placementSupport.attack = templateData.attack; |1322| |- } | |1322|+ |1323|1323| } |1324|1324| |1325|1325| // Batch training: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1404|1404| if (Engine.HotkeyIsPressed("session.batchtrain") && (canBeAddedCount == undefined || canBeAddedCount > 1)) |1405|1405| { |1406|1406| if (inputState == INPUT_BATCHTRAINING) |1407| |- { | |1407|+ |1408|1408| // Check if we are training in the same building(s) as the last batch |1409|1409| // NOTE: We just check if the arrays are the same and if the order is the same |1410|1410| // If the order changed, we have a new selection and we should create a new batch. |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439|1439| // fall through to create the new batch |1440| |- } | |1440|+ |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. |1443|1443| if (decrement || Engine.GuiInterfaceCall("GetNeededResources", { "cost": | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1436|1436| // Otherwise start a new one |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439| |- // fall through to create the new batch | |1439|+ // fall through to create the new batch |1440|1440| } |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. | | [NORMAL] ESLintBear (space-in-parens): | | There should be no spaces inside this paren. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1514|1514| g_BatchTrainingEntityAllowedCount < batchedSize * appropriateBuildings.length) |1515|1515| { |1516|1516| // Train as many full batches as we can |1517| |- let buildingsCountToTrainFullBatch = Math.floor( g_BatchTrainingEntityAllowedCount / batchedSize); | |1517|+ let buildingsCountToTrainFullBatch = Math.floor(g_BatchTrainingEntityAllowedCount / batchedSize); |1518|1518| Engine.PostNetworkCommand({ |1519|1519| "type": "train", |1520|1520| "entities": appropriateBuildings.slice(0, buildingsCountToTrainFullBatch), | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1593|1593| var selectall = Engine.HotkeyIsPressed("selection.offscreen"); |1594|1594| |1595|1595| // Reset the last idle unit, etc., if the selection type has changed. |1596| |- if (selectall || classes.length != lastIdleClasses.length || !classes.every((v,i) => v === lastIdleClasses[i])) | |1596|+ if (selectall || classes.length != lastIdleClasses.length || !classes.every((v, i) => v === lastIdleClasses[i])) |1597|1597| resetIdleUnit(); |1598|1598| lastIdleClasses = classes; |1599|1599| binaries/data/mods/public/gui/session/input.js | 228| » » var·entState·=·GetEntityState(ent); | | [NORMAL] ESLintBear (no-shadow): | | 'entState' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'target' to undefined. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'actionInfo' to undefined. binaries/data/mods/public/gui/session/input.js | 466| » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 493| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 497| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 552| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 562| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 610| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 639| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 708| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 825| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 828| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 928| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1017| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1031| » » » » let·action·=·determineAction(ev.x,·ev.y); | | [NORMAL] ESLintBear (no-shadow): | | 'action' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js |1040| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1109| » » » switch·(ev.hotkey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1544| » switch·(action) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'target' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'actionInfo' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 263| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 266| » » » var·r·=·g_UnitActions[action].hotkeyActionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 271| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 274| » » » var·r·=·g_UnitActions[action].actionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 481| » » &&·(ev.button·==·SDL_BUTTON_LEFT·||·ev.button·==·SDL_BUTTON_RIGHT)) | | [NORMAL] JSHintBear: | | Misleading line break before '&&'; readers may interpret this as an expression boundary. binaries/data/mods/public/gui/session/input.js | 511| » » » » var·rect·=·updateBandbox(bandbox,·ev,·true); | | [NORMAL] JSHintBear: | | 'rect' is already defined. binaries/data/mods/public/gui/session/input.js | 514| » » » » var·ents·=·getPreferredEntities(Engine.PickPlayerEntitiesInRect(rect[0],·rect[1],·rect[2],·rect[3],·g_ViewedPlayer)); | | [NORMAL] JSHintBear: | | 'ents' is already defined. binaries/data/mods/public/gui/session/input.js | 671| » » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 711| » » » let·maxDragDelta·=·16; | | [MAJOR] JSHintBear: | | 'maxDragDelta' has already been declared. binaries/data/mods/public/gui/session/input.js | 742| » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 872| » » » » » » var·sptr·=·ev.hotkey.split("."); | | [NORMAL] JSHintBear: | | 'sptr' is already defined. binaries/data/mods/public/gui/session/input.js | 888| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/gui/session/input.js | 914| » » » } | | [NORMAL] JSHintBear: | | Expected a 'break' statement before 'default'. binaries/data/mods/public/gui/session/input.js | 938| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1624/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | 873| 873| Engine.GetGUIObjectByName("barterHelp").hidden = !canBarter; | 874| 874| | 875| 875| if (canBarter) | 876| |- g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer) }); | | 876|+ g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer); }); | 877| 877| } | 878| 878| | 879| 879| function getIdleLandTradersText(traderNumber) binaries/data/mods/public/gui/session/menu.js | 482| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 557| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 876| » » g_ResourceData.GetCodes().forEach((resCode,·i)·=>·{·barterUpdateCommon(resCode,·i,·"barter",·g_ViewedPlayer)·}); | | [NORMAL] JSHintBear: | | Missing semicolon. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 644| 644| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 645| 645| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 646| 646| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 647| |- }); | | 647|+ }); | 648| 648| } | 649| 649| | 650| 650| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1194|1194| |1195|1195| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTags), | |1197|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198|1198| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199|1199| }); |1200|1200| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1195|1195| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197|1197| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1198|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199|1199| }); |1200|1200| |1201|1201| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197|1197| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198|1198| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199| |- }); | |1199|+ }); |1200|1200| |1201|1201| let resCodes = g_ResourceData.GetCodes(); |1202|1202| for (let r = 0; r < resCodes.length; ++r) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1679|1679| for (let rct of resourcesCounterTypes) |1680|1680| for (let rt of resourcesTypes) |1681|1681| reportObject[rt + rct.substr(9)] = playerStatistics[rct][rt]; |1682| |- // eg. rt = food rct.substr = Gathered rct = resourcesGathered | |1682|+ // eg. rt = food rct.substr = Gathered rct = resourcesGathered |1683|1683| |1684|1684| reportObject.vegetarianFoodGathered = playerStatistics.resourcesGathered.vegetarianFood; |1685|1685| for (let type of unitsClasses) binaries/data/mods/public/gui/session/session.js |1055| » let·getPanelEntNameTooltip·=·panelEntState·=>·"[font=\"sans-bold-16\"]"·+·template.name.specific·+·"[/font]"; | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1130| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1131| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1132| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 181| 181| } | 182| 182| } | 183| 183| else if (placementSupport.mode === "wall") | 184| |- { | | 184|+ | 185| 185| if (placementSupport.wallSet && placementSupport.position) | 186| 186| { | 187| 187| // Fetch an updated list of snapping candidate entities | 199| 199| "snapEntities": placementSupport.wallSnapEntities, // snapping entities (towers) for starting a wall segment | 200| 200| }); | 201| 201| } | 202| |- } | | 202|+ | 203| 203| | 204| 204| return false; | 205| 205| } | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 288| 288| } | 289| 289| | 290| 290| if (!updateBuildingPlacementPreview()) | 291| |- { | | 291|+ | 292| 292| // invalid location - don't build it | 293| 293| // TODO: play a sound? | 294| 294| return false; | 295| |- } | | 295|+ | 296| 296| | 297| 297| var selection = g_Selection.toList(); | 298| 298| | | [NORMAL] ESLintBear (space-unary-ops): | | Unary word operator 'typeof' must be followed by whitespace. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 327| 327| } | 328| 328| | 329| 329| var wallPlacementInfo = updateBuildingPlacementPreview(); // entities making up the wall (wall segments, towers, ...) | 330| |- if (!(wallPlacementInfo === false || typeof(wallPlacementInfo) === "object")) | | 330|+ if (!(wallPlacementInfo === false || typeof (wallPlacementInfo) === "object")) | 331| 331| { | 332| 332| error("Invalid updateBuildingPlacementPreview return value: " + uneval(wallPlacementInfo)); | 333| 333| return false; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'for-of'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 354| 354| // (this is somewhat non-ideal and hardcode-ish) | 355| 355| var hasWallSegment = false; | 356| 356| for (let piece of cmd.pieces) | 357| |- { | | 357|+ | 358| 358| if (piece.template != cmd.wallSet.templates.tower) // TODO: hardcode-ish :( | 359| 359| { | 360| 360| hasWallSegment = true; | 361| 361| break; | 362| 362| } | 363| |- } | | 363|+ | 364| 364| | 365| 365| if (hasWallSegment) | 366| 366| { | | [NORMAL] ESLintBear (operator-linebreak): | | '&&' should be placed at the end of the line. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 477| 477| mouseIsOverObject = (hoveredObject != null); | 478| 478| | 479| 479| // Close the menu when interacting with the game world | 480| |- if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") | 481| |- && (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | | 480|+ if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") && | | 481|+ (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | 482| 482| closeMenu(); | 483| 483| | 484| 484| // State-machine processing: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 518| 518| | 519| 519| // Update the list of selected units | 520| 520| if (Engine.HotkeyIsPressed("selection.add")) | 521| |- { | | 521|+ | 522| 522| g_Selection.addList(ents); | 523| |- } | | 523|+ | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| 525| { | 526| 526| g_Selection.removeList(ents); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 522| 522| g_Selection.addList(ents); | 523| 523| } | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| |- { | | 525|+ | 526| 526| g_Selection.removeList(ents); | 527| |- } | | 527|+ | 528| 528| else | 529| 529| { | 530| 530| g_Selection.reset(); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 578| 578| // If shift is down, let the player continue placing another of the same building | 579| 579| var queued = Engine.HotkeyIsPressed("session.queue"); | 580| 580| if (tryPlaceBuilding(queued)) | 581| |- { | | 581|+ | 582| 582| if (queued) | 583| 583| inputState = INPUT_BUILDING_PLACEMENT; | 584| 584| else | 585| 585| inputState = INPUT_NORMAL; | 586| |- } | | 586|+ | 587| 587| else | 588| 588| { | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 585| 585| inputState = INPUT_NORMAL; | 586| 586| } | 587| 587| else | 588| |- { | | 588|+ | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | 590| |- } | | 590|+ | 591| 591| return true; | 592| 592| } | 593| 593| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 638| 638| // user to continue building walls. | 639| 639| switch (ev.type) | 640| 640| { | 641| |- case "mousemotion": | | 641|+ case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 639| 639| switch (ev.type) | 640| 640| { | 641| 641| case "mousemotion": | 642| |- placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | | 642|+ placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 641| 641| case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| |- // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | 644|+ // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| |- // the ending point and the starting point to snap to. | | 645|+ // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| |- // | | 646|+ // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| |- // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | 647|+ // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| |- // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | 648|+ // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| |- // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | 649|+ // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| |- // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | 650|+ // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| |- // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | 651|+ // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| |- // points. | | 652|+ // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| |- placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | 654|+ placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| |- var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | 655|+ var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| |- if (result && result.cost) | | 657|+ if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| |- { | | 658|+ { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | 659| |- var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | | 659|+ var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 657| 657| if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| |- placementSupport.tooltipMessage = [ | | 660|+ placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| |- getEntityCostTooltip(result), | | 661|+ getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| |- getNeededResourcesTooltip(neededResources) | | 662|+ getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| |- ].filter(tip => tip).join("\n"); | | 663|+ ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| 666| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| |- } | | 664|+ } | 665| 665| | 666| 666| break; | 667| 667| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| |- break; | | 666|+ break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 665| 665| | 666| 666| break; | 667| 667| | 668| |- case "mousebuttondown": | | 668|+ case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 666| 666| break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| |- if (ev.button == SDL_BUTTON_LEFT) | | 669|+ if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| |- { | | 670|+ { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| |- var queued = Engine.HotkeyIsPressed("session.queue"); | | 671|+ var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| |- if (tryPlaceWall(queued)) | | 672|+ if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| 675| { | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ { | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| |- if (queued) | | 674|+ if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| |- { | | 675|+ { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 673| 673| { | 674| 674| if (queued) | 675| 675| { | 676| |- // continue building, just set a new starting position where we left off | | 676|+ // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| |- placementSupport.position = placementSupport.wallEndPosition; | | 677|+ placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| |- placementSupport.wallEndPosition = undefined; | | 678|+ placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| |- inputState = INPUT_BUILDING_WALL_CLICK; | | 680|+ inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| 683| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| |- } | | 681|+ } | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| |- else | | 682|+ else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| |- { | | 683|+ { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 681| 681| } | 682| 682| else | 683| 683| { | 684| |- placementSupport.Reset(); | | 684|+ placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| |- inputState = INPUT_NORMAL; | | 685|+ inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| 688| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| |- } | | 686|+ } | 687| 687| } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| |- else | | 688|+ else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 686| 686| } | 687| 687| } | 688| 688| else | 689| |- placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | 689|+ placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| |- updateBuildingPlacementPreview(); | | 691|+ updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| |- return true; | | 692|+ return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| |- } | | 693|+ } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| |- else if (ev.button == SDL_BUTTON_RIGHT) | | 694|+ else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| |- { | | 695|+ { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| |- // reset to normal input mode | | 696|+ // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| |- placementSupport.Reset(); | | 697|+ placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| |- updateBuildingPlacementPreview(); | | 698|+ updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| |- inputState = INPUT_NORMAL; | | 700|+ inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| 703| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| |- return true; | | 701|+ return true; | 702| 702| } | 703| 703| break; | 704| 704| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| |- } | | 702|+ } | 703| 703| break; | 704| 704| } | 705| 705| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| |- break; | | 703|+ break; | 704| 704| } | 705| 705| break; | 706| 706| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 710| 710| case "mousemotion": | 711| 711| let maxDragDelta = 16; | 712| 712| if (g_DragStart.distanceTo(ev) >= maxDragDelta) | 713| |- { | | 713|+ | 714| 714| // Rotate in the direction of the mouse | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| |- } | | 716|+ | 717| 717| else | 718| 718| { | 719| 719| // If the mouse is near the center, snap back to the default orientation | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| 716| } | 717| 717| else | 718| |- { | | 718|+ | 719| 719| // If the mouse is near the center, snap back to the default orientation | 720| 720| placementSupport.SetDefaultAngle(); | 721| |- } | | 721|+ | 722| 722| | 723| 723| var snapData = Engine.GuiInterfaceCall("GetFoundationSnapData", { | 724| 724| "template": placementSupport.template, | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 741| 741| // If shift is down, let the player continue placing another of the same building | 742| 742| var queued = Engine.HotkeyIsPressed("session.queue"); | 743| 743| if (tryPlaceBuilding(queued)) | 744| |- { | | 744|+ | 745| 745| if (queued) | 746| 746| inputState = INPUT_BUILDING_PLACEMENT; | 747| 747| else | 748| 748| inputState = INPUT_NORMAL; | 749| |- } | | 749|+ | 750| 750| else | 751| 751| { | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 748| 748| inputState = INPUT_NORMAL; | 749| 749| } | 750| 750| else | 751| |- { | | 751|+ | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | 753| |- } | | 753|+ | 754| 754| return true; | 755| 755| } | 756| 756| break; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 797| 797| | 798| 798| // Handle the time-warp testing features, restricted to single-player | 799| 799| if (!g_IsNetworked && g_DeveloperOverlay.isTimeWarpEnabled()) | 800| |- { | | 800|+ | 801| 801| if (ev.type == "hotkeydown" && ev.hotkey == "session.timewarp.fastforward") | 802| 802| Engine.SetSimRate(20.0); | 803| 803| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.fastforward") | 804| 804| Engine.SetSimRate(1.0); | 805| 805| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.rewind") | 806| 806| Engine.RewindTimeWarp(); | 807| |- } | | 807|+ | 808| 808| | 809| 809| if (ev.hotkey == "session.highlightguarding") | 810| 810| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 856| 856| break; | 857| 857| | 858| 858| case "hotkeydown": | 859| |- if (ev.hotkey.indexOf("selection.group.") == 0) | | 859|+ if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 857| 857| | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| |- { | | 860|+ { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| |- let now = Date.now(); | | 861|+ let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| |- if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | 862|+ if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| |- { | | 863|+ { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| |- if (ev.hotkey.indexOf("selection.group.select.") == 0) | | 864|+ if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| |- { | | 865|+ { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| |- var sptr = ev.hotkey.split("."); | | 866|+ var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| |- performGroup("snap", sptr[3]); | | 867|+ performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| 870| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| |- } | | 868|+ } | 869| 869| } | 870| 870| else | 871| 871| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| |- } | | 869|+ } | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| |- else | | 870|+ else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 868| 868| } | 869| 869| } | 870| 870| else | 871| |- { | | 871|+ { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 869| 869| } | 870| 870| else | 871| 871| { | 872| |- var sptr = ev.hotkey.split("."); | | 872|+ var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| |- performGroup(sptr[2], sptr[3]); | | 873|+ performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| |- doublePressTimer = now; | | 875|+ doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| |- prevHotkey = ev.hotkey; | | 876|+ prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| 879| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| |- } | | 877|+ } | 878| 878| } | 879| 879| break; | 880| 880| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| |- } | | 878|+ } | 879| 879| break; | 880| 880| } | 881| 881| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| |- break; | | 879|+ break; | 880| 880| } | 881| 881| break; | 882| 882| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1044|1044| placementSupport.position = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); |1045|1045| |1046|1046| if (placementSupport.mode === "wall") |1047| |- { | |1047|+ |1048|1048| // Including only the on-screen towers in the next snap candidate list is sufficient here, since the user is |1049|1049| // still selecting a starting point (which must necessarily be on-screen). (The update of the snap entities |1050|1050| // itself happens in the call to updateBuildingPlacementPreview below). |1051|1051| placementSupport.wallSnapEntitiesIncludeOffscreen = false; |1052| |- } | |1052|+ |1053|1053| else |1054|1054| { |1055|1055| // cancel if not enough resources | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1316|1316| if (templateData.attack && |1317|1317| templateData.attack.Ranged && |1318|1318| templateData.attack.Ranged.maxRange) |1319| |- { | |1319|+ |1320|1320| // add attack information to display a good tooltip |1321|1321| placementSupport.attack = templateData.attack; |1322| |- } | |1322|+ |1323|1323| } |1324|1324| |1325|1325| // Batch training: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1404|1404| if (Engine.HotkeyIsPressed("session.batchtrain") && (canBeAddedCount == undefined || canBeAddedCount > 1)) |1405|1405| { |1406|1406| if (inputState == INPUT_BATCHTRAINING) |1407| |- { | |1407|+ |1408|1408| // Check if we are training in the same building(s) as the last batch |1409|1409| // NOTE: We just check if the arrays are the same and if the order is the same |1410|1410| // If the order changed, we have a new selection and we should create a new batch. |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439|1439| // fall through to create the new batch |1440| |- } | |1440|+ |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. |1443|1443| if (decrement || Engine.GuiInterfaceCall("GetNeededResources", { "cost": | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1436|1436| // Otherwise start a new one |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439| |- // fall through to create the new batch | |1439|+ // fall through to create the new batch |1440|1440| } |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. | | [NORMAL] ESLintBear (space-in-parens): | | There should be no spaces inside this paren. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1514|1514| g_BatchTrainingEntityAllowedCount < batchedSize * appropriateBuildings.length) |1515|1515| { |1516|1516| // Train as many full batches as we can |1517| |- let buildingsCountToTrainFullBatch = Math.floor( g_BatchTrainingEntityAllowedCount / batchedSize); | |1517|+ let buildingsCountToTrainFullBatch = Math.floor(g_BatchTrainingEntityAllowedCount / batchedSize); |1518|1518| Engine.PostNetworkCommand({ |1519|1519| "type": "train", |1520|1520| "entities": appropriateBuildings.slice(0, buildingsCountToTrainFullBatch), | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1593|1593| var selectall = Engine.HotkeyIsPressed("selection.offscreen"); |1594|1594| |1595|1595| // Reset the last idle unit, etc., if the selection type has changed. |1596| |- if (selectall || classes.length != lastIdleClasses.length || !classes.every((v,i) => v === lastIdleClasses[i])) | |1596|+ if (selectall || classes.length != lastIdleClasses.length || !classes.every((v, i) => v === lastIdleClasses[i])) |1597|1597| resetIdleUnit(); |1598|1598| lastIdleClasses = classes; |1599|1599| binaries/data/mods/public/gui/session/input.js | 228| » » var·entState·=·GetEntityState(ent); | | [NORMAL] ESLintBear (no-shadow): | | 'entState' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'target' to undefined. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'actionInfo' to undefined. binaries/data/mods/public/gui/session/input.js | 466| » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 493| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 497| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 552| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 562| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 610| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 639| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 708| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 825| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 828| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 928| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1017| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1031| » » » » let·action·=·determineAction(ev.x,·ev.y); | | [NORMAL] ESLintBear (no-shadow): | | 'action' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js |1040| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1109| » » » switch·(ev.hotkey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1544| » switch·(action) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'target' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'actionInfo' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 263| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 266| » » » var·r·=·g_UnitActions[action].hotkeyActionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 271| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 274| » » » var·r·=·g_UnitActions[action].actionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 481| » » &&·(ev.button·==·SDL_BUTTON_LEFT·||·ev.button·==·SDL_BUTTON_RIGHT)) | | [NORMAL] JSHintBear: | | Misleading line break before '&&'; readers may interpret this as an expression boundary. binaries/data/mods/public/gui/session/input.js | 511| » » » » var·rect·=·updateBandbox(bandbox,·ev,·true); | | [NORMAL] JSHintBear: | | 'rect' is already defined. binaries/data/mods/public/gui/session/input.js | 514| » » » » var·ents·=·getPreferredEntities(Engine.PickPlayerEntitiesInRect(rect[0],·rect[1],·rect[2],·rect[3],·g_ViewedPlayer)); | | [NORMAL] JSHintBear: | | 'ents' is already defined. binaries/data/mods/public/gui/session/input.js | 671| » » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 711| » » » let·maxDragDelta·=·16; | | [MAJOR] JSHintBear: | | 'maxDragDelta' has already been declared. binaries/data/mods/public/gui/session/input.js | 742| » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 872| » » » » » » var·sptr·=·ev.hotkey.split("."); | | [NORMAL] JSHintBear: | | 'sptr' is already defined. binaries/data/mods/public/gui/session/input.js | 888| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/gui/session/input.js | 914| » » » } | | [NORMAL] JSHintBear: | | Expected a 'break' statement before 'default'. binaries/data/mods/public/gui/session/input.js | 938| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1634/display/redirect Comment Actions This is kind of blurring the sort of MVC pattern we had before. Now the part updating the GUI and the part holding the state are in the same component. It's not necessarily an issue (particularly here since this component isn't intended to be re-usable elsewhere) but we should perhaps think of a more general solution.
Comment Actions Yeah, I said that too (http://irclogs.wildfiregames.com/2019-06/2019-06-05-QuakeNet-%230ad-dev.log):
Comment Actions To be honest I think the best system for the GUI could be similar to what the 'mobx' library does (on top of React), where views can have internal state or depend on external state, and updating any of that state redraws appropriately. It sounds like it would be implementable for 0 A.D. I don't think holding state in the GUI object is too problematic for self-contained objects like the developer overlay. Comment Actions Looks much better to me, perhaps changePerspective can be avoided by using just the checked() value as the state (I don't remember and didnt investigate why thats a separate variable), controlAll might or might not be buggy because the state is in the simulation and if cheats are disabled (in multiplayermode), then clicking this will not succeed to control all units, but the checkbox might or might not still be ticked (I didn't test). (I mean that might be the case before the patch already, and I didn't check what this revision does to that aspect...)
Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | 873| 873| Engine.GetGUIObjectByName("barterHelp").hidden = !canBarter; | 874| 874| | 875| 875| if (canBarter) | 876| |- g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer) }); | | 876|+ g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer); }); | 877| 877| } | 878| 878| | 879| 879| function getIdleLandTradersText(traderNumber) binaries/data/mods/public/gui/session/menu.js | 482| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 557| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 876| » » g_ResourceData.GetCodes().forEach((resCode,·i)·=>·{·barterUpdateCommon(resCode,·i,·"barter",·g_ViewedPlayer)·}); | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 181| 181| } | 182| 182| } | 183| 183| else if (placementSupport.mode === "wall") | 184| |- { | | 184|+ | 185| 185| if (placementSupport.wallSet && placementSupport.position) | 186| 186| { | 187| 187| // Fetch an updated list of snapping candidate entities | 199| 199| "snapEntities": placementSupport.wallSnapEntities, // snapping entities (towers) for starting a wall segment | 200| 200| }); | 201| 201| } | 202| |- } | | 202|+ | 203| 203| | 204| 204| return false; | 205| 205| } | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 288| 288| } | 289| 289| | 290| 290| if (!updateBuildingPlacementPreview()) | 291| |- { | | 291|+ | 292| 292| // invalid location - don't build it | 293| 293| // TODO: play a sound? | 294| 294| return false; | 295| |- } | | 295|+ | 296| 296| | 297| 297| var selection = g_Selection.toList(); | 298| 298| | | [NORMAL] ESLintBear (space-unary-ops): | | Unary word operator 'typeof' must be followed by whitespace. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 327| 327| } | 328| 328| | 329| 329| var wallPlacementInfo = updateBuildingPlacementPreview(); // entities making up the wall (wall segments, towers, ...) | 330| |- if (!(wallPlacementInfo === false || typeof(wallPlacementInfo) === "object")) | | 330|+ if (!(wallPlacementInfo === false || typeof (wallPlacementInfo) === "object")) | 331| 331| { | 332| 332| error("Invalid updateBuildingPlacementPreview return value: " + uneval(wallPlacementInfo)); | 333| 333| return false; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'for-of'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 354| 354| // (this is somewhat non-ideal and hardcode-ish) | 355| 355| var hasWallSegment = false; | 356| 356| for (let piece of cmd.pieces) | 357| |- { | | 357|+ | 358| 358| if (piece.template != cmd.wallSet.templates.tower) // TODO: hardcode-ish :( | 359| 359| { | 360| 360| hasWallSegment = true; | 361| 361| break; | 362| 362| } | 363| |- } | | 363|+ | 364| 364| | 365| 365| if (hasWallSegment) | 366| 366| { | | [NORMAL] ESLintBear (operator-linebreak): | | '&&' should be placed at the end of the line. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 477| 477| mouseIsOverObject = (hoveredObject != null); | 478| 478| | 479| 479| // Close the menu when interacting with the game world | 480| |- if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") | 481| |- && (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | | 480|+ if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") && | | 481|+ (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | 482| 482| closeMenu(); | 483| 483| | 484| 484| // State-machine processing: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 518| 518| | 519| 519| // Update the list of selected units | 520| 520| if (Engine.HotkeyIsPressed("selection.add")) | 521| |- { | | 521|+ | 522| 522| g_Selection.addList(ents); | 523| |- } | | 523|+ | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| 525| { | 526| 526| g_Selection.removeList(ents); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 522| 522| g_Selection.addList(ents); | 523| 523| } | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| |- { | | 525|+ | 526| 526| g_Selection.removeList(ents); | 527| |- } | | 527|+ | 528| 528| else | 529| 529| { | 530| 530| g_Selection.reset(); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 578| 578| // If shift is down, let the player continue placing another of the same building | 579| 579| var queued = Engine.HotkeyIsPressed("session.queue"); | 580| 580| if (tryPlaceBuilding(queued)) | 581| |- { | | 581|+ | 582| 582| if (queued) | 583| 583| inputState = INPUT_BUILDING_PLACEMENT; | 584| 584| else | 585| 585| inputState = INPUT_NORMAL; | 586| |- } | | 586|+ | 587| 587| else | 588| 588| { | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 585| 585| inputState = INPUT_NORMAL; | 586| 586| } | 587| 587| else | 588| |- { | | 588|+ | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | 590| |- } | | 590|+ | 591| 591| return true; | 592| 592| } | 593| 593| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 638| 638| // user to continue building walls. | 639| 639| switch (ev.type) | 640| 640| { | 641| |- case "mousemotion": | | 641|+ case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 639| 639| switch (ev.type) | 640| 640| { | 641| 641| case "mousemotion": | 642| |- placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | | 642|+ placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 641| 641| case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| |- // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | 644|+ // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| |- // the ending point and the starting point to snap to. | | 645|+ // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| |- // | | 646|+ // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| |- // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | 647|+ // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| |- // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | 648|+ // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| |- // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | 649|+ // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| |- // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | 650|+ // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| |- // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | 651|+ // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| |- // points. | | 652|+ // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| |- placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | 654|+ placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| |- var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | 655|+ var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| |- if (result && result.cost) | | 657|+ if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| |- { | | 658|+ { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | 659| |- var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | | 659|+ var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 657| 657| if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| |- placementSupport.tooltipMessage = [ | | 660|+ placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| |- getEntityCostTooltip(result), | | 661|+ getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| |- getNeededResourcesTooltip(neededResources) | | 662|+ getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| |- ].filter(tip => tip).join("\n"); | | 663|+ ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| 666| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| |- } | | 664|+ } | 665| 665| | 666| 666| break; | 667| 667| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| |- break; | | 666|+ break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 665| 665| | 666| 666| break; | 667| 667| | 668| |- case "mousebuttondown": | | 668|+ case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 666| 666| break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| |- if (ev.button == SDL_BUTTON_LEFT) | | 669|+ if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| |- { | | 670|+ { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| |- var queued = Engine.HotkeyIsPressed("session.queue"); | | 671|+ var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| |- if (tryPlaceWall(queued)) | | 672|+ if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| 675| { | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ { | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| |- if (queued) | | 674|+ if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| |- { | | 675|+ { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 673| 673| { | 674| 674| if (queued) | 675| 675| { | 676| |- // continue building, just set a new starting position where we left off | | 676|+ // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| |- placementSupport.position = placementSupport.wallEndPosition; | | 677|+ placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| |- placementSupport.wallEndPosition = undefined; | | 678|+ placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| |- inputState = INPUT_BUILDING_WALL_CLICK; | | 680|+ inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| 683| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| |- } | | 681|+ } | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| |- else | | 682|+ else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| |- { | | 683|+ { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 681| 681| } | 682| 682| else | 683| 683| { | 684| |- placementSupport.Reset(); | | 684|+ placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| |- inputState = INPUT_NORMAL; | | 685|+ inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| 688| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| |- } | | 686|+ } | 687| 687| } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| |- else | | 688|+ else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 686| 686| } | 687| 687| } | 688| 688| else | 689| |- placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | 689|+ placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| |- updateBuildingPlacementPreview(); | | 691|+ updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| |- return true; | | 692|+ return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| |- } | | 693|+ } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| |- else if (ev.button == SDL_BUTTON_RIGHT) | | 694|+ else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| |- { | | 695|+ { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| |- // reset to normal input mode | | 696|+ // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| |- placementSupport.Reset(); | | 697|+ placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| |- updateBuildingPlacementPreview(); | | 698|+ updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| |- inputState = INPUT_NORMAL; | | 700|+ inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| 703| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| |- return true; | | 701|+ return true; | 702| 702| } | 703| 703| break; | 704| 704| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| |- } | | 702|+ } | 703| 703| break; | 704| 704| } | 705| 705| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| |- break; | | 703|+ break; | 704| 704| } | 705| 705| break; | 706| 706| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 710| 710| case "mousemotion": | 711| 711| let maxDragDelta = 16; | 712| 712| if (g_DragStart.distanceTo(ev) >= maxDragDelta) | 713| |- { | | 713|+ | 714| 714| // Rotate in the direction of the mouse | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| |- } | | 716|+ | 717| 717| else | 718| 718| { | 719| 719| // If the mouse is near the center, snap back to the default orientation | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| 716| } | 717| 717| else | 718| |- { | | 718|+ | 719| 719| // If the mouse is near the center, snap back to the default orientation | 720| 720| placementSupport.SetDefaultAngle(); | 721| |- } | | 721|+ | 722| 722| | 723| 723| var snapData = Engine.GuiInterfaceCall("GetFoundationSnapData", { | 724| 724| "template": placementSupport.template, | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 741| 741| // If shift is down, let the player continue placing another of the same building | 742| 742| var queued = Engine.HotkeyIsPressed("session.queue"); | 743| 743| if (tryPlaceBuilding(queued)) | 744| |- { | | 744|+ | 745| 745| if (queued) | 746| 746| inputState = INPUT_BUILDING_PLACEMENT; | 747| 747| else | 748| 748| inputState = INPUT_NORMAL; | 749| |- } | | 749|+ | 750| 750| else | 751| 751| { | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 748| 748| inputState = INPUT_NORMAL; | 749| 749| } | 750| 750| else | 751| |- { | | 751|+ | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | 753| |- } | | 753|+ | 754| 754| return true; | 755| 755| } | 756| 756| break; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 797| 797| | 798| 798| // Handle the time-warp testing features, restricted to single-player | 799| 799| if (!g_IsNetworked && g_DeveloperOverlay.isTimeWarpEnabled()) | 800| |- { | | 800|+ | 801| 801| if (ev.type == "hotkeydown" && ev.hotkey == "session.timewarp.fastforward") | 802| 802| Engine.SetSimRate(20.0); | 803| 803| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.fastforward") | 804| 804| Engine.SetSimRate(1.0); | 805| 805| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.rewind") | 806| 806| Engine.RewindTimeWarp(); | 807| |- } | | 807|+ | 808| 808| | 809| 809| if (ev.hotkey == "session.highlightguarding") | 810| 810| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 856| 856| break; | 857| 857| | 858| 858| case "hotkeydown": | 859| |- if (ev.hotkey.indexOf("selection.group.") == 0) | | 859|+ if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 857| 857| | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| |- { | | 860|+ { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| |- let now = Date.now(); | | 861|+ let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| |- if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | 862|+ if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| |- { | | 863|+ { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| |- if (ev.hotkey.indexOf("selection.group.select.") == 0) | | 864|+ if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| |- { | | 865|+ { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| |- var sptr = ev.hotkey.split("."); | | 866|+ var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| |- performGroup("snap", sptr[3]); | | 867|+ performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| 870| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| |- } | | 868|+ } | 869| 869| } | 870| 870| else | 871| 871| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| |- } | | 869|+ } | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| |- else | | 870|+ else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 868| 868| } | 869| 869| } | 870| 870| else | 871| |- { | | 871|+ { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 869| 869| } | 870| 870| else | 871| 871| { | 872| |- var sptr = ev.hotkey.split("."); | | 872|+ var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| |- performGroup(sptr[2], sptr[3]); | | 873|+ performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| |- doublePressTimer = now; | | 875|+ doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| |- prevHotkey = ev.hotkey; | | 876|+ prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| 879| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| |- } | | 877|+ } | 878| 878| } | 879| 879| break; | 880| 880| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| |- } | | 878|+ } | 879| 879| break; | 880| 880| } | 881| 881| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| |- break; | | 879|+ break; | 880| 880| } | 881| 881| break; | 882| 882| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1044|1044| placementSupport.position = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); |1045|1045| |1046|1046| if (placementSupport.mode === "wall") |1047| |- { | |1047|+ |1048|1048| // Including only the on-screen towers in the next snap candidate list is sufficient here, since the user is |1049|1049| // still selecting a starting point (which must necessarily be on-screen). (The update of the snap entities |1050|1050| // itself happens in the call to updateBuildingPlacementPreview below). |1051|1051| placementSupport.wallSnapEntitiesIncludeOffscreen = false; |1052| |- } | |1052|+ |1053|1053| else |1054|1054| { |1055|1055| // cancel if not enough resources | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1316|1316| if (templateData.attack && |1317|1317| templateData.attack.Ranged && |1318|1318| templateData.attack.Ranged.maxRange) |1319| |- { | |1319|+ |1320|1320| // add attack information to display a good tooltip |1321|1321| placementSupport.attack = templateData.attack; |1322| |- } | |1322|+ |1323|1323| } |1324|1324| |1325|1325| // Batch training: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1404|1404| if (Engine.HotkeyIsPressed("session.batchtrain") && (canBeAddedCount == undefined || canBeAddedCount > 1)) |1405|1405| { |1406|1406| if (inputState == INPUT_BATCHTRAINING) |1407| |- { | |1407|+ |1408|1408| // Check if we are training in the same building(s) as the last batch |1409|1409| // NOTE: We just check if the arrays are the same and if the order is the same |1410|1410| // If the order changed, we have a new selection and we should create a new batch. |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439|1439| // fall through to create the new batch |1440| |- } | |1440|+ |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. |1443|1443| if (decrement || Engine.GuiInterfaceCall("GetNeededResources", { "cost": | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1436|1436| // Otherwise start a new one |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439| |- // fall through to create the new batch | |1439|+ // fall through to create the new batch |1440|1440| } |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. | | [NORMAL] ESLintBear (space-in-parens): | | There should be no spaces inside this paren. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1514|1514| g_BatchTrainingEntityAllowedCount < batchedSize * appropriateBuildings.length) |1515|1515| { |1516|1516| // Train as many full batches as we can |1517| |- let buildingsCountToTrainFullBatch = Math.floor( g_BatchTrainingEntityAllowedCount / batchedSize); | |1517|+ let buildingsCountToTrainFullBatch = Math.floor(g_BatchTrainingEntityAllowedCount / batchedSize); |1518|1518| Engine.PostNetworkCommand({ |1519|1519| "type": "train", |1520|1520| "entities": appropriateBuildings.slice(0, buildingsCountToTrainFullBatch), | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1593|1593| var selectall = Engine.HotkeyIsPressed("selection.offscreen"); |1594|1594| |1595|1595| // Reset the last idle unit, etc., if the selection type has changed. |1596| |- if (selectall || classes.length != lastIdleClasses.length || !classes.every((v,i) => v === lastIdleClasses[i])) | |1596|+ if (selectall || classes.length != lastIdleClasses.length || !classes.every((v, i) => v === lastIdleClasses[i])) |1597|1597| resetIdleUnit(); |1598|1598| lastIdleClasses = classes; |1599|1599| binaries/data/mods/public/gui/session/input.js | 228| » » var·entState·=·GetEntityState(ent); | | [NORMAL] ESLintBear (no-shadow): | | 'entState' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'target' to undefined. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'actionInfo' to undefined. binaries/data/mods/public/gui/session/input.js | 466| » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 493| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 497| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 552| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 562| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 610| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 639| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 708| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 825| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 828| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 928| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1017| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1031| » » » » let·action·=·determineAction(ev.x,·ev.y); | | [NORMAL] ESLintBear (no-shadow): | | 'action' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js |1040| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1109| » » » switch·(ev.hotkey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1544| » switch·(action) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'target' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'actionInfo' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 263| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 266| » » » var·r·=·g_UnitActions[action].hotkeyActionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 271| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 274| » » » var·r·=·g_UnitActions[action].actionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 481| » » &&·(ev.button·==·SDL_BUTTON_LEFT·||·ev.button·==·SDL_BUTTON_RIGHT)) | | [NORMAL] JSHintBear: | | Misleading line break before '&&'; readers may interpret this as an expression boundary. binaries/data/mods/public/gui/session/input.js | 511| » » » » var·rect·=·updateBandbox(bandbox,·ev,·true); | | [NORMAL] JSHintBear: | | 'rect' is already defined. binaries/data/mods/public/gui/session/input.js | 514| » » » » var·ents·=·getPreferredEntities(Engine.PickPlayerEntitiesInRect(rect[0],·rect[1],·rect[2],·rect[3],·g_ViewedPlayer)); | | [NORMAL] JSHintBear: | | 'ents' is already defined. binaries/data/mods/public/gui/session/input.js | 671| » » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 711| » » » let·maxDragDelta·=·16; | | [MAJOR] JSHintBear: | | 'maxDragDelta' has already been declared. binaries/data/mods/public/gui/session/input.js | 742| » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 872| » » » » » » var·sptr·=·ev.hotkey.split("."); | | [NORMAL] JSHintBear: | | 'sptr' is already defined. binaries/data/mods/public/gui/session/input.js | 888| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/gui/session/input.js | 914| » » » } | | [NORMAL] JSHintBear: | | Expected a 'break' statement before 'default'. binaries/data/mods/public/gui/session/input.js | 938| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 644| 644| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 645| 645| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 646| 646| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 647| |- }); | | 647|+ }); | 648| 648| } | 649| 649| | 650| 650| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1194|1194| |1195|1195| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTags), | |1197|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198|1198| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199|1199| }); |1200|1200| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1195|1195| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197|1197| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1198|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199|1199| }); |1200|1200| |1201|1201| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197|1197| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198|1198| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199| |- }); | |1199|+ }); |1200|1200| |1201|1201| let resCodes = g_ResourceData.GetCodes(); |1202|1202| for (let r = 0; r < resCodes.length; ++r) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1679|1679| for (let rct of resourcesCounterTypes) |1680|1680| for (let rt of resourcesTypes) |1681|1681| reportObject[rt + rct.substr(9)] = playerStatistics[rct][rt]; |1682| |- // eg. rt = food rct.substr = Gathered rct = resourcesGathered | |1682|+ // eg. rt = food rct.substr = Gathered rct = resourcesGathered |1683|1683| |1684|1684| reportObject.vegetarianFoodGathered = playerStatistics.resourcesGathered.vegetarianFood; |1685|1685| for (let type of unitsClasses) binaries/data/mods/public/gui/session/session.js |1055| » let·getPanelEntNameTooltip·=·panelEntState·=>·"[font=\"sans-bold-16\"]"·+·template.name.specific·+·"[/font]"; | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1130| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1131| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1132| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1662/display/redirect Comment Actions The patch looks very good to me.
Comment Actions Fixes notes.
Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 644| 644| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 645| 645| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 646| 646| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 647| |- }); | | 647|+ }); | 648| 648| } | 649| 649| | 650| 650| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1194|1194| |1195|1195| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTags), | |1197|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198|1198| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199|1199| }); |1200|1200| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1195|1195| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197|1197| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1198|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199|1199| }); |1200|1200| |1201|1201| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197|1197| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198|1198| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199| |- }); | |1199|+ }); |1200|1200| |1201|1201| let resCodes = g_ResourceData.GetCodes(); |1202|1202| for (let r = 0; r < resCodes.length; ++r) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1679|1679| for (let rct of resourcesCounterTypes) |1680|1680| for (let rt of resourcesTypes) |1681|1681| reportObject[rt + rct.substr(9)] = playerStatistics[rct][rt]; |1682| |- // eg. rt = food rct.substr = Gathered rct = resourcesGathered | |1682|+ // eg. rt = food rct.substr = Gathered rct = resourcesGathered |1683|1683| |1684|1684| reportObject.vegetarianFoodGathered = playerStatistics.resourcesGathered.vegetarianFood; |1685|1685| for (let type of unitsClasses) binaries/data/mods/public/gui/session/session.js |1055| » let·getPanelEntNameTooltip·=·panelEntState·=>·"[font=\"sans-bold-16\"]"·+·template.name.specific·+·"[/font]"; | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1130| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1131| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1132| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 181| 181| } | 182| 182| } | 183| 183| else if (placementSupport.mode === "wall") | 184| |- { | | 184|+ | 185| 185| if (placementSupport.wallSet && placementSupport.position) | 186| 186| { | 187| 187| // Fetch an updated list of snapping candidate entities | 199| 199| "snapEntities": placementSupport.wallSnapEntities, // snapping entities (towers) for starting a wall segment | 200| 200| }); | 201| 201| } | 202| |- } | | 202|+ | 203| 203| | 204| 204| return false; | 205| 205| } | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 288| 288| } | 289| 289| | 290| 290| if (!updateBuildingPlacementPreview()) | 291| |- { | | 291|+ | 292| 292| // invalid location - don't build it | 293| 293| // TODO: play a sound? | 294| 294| return false; | 295| |- } | | 295|+ | 296| 296| | 297| 297| var selection = g_Selection.toList(); | 298| 298| | | [NORMAL] ESLintBear (space-unary-ops): | | Unary word operator 'typeof' must be followed by whitespace. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 327| 327| } | 328| 328| | 329| 329| var wallPlacementInfo = updateBuildingPlacementPreview(); // entities making up the wall (wall segments, towers, ...) | 330| |- if (!(wallPlacementInfo === false || typeof(wallPlacementInfo) === "object")) | | 330|+ if (!(wallPlacementInfo === false || typeof (wallPlacementInfo) === "object")) | 331| 331| { | 332| 332| error("Invalid updateBuildingPlacementPreview return value: " + uneval(wallPlacementInfo)); | 333| 333| return false; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'for-of'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 354| 354| // (this is somewhat non-ideal and hardcode-ish) | 355| 355| var hasWallSegment = false; | 356| 356| for (let piece of cmd.pieces) | 357| |- { | | 357|+ | 358| 358| if (piece.template != cmd.wallSet.templates.tower) // TODO: hardcode-ish :( | 359| 359| { | 360| 360| hasWallSegment = true; | 361| 361| break; | 362| 362| } | 363| |- } | | 363|+ | 364| 364| | 365| 365| if (hasWallSegment) | 366| 366| { | | [NORMAL] ESLintBear (operator-linebreak): | | '&&' should be placed at the end of the line. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 477| 477| mouseIsOverObject = (hoveredObject != null); | 478| 478| | 479| 479| // Close the menu when interacting with the game world | 480| |- if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") | 481| |- && (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | | 480|+ if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") && | | 481|+ (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | 482| 482| closeMenu(); | 483| 483| | 484| 484| // State-machine processing: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 518| 518| | 519| 519| // Update the list of selected units | 520| 520| if (Engine.HotkeyIsPressed("selection.add")) | 521| |- { | | 521|+ | 522| 522| g_Selection.addList(ents); | 523| |- } | | 523|+ | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| 525| { | 526| 526| g_Selection.removeList(ents); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 522| 522| g_Selection.addList(ents); | 523| 523| } | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| |- { | | 525|+ | 526| 526| g_Selection.removeList(ents); | 527| |- } | | 527|+ | 528| 528| else | 529| 529| { | 530| 530| g_Selection.reset(); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 578| 578| // If shift is down, let the player continue placing another of the same building | 579| 579| var queued = Engine.HotkeyIsPressed("session.queue"); | 580| 580| if (tryPlaceBuilding(queued)) | 581| |- { | | 581|+ | 582| 582| if (queued) | 583| 583| inputState = INPUT_BUILDING_PLACEMENT; | 584| 584| else | 585| 585| inputState = INPUT_NORMAL; | 586| |- } | | 586|+ | 587| 587| else | 588| 588| { | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 585| 585| inputState = INPUT_NORMAL; | 586| 586| } | 587| 587| else | 588| |- { | | 588|+ | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | 590| |- } | | 590|+ | 591| 591| return true; | 592| 592| } | 593| 593| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 638| 638| // user to continue building walls. | 639| 639| switch (ev.type) | 640| 640| { | 641| |- case "mousemotion": | | 641|+ case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 639| 639| switch (ev.type) | 640| 640| { | 641| 641| case "mousemotion": | 642| |- placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | | 642|+ placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 641| 641| case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| |- // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | 644|+ // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| |- // the ending point and the starting point to snap to. | | 645|+ // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| |- // | | 646|+ // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| |- // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | 647|+ // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| |- // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | 648|+ // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| |- // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | 649|+ // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| |- // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | 650|+ // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| |- // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | 651|+ // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| |- // points. | | 652|+ // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| |- placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | 654|+ placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| |- var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | 655|+ var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| |- if (result && result.cost) | | 657|+ if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| |- { | | 658|+ { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | 659| |- var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | | 659|+ var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 657| 657| if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| |- placementSupport.tooltipMessage = [ | | 660|+ placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| |- getEntityCostTooltip(result), | | 661|+ getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| |- getNeededResourcesTooltip(neededResources) | | 662|+ getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| |- ].filter(tip => tip).join("\n"); | | 663|+ ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| 666| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| |- } | | 664|+ } | 665| 665| | 666| 666| break; | 667| 667| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| |- break; | | 666|+ break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 665| 665| | 666| 666| break; | 667| 667| | 668| |- case "mousebuttondown": | | 668|+ case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 666| 666| break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| |- if (ev.button == SDL_BUTTON_LEFT) | | 669|+ if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| |- { | | 670|+ { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| |- var queued = Engine.HotkeyIsPressed("session.queue"); | | 671|+ var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| |- if (tryPlaceWall(queued)) | | 672|+ if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| 675| { | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ { | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| |- if (queued) | | 674|+ if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| |- { | | 675|+ { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 673| 673| { | 674| 674| if (queued) | 675| 675| { | 676| |- // continue building, just set a new starting position where we left off | | 676|+ // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| |- placementSupport.position = placementSupport.wallEndPosition; | | 677|+ placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| |- placementSupport.wallEndPosition = undefined; | | 678|+ placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| |- inputState = INPUT_BUILDING_WALL_CLICK; | | 680|+ inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| 683| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| |- } | | 681|+ } | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| |- else | | 682|+ else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| |- { | | 683|+ { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 681| 681| } | 682| 682| else | 683| 683| { | 684| |- placementSupport.Reset(); | | 684|+ placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| |- inputState = INPUT_NORMAL; | | 685|+ inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| 688| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| |- } | | 686|+ } | 687| 687| } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| |- else | | 688|+ else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 686| 686| } | 687| 687| } | 688| 688| else | 689| |- placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | 689|+ placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| |- updateBuildingPlacementPreview(); | | 691|+ updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| |- return true; | | 692|+ return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| |- } | | 693|+ } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| |- else if (ev.button == SDL_BUTTON_RIGHT) | | 694|+ else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| |- { | | 695|+ { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| |- // reset to normal input mode | | 696|+ // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| |- placementSupport.Reset(); | | 697|+ placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| |- updateBuildingPlacementPreview(); | | 698|+ updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| |- inputState = INPUT_NORMAL; | | 700|+ inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| 703| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| |- return true; | | 701|+ return true; | 702| 702| } | 703| 703| break; | 704| 704| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| |- } | | 702|+ } | 703| 703| break; | 704| 704| } | 705| 705| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| |- break; | | 703|+ break; | 704| 704| } | 705| 705| break; | 706| 706| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 710| 710| case "mousemotion": | 711| 711| let maxDragDelta = 16; | 712| 712| if (g_DragStart.distanceTo(ev) >= maxDragDelta) | 713| |- { | | 713|+ | 714| 714| // Rotate in the direction of the mouse | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| |- } | | 716|+ | 717| 717| else | 718| 718| { | 719| 719| // If the mouse is near the center, snap back to the default orientation | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| 716| } | 717| 717| else | 718| |- { | | 718|+ | 719| 719| // If the mouse is near the center, snap back to the default orientation | 720| 720| placementSupport.SetDefaultAngle(); | 721| |- } | | 721|+ | 722| 722| | 723| 723| var snapData = Engine.GuiInterfaceCall("GetFoundationSnapData", { | 724| 724| "template": placementSupport.template, | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 741| 741| // If shift is down, let the player continue placing another of the same building | 742| 742| var queued = Engine.HotkeyIsPressed("session.queue"); | 743| 743| if (tryPlaceBuilding(queued)) | 744| |- { | | 744|+ | 745| 745| if (queued) | 746| 746| inputState = INPUT_BUILDING_PLACEMENT; | 747| 747| else | 748| 748| inputState = INPUT_NORMAL; | 749| |- } | | 749|+ | 750| 750| else | 751| 751| { | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 748| 748| inputState = INPUT_NORMAL; | 749| 749| } | 750| 750| else | 751| |- { | | 751|+ | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | 753| |- } | | 753|+ | 754| 754| return true; | 755| 755| } | 756| 756| break; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 797| 797| | 798| 798| // Handle the time-warp testing features, restricted to single-player | 799| 799| if (!g_IsNetworked && g_DeveloperOverlay.isTimeWarpEnabled()) | 800| |- { | | 800|+ | 801| 801| if (ev.type == "hotkeydown" && ev.hotkey == "session.timewarp.fastforward") | 802| 802| Engine.SetSimRate(20.0); | 803| 803| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.fastforward") | 804| 804| Engine.SetSimRate(1.0); | 805| 805| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.rewind") | 806| 806| Engine.RewindTimeWarp(); | 807| |- } | | 807|+ | 808| 808| | 809| 809| if (ev.hotkey == "session.highlightguarding") | 810| 810| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 856| 856| break; | 857| 857| | 858| 858| case "hotkeydown": | 859| |- if (ev.hotkey.indexOf("selection.group.") == 0) | | 859|+ if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 857| 857| | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| |- { | | 860|+ { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| |- let now = Date.now(); | | 861|+ let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| |- if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | 862|+ if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| |- { | | 863|+ { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| |- if (ev.hotkey.indexOf("selection.group.select.") == 0) | | 864|+ if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| |- { | | 865|+ { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| |- var sptr = ev.hotkey.split("."); | | 866|+ var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| |- performGroup("snap", sptr[3]); | | 867|+ performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| 870| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| |- } | | 868|+ } | 869| 869| } | 870| 870| else | 871| 871| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| |- } | | 869|+ } | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| |- else | | 870|+ else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 868| 868| } | 869| 869| } | 870| 870| else | 871| |- { | | 871|+ { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 869| 869| } | 870| 870| else | 871| 871| { | 872| |- var sptr = ev.hotkey.split("."); | | 872|+ var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| |- performGroup(sptr[2], sptr[3]); | | 873|+ performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| |- doublePressTimer = now; | | 875|+ doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| |- prevHotkey = ev.hotkey; | | 876|+ prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| 879| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| |- } | | 877|+ } | 878| 878| } | 879| 879| break; | 880| 880| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| |- } | | 878|+ } | 879| 879| break; | 880| 880| } | 881| 881| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| |- break; | | 879|+ break; | 880| 880| } | 881| 881| break; | 882| 882| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1044|1044| placementSupport.position = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); |1045|1045| |1046|1046| if (placementSupport.mode === "wall") |1047| |- { | |1047|+ |1048|1048| // Including only the on-screen towers in the next snap candidate list is sufficient here, since the user is |1049|1049| // still selecting a starting point (which must necessarily be on-screen). (The update of the snap entities |1050|1050| // itself happens in the call to updateBuildingPlacementPreview below). |1051|1051| placementSupport.wallSnapEntitiesIncludeOffscreen = false; |1052| |- } | |1052|+ |1053|1053| else |1054|1054| { |1055|1055| // cancel if not enough resources | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1316|1316| if (templateData.attack && |1317|1317| templateData.attack.Ranged && |1318|1318| templateData.attack.Ranged.maxRange) |1319| |- { | |1319|+ |1320|1320| // add attack information to display a good tooltip |1321|1321| placementSupport.attack = templateData.attack; |1322| |- } | |1322|+ |1323|1323| } |1324|1324| |1325|1325| // Batch training: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1404|1404| if (Engine.HotkeyIsPressed("session.batchtrain") && (canBeAddedCount == undefined || canBeAddedCount > 1)) |1405|1405| { |1406|1406| if (inputState == INPUT_BATCHTRAINING) |1407| |- { | |1407|+ |1408|1408| // Check if we are training in the same building(s) as the last batch |1409|1409| // NOTE: We just check if the arrays are the same and if the order is the same |1410|1410| // If the order changed, we have a new selection and we should create a new batch. |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439|1439| // fall through to create the new batch |1440| |- } | |1440|+ |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. |1443|1443| if (decrement || Engine.GuiInterfaceCall("GetNeededResources", { "cost": | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1436|1436| // Otherwise start a new one |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439| |- // fall through to create the new batch | |1439|+ // fall through to create the new batch |1440|1440| } |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. | | [NORMAL] ESLintBear (space-in-parens): | | There should be no spaces inside this paren. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1514|1514| g_BatchTrainingEntityAllowedCount < batchedSize * appropriateBuildings.length) |1515|1515| { |1516|1516| // Train as many full batches as we can |1517| |- let buildingsCountToTrainFullBatch = Math.floor( g_BatchTrainingEntityAllowedCount / batchedSize); | |1517|+ let buildingsCountToTrainFullBatch = Math.floor(g_BatchTrainingEntityAllowedCount / batchedSize); |1518|1518| Engine.PostNetworkCommand({ |1519|1519| "type": "train", |1520|1520| "entities": appropriateBuildings.slice(0, buildingsCountToTrainFullBatch), | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1593|1593| var selectall = Engine.HotkeyIsPressed("selection.offscreen"); |1594|1594| |1595|1595| // Reset the last idle unit, etc., if the selection type has changed. |1596| |- if (selectall || classes.length != lastIdleClasses.length || !classes.every((v,i) => v === lastIdleClasses[i])) | |1596|+ if (selectall || classes.length != lastIdleClasses.length || !classes.every((v, i) => v === lastIdleClasses[i])) |1597|1597| resetIdleUnit(); |1598|1598| lastIdleClasses = classes; |1599|1599| binaries/data/mods/public/gui/session/input.js | 228| » » var·entState·=·GetEntityState(ent); | | [NORMAL] ESLintBear (no-shadow): | | 'entState' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'target' to undefined. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'actionInfo' to undefined. binaries/data/mods/public/gui/session/input.js | 466| » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 493| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 497| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 552| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 562| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 610| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 639| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 708| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 825| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 828| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 928| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1017| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1031| » » » » let·action·=·determineAction(ev.x,·ev.y); | | [NORMAL] ESLintBear (no-shadow): | | 'action' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js |1040| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1109| » » » switch·(ev.hotkey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1544| » switch·(action) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'target' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'actionInfo' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 263| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 266| » » » var·r·=·g_UnitActions[action].hotkeyActionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 271| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 274| » » » var·r·=·g_UnitActions[action].actionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 481| » » &&·(ev.button·==·SDL_BUTTON_LEFT·||·ev.button·==·SDL_BUTTON_RIGHT)) | | [NORMAL] JSHintBear: | | Misleading line break before '&&'; readers may interpret this as an expression boundary. binaries/data/mods/public/gui/session/input.js | 511| » » » » var·rect·=·updateBandbox(bandbox,·ev,·true); | | [NORMAL] JSHintBear: | | 'rect' is already defined. binaries/data/mods/public/gui/session/input.js | 514| » » » » var·ents·=·getPreferredEntities(Engine.PickPlayerEntitiesInRect(rect[0],·rect[1],·rect[2],·rect[3],·g_ViewedPlayer)); | | [NORMAL] JSHintBear: | | 'ents' is already defined. binaries/data/mods/public/gui/session/input.js | 671| » » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 711| » » » let·maxDragDelta·=·16; | | [MAJOR] JSHintBear: | | 'maxDragDelta' has already been declared. binaries/data/mods/public/gui/session/input.js | 742| » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 872| » » » » » » var·sptr·=·ev.hotkey.split("."); | | [NORMAL] JSHintBear: | | 'sptr' is already defined. binaries/data/mods/public/gui/session/input.js | 888| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/gui/session/input.js | 914| » » » } | | [NORMAL] JSHintBear: | | Expected a 'break' statement before 'default'. binaries/data/mods/public/gui/session/input.js | 938| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | 873| 873| Engine.GetGUIObjectByName("barterHelp").hidden = !canBarter; | 874| 874| | 875| 875| if (canBarter) | 876| |- g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer) }); | | 876|+ g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer); }); | 877| 877| } | 878| 878| | 879| 879| function getIdleLandTradersText(traderNumber) binaries/data/mods/public/gui/session/menu.js | 482| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 557| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 876| » » g_ResourceData.GetCodes().forEach((resCode,·i)·=>·{·barterUpdateCommon(resCode,·i,·"barter",·g_ViewedPlayer)·}); | | [NORMAL] JSHintBear: | | Missing semicolon. Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1665/display/redirect
Comment Actions (Again, the patch looks very good to me)
Comment Actions Successful build - Chance fights ever on the side of the prudent. Linter detected issues: Executing section Source... Executing section JS... | | [NORMAL] ESLintBear (semi): | | Missing semicolon. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/menu.js | 873| 873| Engine.GetGUIObjectByName("barterHelp").hidden = !canBarter; | 874| 874| | 875| 875| if (canBarter) | 876| |- g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer) }); | | 876|+ g_ResourceData.GetCodes().forEach((resCode, i) => { barterUpdateCommon(resCode, i, "barter", g_ViewedPlayer); }); | 877| 877| } | 878| 878| | 879| 879| function getIdleLandTradersText(traderNumber) binaries/data/mods/public/gui/session/menu.js | 482| » » button.onPress·=·(function(player,·stance)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'stance' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'resCode' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 514| » » button.onPress·=·(function(i,·resCode,·button)·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 557| » button.onPress·=·(function(i)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 623| » button.onPress·=·(function(i,·button)·{·return·function()·{ | | [NORMAL] ESLintBear (no-shadow): | | 'button' is already declared in the upper scope. binaries/data/mods/public/gui/session/menu.js | 876| » » g_ResourceData.GetCodes().forEach((resCode,·i)·=>·{·barterUpdateCommon(resCode,·i,·"barter",·g_ViewedPlayer)·}); | | [NORMAL] JSHintBear: | | Missing semicolon. binaries/data/mods/public/gui/session/unit_actions.js | 557| » » » switch·(tradingDetails.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 181| 181| } | 182| 182| } | 183| 183| else if (placementSupport.mode === "wall") | 184| |- { | | 184|+ | 185| 185| if (placementSupport.wallSet && placementSupport.position) | 186| 186| { | 187| 187| // Fetch an updated list of snapping candidate entities | 199| 199| "snapEntities": placementSupport.wallSnapEntities, // snapping entities (towers) for starting a wall segment | 200| 200| }); | 201| 201| } | 202| |- } | | 202|+ | 203| 203| | 204| 204| return false; | 205| 205| } | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 288| 288| } | 289| 289| | 290| 290| if (!updateBuildingPlacementPreview()) | 291| |- { | | 291|+ | 292| 292| // invalid location - don't build it | 293| 293| // TODO: play a sound? | 294| 294| return false; | 295| |- } | | 295|+ | 296| 296| | 297| 297| var selection = g_Selection.toList(); | 298| 298| | | [NORMAL] ESLintBear (space-unary-ops): | | Unary word operator 'typeof' must be followed by whitespace. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 327| 327| } | 328| 328| | 329| 329| var wallPlacementInfo = updateBuildingPlacementPreview(); // entities making up the wall (wall segments, towers, ...) | 330| |- if (!(wallPlacementInfo === false || typeof(wallPlacementInfo) === "object")) | | 330|+ if (!(wallPlacementInfo === false || typeof (wallPlacementInfo) === "object")) | 331| 331| { | 332| 332| error("Invalid updateBuildingPlacementPreview return value: " + uneval(wallPlacementInfo)); | 333| 333| return false; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'for-of'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 354| 354| // (this is somewhat non-ideal and hardcode-ish) | 355| 355| var hasWallSegment = false; | 356| 356| for (let piece of cmd.pieces) | 357| |- { | | 357|+ | 358| 358| if (piece.template != cmd.wallSet.templates.tower) // TODO: hardcode-ish :( | 359| 359| { | 360| 360| hasWallSegment = true; | 361| 361| break; | 362| 362| } | 363| |- } | | 363|+ | 364| 364| | 365| 365| if (hasWallSegment) | 366| 366| { | | [NORMAL] ESLintBear (operator-linebreak): | | '&&' should be placed at the end of the line. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 477| 477| mouseIsOverObject = (hoveredObject != null); | 478| 478| | 479| 479| // Close the menu when interacting with the game world | 480| |- if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") | 481| |- && (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | | 480|+ if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") && | | 481|+ (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT)) | 482| 482| closeMenu(); | 483| 483| | 484| 484| // State-machine processing: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 518| 518| | 519| 519| // Update the list of selected units | 520| 520| if (Engine.HotkeyIsPressed("selection.add")) | 521| |- { | | 521|+ | 522| 522| g_Selection.addList(ents); | 523| |- } | | 523|+ | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| 525| { | 526| 526| g_Selection.removeList(ents); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 522| 522| g_Selection.addList(ents); | 523| 523| } | 524| 524| else if (Engine.HotkeyIsPressed("selection.remove")) | 525| |- { | | 525|+ | 526| 526| g_Selection.removeList(ents); | 527| |- } | | 527|+ | 528| 528| else | 529| 529| { | 530| 530| g_Selection.reset(); | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 578| 578| // If shift is down, let the player continue placing another of the same building | 579| 579| var queued = Engine.HotkeyIsPressed("session.queue"); | 580| 580| if (tryPlaceBuilding(queued)) | 581| |- { | | 581|+ | 582| 582| if (queued) | 583| 583| inputState = INPUT_BUILDING_PLACEMENT; | 584| 584| else | 585| 585| inputState = INPUT_NORMAL; | 586| |- } | | 586|+ | 587| 587| else | 588| 588| { | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 585| 585| inputState = INPUT_NORMAL; | 586| 586| } | 587| 587| else | 588| |- { | | 588|+ | 589| 589| inputState = INPUT_BUILDING_PLACEMENT; | 590| |- } | | 590|+ | 591| 591| return true; | 592| 592| } | 593| 593| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 638| 638| // user to continue building walls. | 639| 639| switch (ev.type) | 640| 640| { | 641| |- case "mousemotion": | | 641|+ case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 639| 639| switch (ev.type) | 640| 640| { | 641| 641| case "mousemotion": | 642| |- placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | | 642|+ placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 641| 641| case "mousemotion": | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| |- // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | | 644|+ // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 642| 642| placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| |- // the ending point and the starting point to snap to. | | 645|+ // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 643| 643| | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| |- // | | 646|+ // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 644| 644| // Update the building placement preview, and by extension, the list of snapping candidate entities for both (!) | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| |- // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | | 647|+ // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 645| 645| // the ending point and the starting point to snap to. | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| |- // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | | 648|+ // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 646| 646| // | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| |- // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | | 649|+ // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 647| 647| // TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| |- // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | | 650|+ // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 648| 648| // where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| |- // in them. Might be useful to query only for entities within a certain range around the starting point and ending | | 651|+ // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 649| 649| // foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on | 650| 650| // the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| |- // points. | | 652|+ // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 651| 651| // in them. Might be useful to query only for entities within a certain range around the starting point and ending | 652| 652| // points. | 653| 653| | 654| |- placementSupport.wallSnapEntitiesIncludeOffscreen = true; | | 654|+ placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 652| 652| // points. | 653| 653| | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| |- var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | | 655|+ var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 654| 654| placementSupport.wallSnapEntitiesIncludeOffscreen = true; | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| |- if (result && result.cost) | | 657|+ if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 655| 655| var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates | 656| 656| | 657| 657| if (result && result.cost) | 658| |- { | | 658|+ { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 656| 656| | 657| 657| if (result && result.cost) | 658| 658| { | 659| |- var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | | 659|+ var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 657| 657| if (result && result.cost) | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| |- placementSupport.tooltipMessage = [ | | 660|+ placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 658| 658| { | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| |- getEntityCostTooltip(result), | | 661|+ getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 659| 659| var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost }); | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| |- getNeededResourcesTooltip(neededResources) | | 662|+ getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 660| 660| placementSupport.tooltipMessage = [ | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| |- ].filter(tip => tip).join("\n"); | | 663|+ ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| 666| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 661| 661| getEntityCostTooltip(result), | 662| 662| getNeededResourcesTooltip(neededResources) | 663| 663| ].filter(tip => tip).join("\n"); | 664| |- } | | 664|+ } | 665| 665| | 666| 666| break; | 667| 667| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 663| 663| ].filter(tip => tip).join("\n"); | 664| 664| } | 665| 665| | 666| |- break; | | 666|+ break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 665| 665| | 666| 666| break; | 667| 667| | 668| |- case "mousebuttondown": | | 668|+ case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 666| 666| break; | 667| 667| | 668| 668| case "mousebuttondown": | 669| |- if (ev.button == SDL_BUTTON_LEFT) | | 669|+ if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 667| 667| | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| |- { | | 670|+ { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 668| 668| case "mousebuttondown": | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| |- var queued = Engine.HotkeyIsPressed("session.queue"); | | 671|+ var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 669| 669| if (ev.button == SDL_BUTTON_LEFT) | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| |- if (tryPlaceWall(queued)) | | 672|+ if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| 675| { | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 670| 670| { | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| |- { | | 673|+ { | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 671| 671| var queued = Engine.HotkeyIsPressed("session.queue"); | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| |- if (queued) | | 674|+ if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 672| 672| if (tryPlaceWall(queued)) | 673| 673| { | 674| 674| if (queued) | 675| |- { | | 675|+ { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 673| 673| { | 674| 674| if (queued) | 675| 675| { | 676| |- // continue building, just set a new starting position where we left off | | 676|+ // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 674| 674| if (queued) | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| |- placementSupport.position = placementSupport.wallEndPosition; | | 677|+ placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 675| 675| { | 676| 676| // continue building, just set a new starting position where we left off | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| |- placementSupport.wallEndPosition = undefined; | | 678|+ placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 677| 677| placementSupport.position = placementSupport.wallEndPosition; | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| |- inputState = INPUT_BUILDING_WALL_CLICK; | | 680|+ inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| 683| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 678| 678| placementSupport.wallEndPosition = undefined; | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| |- } | | 681|+ } | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 679| 679| | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| |- else | | 682|+ else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 680| 680| inputState = INPUT_BUILDING_WALL_CLICK; | 681| 681| } | 682| 682| else | 683| |- { | | 683|+ { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 681| 681| } | 682| 682| else | 683| 683| { | 684| |- placementSupport.Reset(); | | 684|+ placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 682| 682| else | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| |- inputState = INPUT_NORMAL; | | 685|+ inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| 688| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 683| 683| { | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| |- } | | 686|+ } | 687| 687| } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 684| 684| placementSupport.Reset(); | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| |- } | | 687|+ } | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 685| 685| inputState = INPUT_NORMAL; | 686| 686| } | 687| 687| } | 688| |- else | | 688|+ else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 686| 686| } | 687| 687| } | 688| 688| else | 689| |- placementSupport.tooltipMessage = translate("Cannot build wall here!"); | | 689|+ placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 688| 688| else | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| |- updateBuildingPlacementPreview(); | | 691|+ updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 689| 689| placementSupport.tooltipMessage = translate("Cannot build wall here!"); | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| |- return true; | | 692|+ return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 690| 690| | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| |- } | | 693|+ } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 691| 691| updateBuildingPlacementPreview(); | 692| 692| return true; | 693| 693| } | 694| |- else if (ev.button == SDL_BUTTON_RIGHT) | | 694|+ else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 692| 692| return true; | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| |- { | | 695|+ { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 693| 693| } | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| |- // reset to normal input mode | | 696|+ // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 694| 694| else if (ev.button == SDL_BUTTON_RIGHT) | 695| 695| { | 696| 696| // reset to normal input mode | 697| |- placementSupport.Reset(); | | 697|+ placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 695| 695| { | 696| 696| // reset to normal input mode | 697| 697| placementSupport.Reset(); | 698| |- updateBuildingPlacementPreview(); | | 698|+ updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 697| 697| placementSupport.Reset(); | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| |- inputState = INPUT_NORMAL; | | 700|+ inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| 703| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 698| 698| updateBuildingPlacementPreview(); | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| |- return true; | | 701|+ return true; | 702| 702| } | 703| 703| break; | 704| 704| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 699| 699| | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| |- } | | 702|+ } | 703| 703| break; | 704| 704| } | 705| 705| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 700| 700| inputState = INPUT_NORMAL; | 701| 701| return true; | 702| 702| } | 703| |- break; | | 703|+ break; | 704| 704| } | 705| 705| break; | 706| 706| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 710| 710| case "mousemotion": | 711| 711| let maxDragDelta = 16; | 712| 712| if (g_DragStart.distanceTo(ev) >= maxDragDelta) | 713| |- { | | 713|+ | 714| 714| // Rotate in the direction of the mouse | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| |- } | | 716|+ | 717| 717| else | 718| 718| { | 719| 719| // If the mouse is near the center, snap back to the default orientation | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 715| 715| placementSupport.angle = placementSupport.position.horizAngleTo(Engine.GetTerrainAtScreenPoint(ev.x, ev.y)); | 716| 716| } | 717| 717| else | 718| |- { | | 718|+ | 719| 719| // If the mouse is near the center, snap back to the default orientation | 720| 720| placementSupport.SetDefaultAngle(); | 721| |- } | | 721|+ | 722| 722| | 723| 723| var snapData = Engine.GuiInterfaceCall("GetFoundationSnapData", { | 724| 724| "template": placementSupport.template, | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 741| 741| // If shift is down, let the player continue placing another of the same building | 742| 742| var queued = Engine.HotkeyIsPressed("session.queue"); | 743| 743| if (tryPlaceBuilding(queued)) | 744| |- { | | 744|+ | 745| 745| if (queued) | 746| 746| inputState = INPUT_BUILDING_PLACEMENT; | 747| 747| else | 748| 748| inputState = INPUT_NORMAL; | 749| |- } | | 749|+ | 750| 750| else | 751| 751| { | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'else'. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 748| 748| inputState = INPUT_NORMAL; | 749| 749| } | 750| 750| else | 751| |- { | | 751|+ | 752| 752| inputState = INPUT_BUILDING_PLACEMENT; | 753| |- } | | 753|+ | 754| 754| return true; | 755| 755| } | 756| 756| break; | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 797| 797| | 798| 798| // Handle the time-warp testing features, restricted to single-player | 799| 799| if (!g_IsNetworked && g_DeveloperOverlay.isTimeWarpEnabled()) | 800| |- { | | 800|+ | 801| 801| if (ev.type == "hotkeydown" && ev.hotkey == "session.timewarp.fastforward") | 802| 802| Engine.SetSimRate(20.0); | 803| 803| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.fastforward") | 804| 804| Engine.SetSimRate(1.0); | 805| 805| else if (ev.type == "hotkeyup" && ev.hotkey == "session.timewarp.rewind") | 806| 806| Engine.RewindTimeWarp(); | 807| |- } | | 807|+ | 808| 808| | 809| 809| if (ev.hotkey == "session.highlightguarding") | 810| 810| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 856| 856| break; | 857| 857| | 858| 858| case "hotkeydown": | 859| |- if (ev.hotkey.indexOf("selection.group.") == 0) | | 859|+ if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 857| 857| | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| |- { | | 860|+ { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 858| 858| case "hotkeydown": | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| |- let now = Date.now(); | | 861|+ let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 859| 859| if (ev.hotkey.indexOf("selection.group.") == 0) | 860| 860| { | 861| 861| let now = Date.now(); | 862| |- if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | | 862|+ if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 860| 860| { | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| |- { | | 863|+ { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 861| 861| let now = Date.now(); | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| |- if (ev.hotkey.indexOf("selection.group.select.") == 0) | | 864|+ if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 862| 862| if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey) | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| |- { | | 865|+ { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 863| 863| { | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| |- var sptr = ev.hotkey.split("."); | | 866|+ var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 7. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 864| 864| if (ev.hotkey.indexOf("selection.group.select.") == 0) | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| |- performGroup("snap", sptr[3]); | | 867|+ performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| 870| else | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 865| 865| { | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| |- } | | 868|+ } | 869| 869| } | 870| 870| else | 871| 871| { | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 866| 866| var sptr = ev.hotkey.split("."); | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| |- } | | 869|+ } | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 867| 867| performGroup("snap", sptr[3]); | 868| 868| } | 869| 869| } | 870| |- else | | 870|+ else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 868| 868| } | 869| 869| } | 870| 870| else | 871| |- { | | 871|+ { | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 869| 869| } | 870| 870| else | 871| 871| { | 872| |- var sptr = ev.hotkey.split("."); | | 872|+ var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 870| 870| else | 871| 871| { | 872| 872| var sptr = ev.hotkey.split("."); | 873| |- performGroup(sptr[2], sptr[3]); | | 873|+ performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 872| 872| var sptr = ev.hotkey.split("."); | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| |- doublePressTimer = now; | | 875|+ doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 5 tabs but found 6. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 873| 873| performGroup(sptr[2], sptr[3]); | 874| 874| | 875| 875| doublePressTimer = now; | 876| |- prevHotkey = ev.hotkey; | | 876|+ prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| 879| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 874| 874| | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| |- } | | 877|+ } | 878| 878| } | 879| 879| break; | 880| 880| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 875| 875| doublePressTimer = now; | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| |- } | | 878|+ } | 879| 879| break; | 880| 880| } | 881| 881| break; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | 876| 876| prevHotkey = ev.hotkey; | 877| 877| } | 878| 878| } | 879| |- break; | | 879|+ break; | 880| 880| } | 881| 881| break; | 882| 882| | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1044|1044| placementSupport.position = Engine.GetTerrainAtScreenPoint(ev.x, ev.y); |1045|1045| |1046|1046| if (placementSupport.mode === "wall") |1047| |- { | |1047|+ |1048|1048| // Including only the on-screen towers in the next snap candidate list is sufficient here, since the user is |1049|1049| // still selecting a starting point (which must necessarily be on-screen). (The update of the snap entities |1050|1050| // itself happens in the call to updateBuildingPlacementPreview below). |1051|1051| placementSupport.wallSnapEntitiesIncludeOffscreen = false; |1052| |- } | |1052|+ |1053|1053| else |1054|1054| { |1055|1055| // cancel if not enough resources | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1316|1316| if (templateData.attack && |1317|1317| templateData.attack.Ranged && |1318|1318| templateData.attack.Ranged.maxRange) |1319| |- { | |1319|+ |1320|1320| // add attack information to display a good tooltip |1321|1321| placementSupport.attack = templateData.attack; |1322| |- } | |1322|+ |1323|1323| } |1324|1324| |1325|1325| // Batch training: | | [NORMAL] ESLintBear (curly): | | Unnecessary { after 'if' condition. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1404|1404| if (Engine.HotkeyIsPressed("session.batchtrain") && (canBeAddedCount == undefined || canBeAddedCount > 1)) |1405|1405| { |1406|1406| if (inputState == INPUT_BATCHTRAINING) |1407| |- { | |1407|+ |1408|1408| // Check if we are training in the same building(s) as the last batch |1409|1409| // NOTE: We just check if the arrays are the same and if the order is the same |1410|1410| // If the order changed, we have a new selection and we should create a new batch. |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439|1439| // fall through to create the new batch |1440| |- } | |1440|+ |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. |1443|1443| if (decrement || Engine.GuiInterfaceCall("GetNeededResources", { "cost": | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 4. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1436|1436| // Otherwise start a new one |1437|1437| else if (!decrement) |1438|1438| flushTrainingBatch(); |1439| |- // fall through to create the new batch | |1439|+ // fall through to create the new batch |1440|1440| } |1441|1441| |1442|1442| // Don't start a new batch if decrementing or unable to afford it. | | [NORMAL] ESLintBear (space-in-parens): | | There should be no spaces inside this paren. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1514|1514| g_BatchTrainingEntityAllowedCount < batchedSize * appropriateBuildings.length) |1515|1515| { |1516|1516| // Train as many full batches as we can |1517| |- let buildingsCountToTrainFullBatch = Math.floor( g_BatchTrainingEntityAllowedCount / batchedSize); | |1517|+ let buildingsCountToTrainFullBatch = Math.floor(g_BatchTrainingEntityAllowedCount / batchedSize); |1518|1518| Engine.PostNetworkCommand({ |1519|1519| "type": "train", |1520|1520| "entities": appropriateBuildings.slice(0, buildingsCountToTrainFullBatch), | | [NORMAL] ESLintBear (comma-spacing): | | A space is required after ','. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/input.js |1593|1593| var selectall = Engine.HotkeyIsPressed("selection.offscreen"); |1594|1594| |1595|1595| // Reset the last idle unit, etc., if the selection type has changed. |1596| |- if (selectall || classes.length != lastIdleClasses.length || !classes.every((v,i) => v === lastIdleClasses[i])) | |1596|+ if (selectall || classes.length != lastIdleClasses.length || !classes.every((v, i) => v === lastIdleClasses[i])) |1597|1597| resetIdleUnit(); |1598|1598| lastIdleClasses = classes; |1599|1599| binaries/data/mods/public/gui/session/input.js | 228| » » var·entState·=·GetEntityState(ent); | | [NORMAL] ESLintBear (no-shadow): | | 'entState' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'target' to undefined. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] ESLintBear (no-undef-init): | | It's not necessary to initialize 'actionInfo' to undefined. binaries/data/mods/public/gui/session/input.js | 466| » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 493| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 497| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 552| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 562| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 610| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 639| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 708| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 825| » switch·(inputState) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 828| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 928| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1017| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1031| » » » » let·action·=·determineAction(ev.x,·ev.y); | | [NORMAL] ESLintBear (no-shadow): | | 'action' is already declared in the upper scope. binaries/data/mods/public/gui/session/input.js |1040| » » switch·(ev.type) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1109| » » » switch·(ev.hotkey) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js |1544| » switch·(action) | | [NORMAL] ESLintBear (default-case): | | Expected a default case. binaries/data/mods/public/gui/session/input.js | 235| » var·target·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'target' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 249| » var·actionInfo·=·undefined; | | [NORMAL] JSHintBear: | | It's not necessary to initialize 'actionInfo' to 'undefined'. binaries/data/mods/public/gui/session/input.js | 263| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 266| » » » var·r·=·g_UnitActions[action].hotkeyActionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 271| » for·(var·action·of·actions) | | [NORMAL] JSHintBear: | | 'action' is already defined. binaries/data/mods/public/gui/session/input.js | 274| » » » var·r·=·g_UnitActions[action].actionCheck(target,·selection); | | [NORMAL] JSHintBear: | | 'r' is already defined. binaries/data/mods/public/gui/session/input.js | 481| » » &&·(ev.button·==·SDL_BUTTON_LEFT·||·ev.button·==·SDL_BUTTON_RIGHT)) | | [NORMAL] JSHintBear: | | Misleading line break before '&&'; readers may interpret this as an expression boundary. binaries/data/mods/public/gui/session/input.js | 511| » » » » var·rect·=·updateBandbox(bandbox,·ev,·true); | | [NORMAL] JSHintBear: | | 'rect' is already defined. binaries/data/mods/public/gui/session/input.js | 514| » » » » var·ents·=·getPreferredEntities(Engine.PickPlayerEntitiesInRect(rect[0],·rect[1],·rect[2],·rect[3],·g_ViewedPlayer)); | | [NORMAL] JSHintBear: | | 'ents' is already defined. binaries/data/mods/public/gui/session/input.js | 671| » » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 711| » » » let·maxDragDelta·=·16; | | [MAJOR] JSHintBear: | | 'maxDragDelta' has already been declared. binaries/data/mods/public/gui/session/input.js | 742| » » » » var·queued·=·Engine.HotkeyIsPressed("session.queue"); | | [NORMAL] JSHintBear: | | 'queued' is already defined. binaries/data/mods/public/gui/session/input.js | 872| » » » » » » var·sptr·=·ev.hotkey.split("."); | | [NORMAL] JSHintBear: | | 'sptr' is already defined. binaries/data/mods/public/gui/session/input.js | 888| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. binaries/data/mods/public/gui/session/input.js | 914| » » » } | | [NORMAL] JSHintBear: | | Expected a 'break' statement before 'default'. binaries/data/mods/public/gui/session/input.js | 938| » » » var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y); | | [NORMAL] JSHintBear: | | 'ent' is already defined. | | [NORMAL] ESLintBear (indent): | | Expected indentation of 6 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 392| 392| // Players see colors depending on diplomacy | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| |- g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | | 395|+ g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 7 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 393| 393| g_DisplayedPlayerColors[i] = | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| |- g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | | 396|+ g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| 397| getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | | [NORMAL] ESLintBear (indent): | | Expected indentation of 8 tabs but found 5. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 394| 394| g_ViewedPlayer == i ? getDiplomacyColor("self") : | 395| 395| g_Players[g_ViewedPlayer].isAlly[i] ? getDiplomacyColor("ally") : | 396| 396| g_Players[g_ViewedPlayer].isNeutral[i] ? getDiplomacyColor("neutral") : | 397| |- getDiplomacyColor("enemy"); | | 397|+ getDiplomacyColor("enemy"); | 398| 398| | 399| 399| g_DisplayedPlayerColors[0] = g_Players[0].color; | 400| 400| } | | [NORMAL] ESLintBear (indent): | | Expected indentation of 4 tabs but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | 644| 644| "civ": setStringTags(g_CivData[g_Players[g_ViewedPlayer].civ].Name, { "font": "sans-bold-stroke-14" }), | 645| 645| "hotkey_civinfo": colorizeHotkey("%(hotkey)s", "civinfo"), | 646| 646| "hotkey_structree": colorizeHotkey("%(hotkey)s", "structree") | 647| |- }); | | 647|+ }); | 648| 648| } | 649| 649| | 650| 650| // Following gaia can be interesting on scripted maps | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1194|1194| |1195|1195| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197| |- "hotkey": setStringTags("\\[Click]", g_HotkeyTags), | |1197|+ "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198|1198| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199|1199| }); |1200|1200| | | [NORMAL] ESLintBear (indent): | | Expected indentation of 3 tabs but found 2. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1195|1195| let orderHotkeyTooltip = Object.keys(viewablePlayerStates).length <= 1 ? "" : |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197|1197| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198| |- "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") | |1198|+ "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199|1199| }); |1200|1200| |1201|1201| let resCodes = g_ResourceData.GetCodes(); | | [NORMAL] ESLintBear (indent): | | Expected indentation of 2 tabs but found 1. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1196|1196| "\n" + sprintf(translate("%(order)s: %(hotkey)s to change order."), { |1197|1197| "hotkey": setStringTags("\\[Click]", g_HotkeyTags), |1198|1198| "order": tooltipSort == 0 ? translate("Unordered") : tooltipSort == 1 ? translate("Descending") : translate("Ascending") |1199| |- }); | |1199|+ }); |1200|1200| |1201|1201| let resCodes = g_ResourceData.GetCodes(); |1202|1202| for (let r = 0; r < resCodes.length; ++r) | | [NORMAL] ESLintBear (indent): | | Expected indentation of 1 tab but found 3. |----| | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js | |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/gui/session/session.js |1679|1679| for (let rct of resourcesCounterTypes) |1680|1680| for (let rt of resourcesTypes) |1681|1681| reportObject[rt + rct.substr(9)] = playerStatistics[rct][rt]; |1682| |- // eg. rt = food rct.substr = Gathered rct = resourcesGathered | |1682|+ // eg. rt = food rct.substr = Gathered rct = resourcesGathered |1683|1683| |1684|1684| reportObject.vegetarianFoodGathered = playerStatistics.resourcesGathered.vegetarianFood; |1685|1685| for (let type of unitsClasses) binaries/data/mods/public/gui/session/session.js |1055| » let·getPanelEntNameTooltip·=·panelEntState·=>·"[font=\"sans-bold-16\"]"·+·template.name.specific·+·"[/font]"; | | [NORMAL] ESLintBear (no-shadow): | | 'panelEntState' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1130| » » button.onpress·=·(function(i)·{·return·function()·{·performGroup((Engine.HotkeyIsPressed("selection.add")·?·"add"·:·"select"),·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1131| » » button.ondoublepress·=·(function(i)·{·return·function()·{·performGroup("snap",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. binaries/data/mods/public/gui/session/session.js |1132| » » button.onpressright·=·(function(i)·{·return·function()·{·performGroup("breakUp",·i);·};·})(i); | | [NORMAL] ESLintBear (no-shadow): | | 'i' is already declared in the upper scope. Executing section cli... Link to build: https://jenkins.wildfiregames.com/job/differential/1695/display/redirect
Comment Actions prototype.isControlAll() = function() { let state = GetSimState().players[g_ViewedPlayer]; return state && state.controlsAll; } This way the variable and the setter hunk would be avoided, at the cost of having the g_ViewedPlayer reference here and GetSimState(), as opposed to having it in the other file. Perhaps we can have the SimState prototype later to store that.
|