Page MenuHomeWildfire Games

Update to premake Alpha 14
AbandonedPublic

Authored by wraitii on May 28 2019, 4:28 PM.

Details

Reviewers
None
Group Reviewers
Windows Developers
Restricted Owners Package(Owns No Changed Paths)
Summary

This updates premake to alpha 14 from alpha 13, following rP22021.

@Itms You did the last upgrade, I don't think I've forgotten anything but in case.

Test Plan

Test on *nix and windows

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
_remkealpha14
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 7653
Build 12480: Vulcan BuildJenkins
Build 12479: arc lint + arc unit

Event Timeline

wraitii created this revision.May 28 2019, 4:28 PM
Owners added a subscriber: Restricted Owners Package.May 28 2019, 4:28 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1532/display/redirect

Stan added a subscriber: Stan.EditedMay 28 2019, 4:55 PM

Any changelog ? I see they haven't updated their txt file.

Stan added a comment.May 28 2019, 5:12 PM

build/premake/premake5/src/scripts.c should not be marked as binary.

In D1932#79775, @Stan wrote:

Any changelog ? I see they haven't updated their txt file.

Hm, they have actually :p . Nothing too useful since A13 I think.

Stan added a comment.Jun 25 2019, 4:18 PM

It would seem they added support for Microsoft Visual Studio 2019.
As of today, still haven't updated the CHANGES.txt file.

Itms added a comment.Jul 17 2019, 11:28 AM

This will be useful to start supporting VS2019. I would be against updating premake if we have no bugs or missing features in our version though, because that makes heavy commits. What is your opinion? If you agree, we should wait for when we actually enable 2019, at that time maybe that will be a more recent alpha version of premake.

In D1932#87055, @Itms wrote:

This will be useful to start supporting VS2019. I would be against updating premake if we have no bugs or missing features in our version though, because that makes heavy commits. What is your opinion? If you agree, we should wait for when we actually enable 2019, at that time maybe that will be a more recent alpha version of premake.

That would make sense, and it does seem like Alpha 14 isn't super useful for us right now. I can abandon this then.

wraitii abandoned this revision.Jul 20 2019, 2:50 PM