Page MenuHomeWildfire Games

Further cleanup for MikkTspace.
ClosedPublic

Authored by Stan on Wed, May 29, 12:32 AM.

Details

Summary
Test Plan

/

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Stan created this revision.Wed, May 29, 12:32 AM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1537/display/redirect

Stan added a comment.Wed, May 29, 9:19 AM

Errors when having

 // #include "graphics/ModelDef.h"
#include "third_party/mikktspace/mikktspace.h"

#include <vector>

class CModelDef
class CVector3D;
struct SModelFace;
struct SModelVertex;
Severity	Code	Description	Project	File	Line	Suppression State
Error	C2530	'f': references must be initialized	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	140	
Error	C2530	'face': references must be initialized	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	83	
Error	C2530	'face': references must be initialized	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	97	
Error	C2039	'GetFaces': is not a member of 'std::shared_ptr<CModelDef>'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	83	
Error	C2039	'GetFaces': is not a member of 'std::shared_ptr<CModelDef>'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	97	
Error	C2039	'GetFaces': is not a member of 'std::shared_ptr<CModelDef>'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	140	
Error	C2039	'GetNumFaces': is not a member of 'std::shared_ptr<CModelDef>'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	49	
Error	C2039	'GetNumUVsPerVertex': is not a member of 'std::shared_ptr<CModelDef>'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	124	
Error	C2039	'GetVertices': is not a member of 'std::shared_ptr<CModelDef>'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	84	
Error	C2039	'GetVertices': is not a member of 'std::shared_ptr<CModelDef>'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	98	
Error	C2039	'GetVertices': is not a member of 'std::shared_ptr<CModelDef>'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	141	
Error	C2530	'n': references must be initialized	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	105	
Error	C2530	'normal': references must be initialized	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	71	
Error	C2530	'p': references must be initialized	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	100	
Error	C2530	'position': references must be initialized	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	60	
Error	C2530	'v': references must be initialized	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	84	
Error	C2530	'vertex': references must be initialized	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	98	
Error (active)	E0020	identifier "CModelDef" is undefined	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	22	
Error (active)	E0020	identifier "CModelDef" is undefined	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.h	33	
Error (active)	E0020	identifier "CModelDef" is undefined	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.h	42	
Error (active)	E0020	identifier "SModelVertex" is undefined	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	137	
Error (active)	E0020	identifier "SModelVertex" is undefined	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.h	73	
Error	C2228	left of '.m_Blend' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	119	
Error	C2228	left of '.m_Blend' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	120	
Error	C2228	left of '.m_Bone' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	119	
Error	C2228	left of '.m_Coords' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	60	
Error	C2228	left of '.m_Coords' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	100	
Error	C2228	left of '.m_Norm' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	71	
Error	C2228	left of '.m_Norm' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	105	
Error	C2228	left of '.m_UVs' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	87	
Error	C2228	left of '.m_UVs' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	88	
Error	C2228	left of '.m_UVs' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	127	
Error	C2228	left of '.m_UVs' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	128	
Error	C2228	left of '.m_Verts' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	84	
Error	C2228	left of '.m_Verts' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	98	
Error	C2228	left of '.m_Verts' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	141	
Error	C2228	left of '.m_Weight' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	120	
Error	C2228	left of '.X' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	62	
Error	C2228	left of '.X' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	73	
Error	C2228	left of '.X' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	101	
Error	C2228	left of '.X' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	106	
Error	C2228	left of '.Y' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	63	
Error	C2228	left of '.Y' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	74	
Error	C2228	left of '.Y' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	102	
Error	C2228	left of '.Y' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	107	
Error	C2228	left of '.Z' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	64	
Error	C2228	left of '.Z' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	75	
Error	C2228	left of '.Z' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	103	
Error	C2228	left of '.Z' must have class/struct/union	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	108	
Error	C2027	use of undefined type 'CModelDef'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	49	
Error	C2027	use of undefined type 'CModelDef'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	83	
Error	C2027	use of undefined type 'CModelDef'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	84	
Error	C2027	use of undefined type 'CModelDef'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	97	
Error	C2027	use of undefined type 'CModelDef'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	98	
Error	C2027	use of undefined type 'CModelDef'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	124	
Error	C2027	use of undefined type 'CModelDef'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	140	
Error	C2027	use of undefined type 'CModelDef'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	141	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	62	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	63	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	64	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	73	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	74	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	75	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	101	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	102	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	103	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	106	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	107	
Error	C2027	use of undefined type 'CVector3D'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	108	
Error	C2027	use of undefined type 'SModelFace'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	84	
Error	C2027	use of undefined type 'SModelFace'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	98	
Error	C2027	use of undefined type 'SModelFace'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	141	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	60	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	71	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	87	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	88	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	100	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	105	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	119	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	120	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	127	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	128	
Error	C2027	use of undefined type 'SModelVertex'	graphics	D:\Dev\0ad-svn\ps\trunk\source\renderer\MikktspaceWrap.cpp	138
Stan updated this revision to Diff 8199.Wed, May 29, 9:21 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1538/display/redirect

source/renderer/MikktspaceWrap.h
42 ↗(On Diff #8199)

Why?

Stan added inline comments.Wed, May 29, 12:16 PM
source/renderer/MikktspaceWrap.h
42 ↗(On Diff #8199)

Can't forward declare

From MeshManager.h

class CModelDef;
typedef std::shared_ptr<CModelDef> CModelDefPtr;
source/renderer/MikktspaceWrap.h
42 ↗(On Diff #8199)

I mean why not:

#include "graphics/MeshManager.h"
#include "third_party/mikktspace/mikktspace.h"

#include <vector>

class CVector3D;

class MikkTSpace
{
public:
    MikkTSpace(const CModelDefPtr& m, std::vector<float>& v, bool gpuSkinning);
    // ...
};
Stan added inline comments.Wed, May 29, 1:01 PM
source/renderer/MikktspaceWrap.h
42 ↗(On Diff #8199)

Ah could work I guess I don't remember.

Stan updated this revision to Diff 8203.Wed, May 29, 2:52 PM

Fix includes

Stan marked 2 inline comments as done.Wed, May 29, 2:52 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1540/display/redirect

vladislavbelov added inline comments.Wed, May 29, 3:17 PM
source/renderer/MikktspaceWrap.h
22 ↗(On Diff #8203)

I think this include isn't needed as it's forward declared in the MeshManager.h.

Stan added inline comments.Wed, May 29, 3:20 PM
source/renderer/MikktspaceWrap.h
22 ↗(On Diff #8203)

Interesting theory, but doesn't work

Severity	Code	Description	Project	File	Line	Suppression State
Error	C2065	'face': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	83	
Error	C2065	'face': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	84	
Error	C2065	'face': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	97	
Error	C2065	'face': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	98	
Error	C2039	'GetFaces': is not a member of 'std::shared_ptr<CModelDef>'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	83	
Error	C2039	'GetFaces': is not a member of 'std::shared_ptr<CModelDef>'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	97	
Error	C2039	'GetNumFaces': is not a member of 'std::shared_ptr<CModelDef>'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	49	
Error	C2039	'GetNumUVsPerVertex': is not a member of 'std::shared_ptr<CModelDef>'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	124	
Error	C3861	'GetVertex': identifier not found	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	60	
Error	C3861	'GetVertex': identifier not found	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	71	
Error	C2039	'GetVertex': is not a member of 'MikkTSpace'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	137	
Error	C3646	'GetVertex': unknown override specifier (compiling source file ..\..\..\source\renderer\MikktspaceWrap.cpp)	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.h	73	
Error	C2039	'GetVertices': is not a member of 'std::shared_ptr<CModelDef>'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	84	
Error	C2039	'GetVertices': is not a member of 'std::shared_ptr<CModelDef>'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	98	
Error	C2530	'n': references must be initialized	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	105	
Error	C2530	'normal': references must be initialized	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	71	
Error	C2530	'p': references must be initialized	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	100	
Error	C2530	'position': references must be initialized	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	60	
Error	C2065	'v': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	84	
Error	C2065	'v': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	87	
Error	C2065	'v': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	88	
Error	C2065	'vertex': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	98	
Error	C2065	'vertex': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	100	
Error	C2065	'vertex': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	105	
Error	C2065	'vertex': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	119	
Error	C2065	'vertex': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	120	
Error	C2065	'vertex': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	127	
Error	C2065	'vertex': undeclared identifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	128	
Error	C2447	'{': missing function header (old-style formal list?)	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	138	
Error (active)	E0020	identifier "SModelFace" is undefined	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	83	
Error (active)	E0020	identifier "SModelFace" is undefined	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	97	
Error (active)	E0020	identifier "SModelFace" is undefined	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	140	
Error (active)	E0020	identifier "SModelVertex" is undefined	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	84	
Error (active)	E0020	identifier "SModelVertex" is undefined	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	98	
Error (active)	E0020	identifier "SModelVertex" is undefined	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	137	
Error (active)	E0020	identifier "SModelVertex" is undefined	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.h	73	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	62	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	63	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	64	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	73	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	74	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	75	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	101	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	102	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	103	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	106	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	107	
Error (active)	E0070	incomplete type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	108	
Error	C2228	left of '.m_Blend' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	119	
Error	C2228	left of '.m_Blend' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	120	
Error	C2228	left of '.m_Bone' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	119	
Error	C2228	left of '.m_Coords' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	60	
Error	C2228	left of '.m_Coords' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	100	
Error	C2228	left of '.m_Norm' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	71	
Error	C2228	left of '.m_Norm' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	105	
Error	C2228	left of '.m_UVs' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	87	
Error	C2228	left of '.m_UVs' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	88	
Error	C2228	left of '.m_UVs' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	127	
Error	C2228	left of '.m_UVs' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	128	
Error	C2228	left of '.m_Verts' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	84	
Error	C2228	left of '.m_Verts' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	98	
Error	C2228	left of '.m_Weight' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	120	
Error	C2228	left of '.X' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	62	
Error	C2228	left of '.X' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	73	
Error	C2228	left of '.X' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	101	
Error	C2228	left of '.X' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	106	
Error	C2228	left of '.Y' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	63	
Error	C2228	left of '.Y' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	74	
Error	C2228	left of '.Y' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	102	
Error	C2228	left of '.Y' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	107	
Error	C2228	left of '.Z' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	64	
Error	C2228	left of '.Z' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	75	
Error	C2228	left of '.Z' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	103	
Error	C2228	left of '.Z' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	108	
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	83	
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	84	
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	97	
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	98	
Error	C4430	missing type specifier - int assumed. Note: C++ does not support default-int	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	137	
Error (active)	E0393	pointer to incomplete class type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	49	
Error (active)	E0393	pointer to incomplete class type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	83	
Error (active)	E0393	pointer to incomplete class type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	84	
Error (active)	E0393	pointer to incomplete class type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	97	
Error (active)	E0393	pointer to incomplete class type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	98	
Error (active)	E0393	pointer to incomplete class type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	124	
Error (active)	E0393	pointer to incomplete class type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	140	
Error (active)	E0393	pointer to incomplete class type is not allowed	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	141	
Error	C2059	syntax error: 'const' (compiling source file ..\..\..\source\renderer\MikktspaceWrap.cpp)	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.h	73	
Error	C2143	syntax error: missing ';' before '&'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	83	
Error	C2143	syntax error: missing ';' before '&'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	84	
Error	C2143	syntax error: missing ';' before '&'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	97	
Error	C2143	syntax error: missing ';' before '&'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	98	
Error	C2143	syntax error: missing ';' before '{'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	138	
Error	C2146	syntax error: missing ';' before identifier 'GetVertex'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	137	
Error	C2238	unexpected token(s) preceding ';' (compiling source file ..\..\..\source\renderer\MikktspaceWrap.cpp)	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.h	73	
Error	C2027	use of undefined type 'CModelDef'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	49	
Error	C2027	use of undefined type 'CModelDef'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	83	
Error	C2027	use of undefined type 'CModelDef'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	84	
Error	C2027	use of undefined type 'CModelDef'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	97	
Error	C2027	use of undefined type 'CModelDef'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	98	
Error	C2027	use of undefined type 'CModelDef'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	124	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	62	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	63	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	64	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	73	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	74	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	75	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	101	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	102	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	103	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	106	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	107	
Error	C2027	use of undefined type 'CVector3D'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	108
vladislavbelov added inline comments.Wed, May 29, 3:30 PM
source/renderer/MikktspaceWrap.h
22 ↗(On Diff #8203)

I meant it isn't needed here but needed in the implementation (.cpp).

Stan added inline comments.Wed, May 29, 3:41 PM
source/renderer/MikktspaceWrap.h
22 ↗(On Diff #8203)

In cpp

this doesn't work

#include "renderer/MikktspaceWrap.h"
#include "graphics/ModelDef.h"

but this does, so I guess it can stay in the .h

#include "graphics/ModelDef.h"
#include "renderer/MikktspaceWrap.h"
vladislavbelov added inline comments.Wed, May 29, 4:18 PM
source/renderer/MikktspaceWrap.h
22 ↗(On Diff #8203)

What is an error?

Stan added inline comments.Wed, May 29, 4:19 PM
source/renderer/MikktspaceWrap.h
22 ↗(On Diff #8203)
Severity	Code	Description	Project	File	Line	Suppression State
Error	C3861	'GetUserDataFromContext': identifier not found	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	141	
Error	C3861	'GetVertex': identifier not found	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	62	
Error	C3861	'GetVertex': identifier not found	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	73	
Error	C2039	'GetVertex': is not a member of 'MikkTSpace'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	139	
Error	C3646	'GetVertex': unknown override specifier	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.h	73	
Error	C2248	'MikkTSpace::m_Model': cannot access private member declared in class 'MikkTSpace'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	142	
Error	C2248	'MikkTSpace::m_Model': cannot access private member declared in class 'MikkTSpace'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	143	
Error	C2530	'normal': references must be initialized	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	73	
Error	C2530	'position': references must be initialized	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	62	
Error	C2228	left of '.m_Coords' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	62	
Error	C2228	left of '.m_Norm' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	73	
Error	C2059	syntax error: 'const'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.h	73	
Error	C2238	unexpected token(s) preceding ';'	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.h	73	
Error	C2228	left of '.m_Norm' must have class/struct/union	graphics	C:\Dev\OSS\0ad-git\source\renderer\MikktspaceWrap.cpp	73
vladislavbelov accepted this revision.Thu, May 30, 6:15 PM
This revision is now accepted and ready to land.Thu, May 30, 6:15 PM
Stan updated this revision to Diff 8218.Thu, May 30, 7:16 PM

Fix misplaced brace

Stan updated this revision to Diff 8219.Thu, May 30, 7:18 PM

Fix cast;

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1550/display/redirect

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1551/display/redirect

Stan updated this revision to Diff 8228.Fri, May 31, 12:19 AM

trigger another build;

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1556/display/redirect

This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Fri, May 31, 1:03 AM