Page MenuHomeWildfire Games

merge archery tradition
ClosedPublic

Authored by Nescio on Fri, May 31, 7:10 PM.

Details

Summary

Currently two identical copies of the archery tradition technology are maintained, one for the Mauryas and one for the Persians. This patch merges them into archery_tradition.json. See attack_steel_working.json and siege_bolt_accuracy.json for comparison.
Furthermore:

  • deletes the now empty technologies/mauryas/ folder
  • sets the technology in the shared barracks parent, rather than in its individual children (see also final point at D1790), to make it less likely to overlook if another faction (kush?) gets it too
  • also adds it to the (as of yet unused) military range
Test Plan

Check nothing is overlooked.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Fri, May 31, 7:10 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1566/display/redirect

bb accepted this revision.Fri, May 31, 11:05 PM

Given that there is more versioning on the persian file, rename that one instead

All archery_traditions instances got change
Brit/Gaul/Celt don't have a tech directory either, so removing the Maurya one seems ok

Changing the rename during the commit => accept

thx for the patch, nice find

binaries/data/mods/public/simulation/templates/template_structure_military_range.xml
45 ↗(On Diff #8248)

sweet

This revision is now accepted and ready to land.Fri, May 31, 11:05 PM
This revision was automatically updated to reflect the committed changes.