Page MenuHomeWildfire Games

Windows Differential testing
Needs ReviewPublic

Authored by Angen on Jun 2 2019, 9:25 PM.

Details

Reviewers
Itms
Summary

adding testing of diffs on windows

To make it work with bat command, need to add this to jenkins paths:

patch: C:\Program Files\Git\usr\bin

or where patch.exe is located

Test Plan

..

Event Timeline

Angen created this revision.Jun 2 2019, 9:25 PM
Angen created this object with visibility "Custom Policy".
Owners added a subscriber: Restricted Owners Package.Jun 2 2019, 9:25 PM
Angen updated this revision to Diff 8289.Jun 3 2019, 11:57 AM
Angen edited the summary of this revision. (Show Details)

sh arc patch -> bat arc patch

Angen updated this revision to Diff 8290.Jun 3 2019, 1:20 PM

line 37

Itms added a comment.Jun 29 2019, 11:05 AM

I experimentally added this pipeline to Jenkins with the fix to arc patch, and made Phabricator run it on differentials. We'll see if there are unexpected issues. In the meantime, a few comments...

build/jenkins/win_diff.Jenkinsfile
35 ↗(On Diff #8290)

This is not correct. The DIFF_ID sent by Phabricator is not the ID of the revision, but the one of the diff. For instance, the diff I'm commenting on is diff 8290. The two previous diffs for this revision (D1946) were 8282 and 8289.

The correct call is

arc patch --diff ${params.DIFF_ID} --force
39 ↗(On Diff #8290)

same

46 ↗(On Diff #8290)

I'd be in favor of building Atlas. Let's make sure it builds, without the same bug as the autobuilder.

59 ↗(On Diff #8290)

Is there a reason you used unsuccessful instead of failure?

Angen added inline comments.Jun 29 2019, 12:37 PM
build/jenkins/win_diff.Jenkinsfile
35 ↗(On Diff #8290)

Ok, I see my misstake

46 ↗(On Diff #8290)

Do you mean to always build with --atlas and /t:AtlasUI ?

Itms added inline comments.Jun 29 2019, 6:48 PM
build/jenkins/win_diff.Jenkinsfile
46 ↗(On Diff #8290)

Yes :)

Angen updated this revision to Diff 8654.Jun 30 2019, 3:04 PM
Angen retitled this revision from Windows Differential testing [WIP] to Windows Differential testing.

fix patch
add debug
add atlas

Angen updated this revision to Diff 9782.Sep 15 2019, 1:31 PM

add flags for gloox and collada
split testing so release tests follow right after build of release version so in case they do not pass, there will be no build of debug version

Angen changed the visibility from "Custom Policy" to "Public (No Login Required)".Sep 15 2019, 1:34 PM
Stan added a subscriber: Stan.Sep 15 2019, 3:27 PM

Does it support stacked patches ?

Stan added a comment.Sep 15 2019, 5:48 PM

@Angen stacked patches are patches that are dependant. Ex Patch A requires patch B to be applied. Then B is stacked on top of A.

Angen added a comment.Sep 15 2019, 6:53 PM

no, but might be interesting improvement

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/186/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/733/display/redirect

Angen updated this revision to Diff 9822.Sep 17 2019, 9:06 PM

robocopy

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/734/display/redirect

Angen updated this revision to Diff 9831.Sep 17 2019, 10:32 PM

add timeout
fix robocopy

Angen planned changes to this revision.Sep 17 2019, 10:33 PM

try to fail after timeout

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/229/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/740/display/redirect

Angen added inline comments.Sep 18 2019, 7:28 AM
build/jenkins/win_diff.Jenkinsfile
13 ↗(On Diff #9831)

only build

40 ↗(On Diff #9831)

do not try to delete removed items by patch

114 ↗(On Diff #9831)

do not try to delete removed items by patch

Angen requested review of this revision.Tue, Nov 12, 6:55 PM
Angen planned changes to this revision.Sun, Dec 1, 6:49 PM

what i said above

Angen updated this revision to Diff 10454.EditedSun, Dec 1, 8:42 PM

moved to subdirectory
moving revert ahead of deletions so ugly spamming like in https://jenkins.wildfiregames.com/blue/organizations/jenkins/vs2015-differential/detail/vs2015-differential/604/pipeline will not happen

Vulcan added a comment.Sun, Dec 1, 8:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/666/display/redirect

Vulcan added a comment.Sun, Dec 1, 8:49 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1182/display/redirect