Paths

Table of Contentst

Differential D1948

Adds Camera test for ortho projection
ClosedPublic
Actions

Authored by vladislavbelov on Jun 3 2019, 9:14 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP22340: Adds Camera test for ortho projection.

Summary

Subj.

Test Plan

Apply the patch and compile tests
Run tests test TestCamera
Check that all tests are passed

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Jun 3 2019, 9:14 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1593/display/redirect

Harbormaster completed remote builds in B7753: Diff 8293.Jun 3 2019, 9:19 PM

All tests passed

wraitii added a subscriber: wraitii.Jun 5 2019, 7:10 PM

wraitii added inline comments.

source/lib/self_test.h
70 ↗	(On Diff #8293)	What's the purpose of CXXTEST_TEMPLATE_INSTANTIATION here over template<> ?

vladislavbelov added inline comments.Jun 5 2019, 8:39 PM

source/lib/self_test.h
70 ↗	(On Diff #8293)	Because of documentation for the adding custom `ValueTraits`, it uses `CXXTEST_TEMPLATE_INSTANTIATION`. I prefer to use the macro, because the value of the macro can be changed.

Alrighty then. Tests pass -> Commit.

This revision is now accepted and ready to land.Jun 5 2019, 9:25 PM

Closed by commit rP22340: Adds Camera test for ortho projection. (authored by vladislavbelov). · Explain WhyJun 5 2019, 9:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

source/

graphics/

tests/

34 lines

lib/

46 lines

Diff 8330

ps/trunk/source/graphics/tests/test_Camera.h

Loading...

ps/trunk/source/lib/self_test.h

Loading...