@Angen found a mistyping (likely because of copy-pasting) in rP21612. Also fixed few notes from elexis.
Details
Details
- Reviewers
Silier - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22334: Fixes a typo introduced in rP21612 in shore calculations, found by Angen and…
- Apply the patch and compile the game
- Make sure that water doesn't look worse
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues: Executing section Source... source/renderer/PatchRData.cpp | 1| /*·Copyright·(C)·2017·Wildfire·Games. | | [NORMAL] LicenseYearBear: | | License should have "2019" year instead of "2017" Executing section JS... Executing section cli...
Link to build: https://jenkins.wildfiregames.com/job/differential/1594/display/redirect
Comment Actions
Cannot reproduce water refraction bug and water looks cool -> accept
source/renderer/PatchRData.cpp | ||
---|---|---|
1 ↗ | (On Diff #8294) | year |