Page MenuHomeWildfire Games

Fixes mistypes introduced in rP21612
ClosedPublic

Authored by vladislavbelov on Jun 3 2019, 9:21 PM.

Details

Reviewers
Angen
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22334: Fixes a typo introduced in rP21612 in shore calculations, found by Angen and…
Summary

@Angen found a mistyping (likely because of copy-pasting) in rP21612. Also fixed few notes from elexis.

Test Plan
  1. Apply the patch and compile the game
  2. Make sure that water doesn't look worse

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Jun 3 2019, 9:21 PM
vladislavbelov edited the summary of this revision. (Show Details)
Vulcan added a comment.Jun 3 2019, 9:26 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...

source/renderer/PatchRData.cpp
|   1| /*·Copyright·(C)·2017·Wildfire·Games.
|    | [NORMAL] LicenseYearBear:
|    | License should have "2019" year instead of "2017"
Executing section JS...
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/1594/display/redirect

Angen accepted this revision.Jun 3 2019, 9:48 PM

Cannot reproduce water refraction bug and water looks cool -> accept

source/renderer/PatchRData.cpp
1 ↗(On Diff #8294)

year

This revision is now accepted and ready to land.Jun 3 2019, 9:48 PM
This revision was automatically updated to reflect the committed changes.