There were missed includes and forward declarations. But it was working because the CPatchRData.h was luckily included in a good place.
Details
- Reviewers
wraitii - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22371: Fixes includes and forward declarations in CPatchRData.
- Apply the patch and compile the game
- Make sure that it still compiles
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Build failure - The Moirai have given mortals hearts that can endure.
Link to build: https://jenkins.wildfiregames.com/job/differential/1597/display/redirect
source/renderer/PatchRData.h | ||
---|---|---|
37 ↗ | (On Diff #8301) | This doesn't compile. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2008/n2764.pdf Need to add : short to this and the definition for me. |
source/renderer/PatchRData.h | ||
---|---|---|
37 ↗ | (On Diff #8301) | I'd prefer to add include, because the storing type can be changed. |
source/renderer/PatchRData.h | ||
---|---|---|
37 ↗ | (On Diff #8301) | Sure. |
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1618/display/redirect
source/renderer/PatchRData.h | ||
---|---|---|
31 ↗ | (On Diff #8328) | Won't that lead to redefinition ? |
source/renderer/PatchRData.h | ||
---|---|---|
31 ↗ | (On Diff #8328) | Nope, it's declaration not definition. |
source/renderer/PatchRData.h | ||
---|---|---|
31 ↗ | (On Diff #8328) | Yeah but it's already declared in the file you included so the forward declaration doesn't make sense, does it ? |
source/renderer/PatchRData.h | ||
---|---|---|
31 ↗ | (On Diff #8328) | Yes, it makes sense in terms of the code support. You don't need to fix the code if you remove the only include. |