Page MenuHomeWildfire Games

Show helmets when doing citizen duty
ClosedPublic

Authored by Angen on Jun 8 2019, 1:39 PM.

Details

Summary
  1. Baskets while gathering meat does not have any sense as meat is carried on shoulders and even gathering animation ignores them
  2. Show helmets and capes (thanks to removed baskets) while unit does citizen work

It is nice visual change. It has sense to hide weapons but not helmets and capes.

Test Plan

Check I did not miss any animation file related.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Angen created this revision.Jun 8 2019, 1:39 PM
Owners added a subscriber: Restricted Owners Package.Jun 8 2019, 1:39 PM
Vulcan added a comment.Jun 8 2019, 1:41 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1655/display/redirect

Angen updated this revision to Diff 8379.Jun 8 2019, 1:41 PM

missed one

Vulcan added a comment.Jun 8 2019, 1:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1656/display/redirect

Idea: It would be nice to not hide weapons at all, but art is required. Swords could be in sheets, maybe carrying animation could be changed so unit will be still able to just carry weapon in one hand while meat on shoulder as now.

I think it is more logical to not wield a weapon when carrying meat. Just the visualisation that the entity is not suited for war ;)

Angen abandoned this revision.Nov 12 2019, 12:39 PM
Angen reclaimed this revision.Nov 12 2019, 1:46 PM

so take it back

Angen planned changes to this revision.Nov 12 2019, 1:49 PM

yeah needs more files to change xD

Angen updated this revision to Diff 10315.Nov 12 2019, 6:18 PM
Angen retitled this revision from Show helmets and capes while gathering and carrying meat to Show helmets when doing citizen duty.
Angen edited the summary of this revision. (Show Details)
Angen edited the test plan for this revision. (Show Details)
Angen added a reviewer: Stan.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/568/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/1082/display/redirect

Stan accepted this revision.Nov 13 2019, 10:53 PM

Change is good. I can't spot any oversight, will commit it as long with a fix for bows.

This revision is now accepted and ready to land.Nov 13 2019, 10:53 PM