Page MenuHomeWildfire Games

Show helmets and capes while gathering and carrying meat
Needs ReviewPublic

Authored by Angen on Jun 8 2019, 1:39 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary
  1. Baskets while gathering meat does not have any sense as meat is carried on shoulders and even gathering animation ignores them
  2. Show helmets and capes (thanks to removed baskets) while unit gathers or carries meat

It is nice visual change. It has sense to hide weapons but not helmets and capes.

Idea: It would be nice to not hide weapons at all, but art is required. Swords could be in sheets, maybe carrying animation could be changed so unit will be still able to just carry weapon in one hand while meat on shoulder as now.

Test Plan

Check I did not miss any animation file related to meat gathering or carrying

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7840
Build 12751: Vulcan BuildJenkins
Build 12750: arc lint + arc unit

Event Timeline

Angen created this revision.Jun 8 2019, 1:39 PM
Owners added a subscriber: Restricted Owners Package.Jun 8 2019, 1:39 PM
Vulcan added a comment.Jun 8 2019, 1:41 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1655/display/redirect

Angen updated this revision to Diff 8379.Jun 8 2019, 1:41 PM

missed one

Vulcan added a comment.Jun 8 2019, 1:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1656/display/redirect

Idea: It would be nice to not hide weapons at all, but art is required. Swords could be in sheets, maybe carrying animation could be changed so unit will be still able to just carry weapon in one hand while meat on shoulder as now.

I think it is more logical to not wield a weapon when carrying meat. Just the visualisation that the entity is not suited for war ;)