Minimum distance for pillar and monument
ClosedPublic
Actions

Authored by elexis on Mar 6 2017, 2:41 PM.

Details

Reviewers

mimo
Grugnas

Commits

rP19348: Pillar / Monument cleanup.

Summary

As proposed and discussed in #4412, the pillar could receive a minimum distance between each other,
because these structures are outstanding and they have not been built right beside each other, more like one per city.
The minimum distance also gives the player a bit feedback when they are useful and when not (the auras don't stack)

In this first revision of the proposal, the mauryan trading speed bonus monument receives the minimum distance equal to the radius of the range,
so that the territory of a city can still be fully covered.

The iberian attack bonus monument receives a minimum distance (150) grater than the diameter (100) of the monument, so that
it can only be used in certain strategic locations rather than covering the entire territory, as proposed by mimo in the ticket.

Test Plan

The mauryan pillar needs the hero ashoka in order to build it. The distance of the aura can be seen by producing a trade cart and selecting the pillar.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

elexis created this revision.Mar 6 2017, 2:41 PM

elexis edited a custom field.Mar 6 2017, 2:42 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/477/ for more details.

Harbormaster completed remote builds in B693: Diff 726.Mar 6 2017, 3:27 PM

Pillar of Ashoka tooltips don't show the range and the movement speed amount of the aura which is of 20%.
Since in team games limiting the usage to own territory only isn't valuable because territory influences collding quite often, would even be appropriate allow players to build those pillars in ally territory or benefit from ally pillars too?

In D196#7471, @Grugnas wrote:

Pillar of Ashoka tooltips don't show the range and the movement speed amount of the aura which is of 20%.
Since in team games limiting the usage to own territory only isn't valuable because territory influences collding quite often

Maybe yes. Still want a generic solution so that all auras and techs show numbers without hardcoding them in the string.
Also Sandarac is working on visualizing aura ranges. This likely doesn't work with building previews, but would be a significant improvement in estimating the usefulness of newly placed buildings.

would even be appropriate allow players to build those pillars in ally territory or benefit from ally pillars too?

Nah, don't break the territory concept which is one of the few things that makes 0 A.D. unique. Also historically not ideal I guess

the pillar shouldn't be capturable, same happens for the iberian monument.
auraName: "Edict of Ashoka" misses from maur_pillar.json file.

This revision now requires changes to proceed.Mar 26 2017, 12:33 AM

In D196#9965, @Grugnas wrote:

the pillar shouldn't be capturable, same happens for the iberian monument.
auraName: "Edict of Ashoka" misses from maur_pillar.json file.

Good observations (in that capture the relic testgame where you noticed those, reminding me of this diff).

Disabling the capture component was a design decision from rP18024 which I agreed upon, as capturing this entity is easy. Due to it having root territory, the entire territory switched ownership quickly.
Therefore agreeing to remove it here too.
The proposed string is fitting and makes that aura show up in the tech tree and ingame tooltips, which not only makese it more consistent but also reveals the quantity of the aura effect.

Notice the patch should address mimo's comment in http://trac.wildfiregames.com/ticket/4412#comment:5

put a value bigger than the range to avoid such a full coverage, maybe twice the range

Notice twice the range (radius) means that two auras can still meet. Using thrice the radius instead.
So there is 1x radius from the pillar to the aura radius, then 1x radius range free of iberian attack bonus, then 1x radius aura range to the next closest iberian pillar.
Do you agree with that number?
mauryan pillar has exactly radius range, so people can fully cover their territory (and even intersect auras).

Carefully comparing the templates only reveals that the iberian one has 60m vision range, the other one 40m and the iberian one also having an entirely unused history string.

Add the aura name, so that the tooltip shows up.
Disable capture component.

Grugnas accepted this revision.Mar 26 2017, 1:50 AM

This revision is now accepted and ready to land.Mar 26 2017, 1:50 AM

Closed by commit rP19348: Pillar / Monument cleanup. (authored by elexis). · Explain WhyMar 26 2017, 3:09 AM

This revision was automatically updated to reflect the committed changes.

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (305 tests).................................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/600/ for more details.

Harbormaster completed remote builds in B892: Diff 948.Mar 26 2017, 3:23 AM