Differential D1972

Makes some rendering helpers be available through the developer overlay.
ClosedPublic
Actions

Authored by vladislavbelov on Jun 12 2019, 10:39 PM.

Details

Reviewers

wraitii

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP22395: Makes rendering helpers (culling camera, frustums) be available through the…

Summary

It helps to test/debug patches like D1847.

Test Plan

Apply the patch and compile the game
Run the game and open the developer overlay
Make sure that these functions are working

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Jun 12 2019, 10:39 PM

Stan awarded a token.Jun 12 2019, 10:41 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1703/display/redirect

Harbormaster completed remote builds in B7915: Diff 8454.Jun 12 2019, 11:21 PM

Pretty trippy effects. Indeed helpful.

I would suggest "Enable Culling" since all other labels use the present tense.

This revision is now accepted and ready to land.Jun 16 2019, 12:23 PM

Closed by commit rP22395: Makes rendering helpers (culling camera, frustums) be available through the… (authored by vladislavbelov). · Explain WhyJun 23 2019, 10:18 PM

This revision was automatically updated to reflect the committed changes.

Owners added a subscriber: Restricted Owners Package.Jun 23 2019, 10:18 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

session/

developer_overlay.js

21 lines

Diff 8589

View Options

ps/trunk/binaries/data/mods/public/gui/session/developer_overlay.js

Makes some rendering helpers be available through the developer overlay.ClosedPublicActions