Differential D1978
tests: Fix cppformat failures on osx (locale-related) Authored by Krinkle on Jun 15 2019, 7:37 PM.
Details
TestCppformat::test_basic: test_cppformat.h:36: Expected …, found ("0,500000" != 0.500000)
test_cppformat.h:37: Expected …, found ("0,1" != 0.1)This test varies behaviour by locale, which caused the test to fail on osx by default.
Diff Detail
Event TimelineComment Actions Assigning to myself as I can reproduce the issue.
Comment Actions Fixes my issue and seems correct to update the locale with regards to blame of this test. On the CStr issue - it appears OSX is doing something weird - same issue as the guy there indeed it seems, good find @vladislavbelov. If I run: #include <sstream>
int main()
{
// 97 to 122 or 65 to 90
for (char i = 65; i <= 90; i++)
{
std::string test = "2", test_non_cap = "2";
test += i;
test_non_cap += i + 32;
std::stringstream stream(test), stream_non_cap(test_non_cap);
float out, out_non_cap;
stream >> out;
stream_non_cap >> out_non_cap;
printf("%s: %f -- %s: %f\n", test.c_str(), out, test_non_cap.c_str(), out_non_cap);
}
return 0;
}It outputs: 2A: 0.000000 -- 2a: 0.000000 2B: 0.000000 -- 2b: 0.000000 2C: 0.000000 -- 2c: 0.000000 2D: 0.000000 -- 2d: 0.000000 2E: 0.000000 -- 2e: 0.000000 2F: 0.000000 -- 2f: 0.000000 2G: 2.000000 -- 2g: 2.000000 2H: 2.000000 -- 2h: 2.000000 2I: 0.000000 -- 2i: 0.000000 2J: 2.000000 -- 2j: 2.000000 2K: 2.000000 -- 2k: 2.000000 2L: 2.000000 -- 2l: 2.000000 2M: 2.000000 -- 2m: 2.000000 2N: 0.000000 -- 2n: 0.000000 2O: 2.000000 -- 2o: 2.000000 2P: 0.000000 -- 2p: 0.000000 2Q: 2.000000 -- 2q: 2.000000 2R: 2.000000 -- 2r: 2.000000 2S: 2.000000 -- 2s: 2.000000 2T: 2.000000 -- 2t: 2.000000 2U: 2.000000 -- 2u: 2.000000 2V: 2.000000 -- 2v: 2.000000 2W: 2.000000 -- 2w: 2.000000 2X: 0.000000 -- 2x: 0.000000 2Y: 2.000000 -- 2y: 2.000000 2Z: 2.000000 -- 2z: 2.000000 which is pretty weird. | ||||||||||||||||||||||||||||||||||||||||||||||||