Page MenuHomeWildfire Games

UnitMotion - make ComputeTargetPosition return a position for point goals
ClosedPublic

Authored by wraitii on Jun 15 2019, 9:43 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22426: UnitMotion - make ComputeTargetPosition return a position for point goals
Summary

This is useful since we can know use this function everywhere.

Furthermore, this lets us merge TryGoingStraightTo** family of function. This means it is now called even for point goals and decreases the likelihood of stuck units.

Test Plan

Compile.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jun 15 2019, 9:43 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1734/display/redirect

Stan added a subscriber: Stan.Jun 15 2019, 11:49 PM
Stan added inline comments.
source/simulation2/components/CCmpUnitMotion.cpp
1004 ↗(On Diff #8494)

Shouldn't there still be a check for that ?

wraitii marked an inline comment as done.Sun, Jun 30, 8:42 PM
wraitii added inline comments.
source/simulation2/components/CCmpUnitMotion.cpp
1004 ↗(On Diff #8494)

No, it's no longer needed.

wraitii updated this revision to Diff 8664.Sun, Jun 30, 8:44 PM
wraitii marked an inline comment as done.
wraitii edited the summary of this revision. (Show Details)

This had a few more implications than I initially realised, namely that TryGoingStraightToTargetEntity worked for point goals too.

This is thus a fix for numerous "queued orders don't work" situations, as the walking entities will now actually arrive at exactly their destination and thus will be able to perform queued orders.

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/differential/1860/display/redirect

wraitii updated this revision to Diff 8689.Tue, Jul 2, 8:51 AM
wraitii edited the summary of this revision. (Show Details)

Rebased so that jenkins can build it.

Vulcan added a comment.Tue, Jul 2, 9:26 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1874/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jul 2, 9:29 AM
This revision was automatically updated to reflect the committed changes.