Differential D1985

Skybox calculation - fix regression of rP22039 introduced in rP22297
ClosedPublic
Actions

Authored by wraitii on Jun 15 2019, 10:04 PM.

Details

Reviewers

vladislavbelov

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP22399: Skybox calculation - fix regression of rP22039 introduced in rP22297

Summary

Use the opportunity to clean things up a bit.

Test Plan

Check that reflections enabled/disabled (with refractions) look almost the same.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

temp

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 7958
Build 12953: Vulcan Build	Jenkins
Build 12952: arc lint + arc unit

Event Timeline

wraitii created this revision.Jun 15 2019, 10:04 PM

vladislavbelov added a reviewer: vladislavbelov.Jun 15 2019, 10:06 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1738/display/redirect

Harbormaster completed remote builds in B7958: Diff 8498.Jun 15 2019, 10:59 PM

wraitii mentioned this in rP22297: Water GLSL shader improvements around reflections and whitespace fixes..Jun 20 2019, 8:58 AM

I tested, now the reflection works as after my commit.

This revision is now accepted and ready to land.Jun 21 2019, 6:00 PM

(As mentioned byVladislav on IRC (http://irclogs.wildfiregames.com/2019-06/2019-06-21-QuakeNet-%230ad-dev.log) and in rP22297, this diff is correct because rP22297 reverted (and whitespace-formatted?) a hunk that was removed in rP22039.)

In D1985#83464, @elexis wrote:

(As mentioned byVladislav on IRC (http://irclogs.wildfiregames.com/2019-06/2019-06-21-QuakeNet-%230ad-dev.log) and in rP22297, this diff is correct because rP22297 reverted (and whitespace-formatted?) a hunk that was removed in rP22039.)

Why are you stating what git-blame can easily show to anyone.

(1) So that the one reading this diff knows what's happening.
(2) So that cross-references are inserted

Closed by commit rP22399: Skybox calculation - fix regression of rP22039 introduced in rP22297 (authored by wraitii). · Explain WhyJun 25 2019, 9:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

binaries/

data/

mods/

public/

shaders/

glsl/

water_high.fs

21 lines

Diff 8498

View Options

binaries/data/mods/public/shaders/glsl/water_high.fs

Skybox calculation - fix regression of rP22039 introduced in rP22297ClosedPublicActions