Support Resource Tooltips
ClosedPublic
Actions

Authored by elexis on Mar 7 2017, 10:38 AM.

Details

Reviewers

Commits

rP19472: Add support for resource descriptions and display them in the tooltip of the…

Summary

As requested in https://wildfiregames.com/forum/index.php?/topic/21935-resource-tooltips/
some mods might want to add descriptions for resources and display them in related places.

The attached patch adds support for adding resource descriptions, marking them as translatable and showing them in the top panel.

These strings in particular seem a bit useless, we can remove them and still add the code to support descriptions.
If someone has some proposals that wouldn't hurt.

The descriptions could also be shown in the summary screen code (which would need some rewiring), could be done in a simple ticket.

Test Plan

Start a match, hover the mouse over the resources. Research shared ally vision to see that the allied resources tooltip is visible too.
Execute the updateTemplates.py script, open the public-gui-other.pot file and search for simulation/data/resources/metal.json:description to confirm that the strings are extracted.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

elexis created this revision.Mar 7 2017, 10:38 AM

Harbormaster completed remote builds in B701: Diff 730.Mar 7 2017, 10:38 AM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/479/ for more details.

Harbormaster completed remote builds in B701: Diff 730.Mar 7 2017, 11:24 AM

Sandarac added a subscriber: Sandarac.Mar 8 2017, 1:38 AM

Sandarac added inline comments.

binaries/data/mods/public/gui/session/session.js
1119 ↗	(On Diff #730)	Extra space.

elexis added a reviewer: wowgetoffyourcellphone.Mar 29 2017, 11:41 AM

wowgetoffyourcellphone awarded a token.Apr 29 2017, 8:48 AM

Works as advertised. I cannot comment on the code itself, but the end result gives the desired functionality as requested.

This revision is now accepted and ready to land.Apr 29 2017, 8:53 AM

Closed by commit rP19472: Add support for resource descriptions and display them in the tooltip of the… (authored by elexis). · Explain WhyApr 29 2017, 7:57 PM

This revision was automatically updated to reflect the committed changes.

Thanks for the test!

binaries/data/mods/public/gui/session/session.js
1119 ↗	(On Diff #730)	thx
binaries/data/mods/public/simulation/data/resources/food.json
4 ↗	(On Diff #730)	fields
binaries/data/mods/public/simulation/data/resources/metal.json
4 ↗	(On Diff #730)	Periods
binaries/data/mods/public/simulation/data/resources/stone.json
4 ↗	(On Diff #730)	or ruins.