Paths

Table of Contentst

Differential D2004

Linter: Fix ESLint semicolon-related warnings
ClosedPublic
Actions

Authored by Krinkle on Jun 20 2019, 1:45 AM.

Tags

None

Subscribers

Restricted Owners Package

Restricted Owners Package

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Owners Package	(Owns No Changed Paths)

Commits

rP22419: Fix ESLint semicolon-related warnings

Trac Tickets

Summary

This uses eslint --fix to automatically repair coding style violations.

This commit is scoped to binaries/data/ only, and limited to these three rules:

"no-extra-semi"
"semi"
"semi-spacing"

No manual fixups seem to be needed. I did exclude the fixes it made to
binaries/data/mods/mod/globalscripts/sprintf.js, as that appears to be
upstream file and not something meant to follow our coding style.

In a follow-up I'll add an Coala exclude for that, so that it won't complain again.

Test Plan

Coala passing.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Krinkle created this revision.Jun 20 2019, 1:45 AM

Harbormaster completed remote builds in B8034: Diff 8568.Jun 20 2019, 1:45 AM

(Re-upload of same diff with more context lines to aid in review.)

Harbormaster completed remote builds in B8037: Diff 8571.Jun 21 2019, 9:48 PM

patch reads correct, and jshints complete

The trick will now be to keep the code like this, we obviously have vulcan complaining, but as that is too spammy sometimes (ofcourse fixing stuff helps...), any chance this rule can be added for all phab uploads (as is done for trailing spaces)

binaries/data/mods/public/simulation/components/tests/test_Math.js
129 ↗	(On Diff #8571)	missing space

This revision is now accepted and ready to land.Jun 28 2019, 6:29 PM

Krinkle added inline comments.Jun 29 2019, 1:23 AM

binaries/data/mods/public/simulation/components/tests/test_Math.js
129 ↗	(On Diff #8571)	Yes, but out of scope for this patch, which deals with small set of rules only (semi-colons rules in this case) all linted files in the repo. I can also do the inverse: Fix all rules at once over a small set of files, which I did for petra at D1993. Would you prefer that? That has the benefit of immediately making Vulcan 100% useful for those directories as we go forward, but is also more work to review...

Closed by commit rP22419: Fix ESLint semicolon-related warnings (authored by bb). · Explain WhyJul 1 2019, 1:09 PM

This revision was automatically updated to reflect the committed changes.

Owners added subscribers: Restricted Owners Package, Restricted Owners Package.Jul 1 2019, 1:09 PM

Krinkle updated the Trac tickets for this revision.Jul 20 2019, 9:33 PM

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

_test.sim/

simulation/

components/

test-serialize.js

2 lines

mod/

gui/

common/

functions_msgbox.js

2 lines

termsdialog/

2 lines

hwdetect/

2 lines

public/

gui/

session/

2 lines

selection_panels.js

2 lines

maps/

random/

alpine_valley.js

2 lines

belgian_uplands.js

2 lines

2 lines

4 lines

elephantine_triggers.js

2 lines

fields_of_meroe.js

2 lines

2 lines

2 lines

hyrcanian_shores.js

2 lines

2 lines

2 lines

10 lines

2 lines

rhine_marshlands.js

2 lines

rmbiome/

2 lines

rmgen-common/

wall_builder.js

2 lines

rmgen/

4 lines

2 lines

placer/

noncentered/

ConvexPolygonPlacer.js

2 lines

EntitiesObstructionPlacer.js

2 lines

2 lines

snowflake_searocks.js

2 lines

4 lines

simulation/

components/

2 lines

2 lines

SkirmishReplacer.js

2 lines

TechnologyManager.js

2 lines

2 lines

UnitMotionFlying.js

2 lines

tests/

2 lines

test_EntityLimits.js

18 lines

2 lines

test_RallyPoint.js

4 lines

4 lines

tests/

14 lines

Diff 8673

ps/trunk/binaries/data/mods/_test.sim/simulation/components/test-serialize.js

Loading...

ps/trunk/binaries/data/mods/mod/gui/common/functions_msgbox.js

Loading...

ps/trunk/binaries/data/mods/mod/gui/termsdialog/termsdialog.js

Loading...

ps/trunk/binaries/data/mods/mod/hwdetect/test.js

Loading...

ps/trunk/binaries/data/mods/public/gui/session/menu.js

Loading...

ps/trunk/binaries/data/mods/public/gui/session/selection_panels.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/alpine_valley.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/belgian_uplands.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/deep_forest.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/dodecanese.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/elephantine_triggers.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/fields_of_meroe.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/flood.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/hellas.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/hyrcanian_shores.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/lake.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/migration.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/oasis.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/pompeii.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rhine_marshlands.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmbiome/randombiome.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmgen-common/wall_builder.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmgen/Constraint.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmgen/TileClass.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmgen/placer/noncentered/ConvexPolygonPlacer.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/rmgen/placer/noncentered/EntitiesObstructionPlacer.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/schwarzwald.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/snowflake_searocks.js

Loading...

ps/trunk/binaries/data/mods/public/maps/random/syria.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/Heal.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/Mirage.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/SkirmishReplacer.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/TechnologyManager.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/UnitAI.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/UnitMotionFlying.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/tests/setup_test.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_EntityLimits.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Math.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_RallyPoint.js

Loading...

ps/trunk/binaries/data/mods/public/simulation/components/tests/test_Vector.js

Loading...

ps/trunk/binaries/data/tests/test_setup.js

Loading...