Page MenuHomeWildfire Games

standardize resource tooltips
Needs ReviewPublic

Authored by Nescio on Sun, Jun 23, 7:07 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

This patch:

  • remove <Type>stone.ruins</Type> from specific gaia/ruins/ templates, because already defined in generic parent template
  • removed <Type>treasure.metal</Type> from template_gaia_treasure.xml because all its children define their own <Type>
  • remove tooltips from specific gaia/ templates, because already defined in generic parent template
  • standardizes the tooltips of resource templates to "[verb] [subtype] for [resources]."
    • preceded by "Kill to" if <KillBeforeGather>true</KillBeforeGather>
  • treasure tooltip is formulated slightly differently (but similar)
  • farm field is already done in D1803

[EDIT]: Potential ideas for future patches:

  • reduce duplication in flora and geo templates by replacing:
template_gaia_flora.xml
template_gaia_flora_bush.xml
template_gaia_flora_bush_berry.xml
template_gaia_flora_tree.xml
template_gaia_flora_tree_fruit.xml
template_gaia_geo.xml
template_gaia_geo_mineral.xml
template_gaia_geo_mineral_slabs.xml
template_gaia_geo_rock.xml
template_gaia_geo_rock_slabs.xml

with:

template_gaia_fruit.xml
template_gaia_ore.xml
template_gaia_ore_small.xml
template_gaia_rock.xml
template_gaia_rock_small.xml
template_gaia_tree.xml
  • might also want to deprecate template_gaia_geo.xml because it has little added value
  • merge template_unit_fauna_herd.xml with its one and only child,*_domestic.xml
  • change whale resource type from fish to meat, to be consistent with other fauna, and to allow fishing boats to have different gather rates for fish and whales (requires meat gather animations, though)
Test Plan

Check for mistakes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8051
Build 13103: Vulcan BuildJenkins
Build 13102: arc lint + arc unit

Event Timeline

Nescio created this revision.Sun, Jun 23, 7:07 PM
Nescio edited the summary of this revision. (Show Details)
Nescio edited the summary of this revision. (Show Details)Sun, Jun 23, 7:10 PM
Nescio edited the summary of this revision. (Show Details)

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1798/display/redirect