Page MenuHomeWildfire Games

standardize formation tooltips
Needs ReviewPublic

Authored by Nescio on Sun, Jun 23, 7:26 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Standardize formation tooltips to "Requires at least [number] [class]".
(Prompted by @elexis in rP22081.)

Test Plan

Check for mistakes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8107
Build 13194: Vulcan BuildJenkins
Build 13193: arc lint + arc unit

Event Timeline

Nescio created this revision.Sun, Jun 23, 7:26 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1799/display/redirect

elexis added inline comments.Mon, Jun 24, 4:11 AM
binaries/data/mods/public/simulation/templates/special/formations/anti_cavalry.xml
6

Since when is melee and infantry not capitalized? (I remember being corrected on that)

binaries/data/mods/public/simulation/templates/special/formations/box.xml
6

Soldiers?

Nescio added inline comments.Mon, Jun 24, 9:40 AM
binaries/data/mods/public/simulation/templates/special/formations/anti_cavalry.xml
6

Oops, my mistake, https://trac.wildfiregames.com/wiki/EnglishStyleGuide suggests classes ought to be capitalized; wasn't done previously for formations.

binaries/data/mods/public/simulation/templates/special/formations/box.xml
6

Soldiers and siege but not ships. Any term that covers that?

Nescio updated this revision to Diff 8639.Sat, Jun 29, 1:21 PM

Capitalized classes.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1837/display/redirect

It's a bit unfortunate that tooltips speaking of classes are in formation templates, whereas it's actually unit templates that decide what formations they can have.
Is it a good idea to change that? Not sure.

Yes, it's unfortunate. And although the classes which could join a certain formation are defined in the templates, the formations that are actually available are defined in the {civ}.json files.