Formation members that attack as part of an attacking formation can run in a rare infinite loop, where they go through Idle, Find a new target, try and attack it, and MoveToTargetAttackRange returns false, triggering the whole attack.
This patch aims to correct formation members' idle behaviour, under the assumption that:
- Formation units are never idle (they're in formation)
- Formation units have no autonomy (they're in formation)
Thus their idle state should do nothing.
The question is:
- should we also change the [Move/Check]TargetAttackRange functions to not handle formations members any specially?