Details
- Reviewers
elexis - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22403: Removes unused and obsolete LightingModel.
- Apply the patch and compile the game
- Make sure that everything is rendered as before
- Make sure that shaders or other code doesn't have occurrences of LIGHTING_MODEL
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Lint Skipped - Unit
Unit Tests Skipped - Build Status
Buildable 8077 Build 13147: Vulcan Build Jenkins
Event Timeline
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/differential/1817/display/redirect
- No call to SetLightingModel in *.cpp, *.h, no further call to GetLightingModel and m_LightingModel
- No occurrence of LIGHTING_MODEL in shader files
rP11453 says
Remove non-supported 'old' lighting model.
so that commit aguably forgot to remove it completely.
(rP11473 left one call there)
Observation repeated, argument accepted, I didn't test though.
| source/graphics/LightEnv.h | ||
|---|---|---|
| 60 | I know that above settings exist in Atlas and influence shading, although this doesn't mean that this isn't possibly duplicate dead code, I didn't check that part, you did? Agree with moving the private parts. | |
| 64 | I don't object to removing this, since it is is unused, arguably misleading if the comment states things that don't hold, and a multi lightning model implementation might have to be revised. | |
| source/graphics/LightEnv.h | ||
|---|---|---|
| 60 | These members are used. For ex. GetRotation is used for sky. | |