Allows replays in autostart-nonvisual mode
ClosedPublic
Actions

Authored by vladislavbelov on Jun 27 2019, 12:13 AM.

Details

Reviewers

elexis

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP22432: Adds a possibility to disable saving of replay in autostart mode.

Summary

Autostart-nonvisual mode was added in D379. Currently it's impossible to save a replay in this mode. But it'd be useful to control a replay.

Usecases:

Automatic testing with autostart, a replay will help to reproduce the problem.
Game debugging, when you restart the game very frequently. Without disabled replays it will be harder to find a real replay.

Test Plan

Apply the patch and compile the game
Run the game as usual with and without the -disable-replays flag
Run autostart mode with and without this flag
Make sure that everything works as expected

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vladislavbelov created this revision.Jun 27 2019, 12:13 AM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1826/display/redirect

Harbormaster completed remote builds in B8091: Diff 8624.Jun 27 2019, 12:23 AM

elexis awarded a token.Jun 27 2019, 2:01 AM

Renames to autostart-disable-replay by @elexis suggestion.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1830/display/redirect

Harbormaster completed remote builds in B8097: Diff 8630.Jun 27 2019, 10:52 PM

I checked D379 for replay discussions and didn't find anything related.
I acknowledge the use case to enable (debug) and the use case to disable (spam) per commandline for autostart games.
I believe that if the same choice is provided to users, it should be an ingame option in the options page, gamesetup page, or summary page.
I agree that it makes sense to have it enabled by default, since it already is enabled per default for all non-autostart games all visual-autostart games (consistency argument). Perhaps one could argue that most autostart-visual users want a replay and most nonvisual-autostart users don't want it, and both of these users start per hand? In that case it still makes more sense to me to have it consistent.

I didn't compile and test, given that this is a oneline change and doesn't appear to contain platform-dependent code, I take the responsibility to trust you for this change and fix or revert myself in case of badness.

binaries/system/readme.txt
24 ↗	(On Diff #8630)	A bit recursive definition (X = X), so the text on the right side doesn't add any information, only placeholder so that it doesn't look weird if there is no text. Perhaps "disable saving of replays", "Do not write replay file", or keep as is (because actually it's X = X saving), all acceptable.

This revision is now accepted and ready to land.Jun 28 2019, 1:12 AM

Closed by commit rP22432: Adds a possibility to disable saving of replay in autostart mode. (authored by vladislavbelov). · Explain WhyJul 3 2019, 11:36 PM

This revision was automatically updated to reflect the committed changes.