Page MenuHomeWildfire Games

Fix AtlasUI.dll windows autobuild
Needs ReviewPublic

Authored by Angen on Jun 29 2019, 12:31 PM.

Details

Reviewers
Itms
Trac Tickets
#5574
Summary

To rebuild AtlasUI.dll one need to pass AtlasUI as project to MSBuild. (Strange, that gloox is fine without its param)

Test Plan

Test that AtlasUI.dll is rebuild

Event Timeline

Angen created this revision.Jun 29 2019, 12:31 PM
Owners added a subscriber: Restricted Owners Package.Jun 29 2019, 12:31 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1836/display/redirect

Stan awarded a token.Jun 29 2019, 12:41 PM
elexis updated the Trac tickets for this revision.Sep 8 2019, 2:23 PM
elexis added a subscriber: elexis.EditedSep 8 2019, 7:57 PM

As mentioned in the ticket, reported a month ago by AlexanderMB, the Atlas Actor Viewer doesn't work currently because the Atlas.dll is 18 months old.

From IRC today:

(07:43:38 PM) elexis: Angen: if we commit that patch, Jenkins will checkout that file and thus commit the new dll, no?
(07:45:51 PM) Angen: if you commit my diff jenkins should use new script in next build i think but will not build atlas until new change in atlas files will come as far as i know 
(07:46:07 PM) elexis: I can trigger an Atlas build through the web UI
(07:46:17 PM) elexis: there is an atlas checkbox
(07:46:19 PM) elexis: it just never did something apparently
(07:46:32 PM) elexis: are you ubersure that the patch is correct?
(07:47:14 PM) elexis: in the worst case we break Jenkins altogether i suppose x)
(07:47:29 PM) Angen: patch is correct it worked at my version of jenkins
(07:47:30 PM) elexis: more importantly unrecoverably without access
(07:48:20 PM) Angen: as far as there is used the version which is versioned in svn
(07:49:20 PM) Angen: definitly it should not break jenkins

and

(07:55:39 PM) Stan`: I'll send a message and see how it goes

Itms requested changes to this revision.Sep 17 2019, 10:13 PM

I patched the Jenkins script, but this robocopy call is broken, I had to manually copy files on the slave. This needs to be fixed before committing.

This revision now requires changes to proceed.Sep 17 2019, 10:13 PM
Angen updated this revision to Diff 9828.Sep 17 2019, 10:26 PM

fix robocopy

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/vs2015-differential/227/display/redirect

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/738/display/redirect

kenny added a subscriber: kenny.Sep 18 2019, 12:17 AM