Page MenuHomeWildfire Games
Differential D2023

Add a coala bear to try and detect unimplemented mirage functions.
AbandonedPublic
Actions

Authored by wraitii on Jun 29 2019, 2:41 PM.

Details

Reviewers
Itms
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

Follow-up to D2018. I forgot to implement a function in Mirage.js and that ended up failing.

This introduces a bear for Coala that tries to detect such cases.

This is a bit of an experiment, and rather not a robust implementation, but it does detect the issue fixed by D2018.

Test Plan

Review python, suggest improvements, suggest if we should do these kind of things or not.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
temp
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8110
Build 13200: Vulcan BuildJenkins
Build 13199: arc lint + arc unit

Event Timeline

wraitii created this revision.Jun 29 2019, 2:41 PM
Owners added a subscriber: Restricted Owners Package.Jun 29 2019, 2:41 PM
wraitii retitled this revision from Add a coal bear to try and detect unimplemented mirage functions. to Add a coala bear to try and detect unimplemented mirage functions..Jun 29 2019, 2:41 PM
Vulcan added a comment.Jun 29 2019, 2:42 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1840/display/redirect

Harbormaster completed remote builds in B8110: Diff 8642.Jun 29 2019, 2:42 PM
wraitii abandoned this revision.May 30 2020, 2:29 PM

DoA, but running some static analysis on our JS is probably a good idea. Should look into js analysers & lexers.

Revision Contents
Changeset List

PathSize
2 lines
build/
coala/
49 lines

Diff 8642

View Options

.coafile

Loading...
View Options

build/coala/MirageBear.py

Loading...
Wildfire Games · Phabricator