Page MenuHomeWildfire Games

correct technology specific names
Needs ReviewPublic

Authored by Nescio on Jun 29 2019, 3:05 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This patch affects the specific names in the technologies json files:

Test Plan

Check for mistakes and omissions.

Event Timeline

Nescio created this revision.Jun 29 2019, 3:05 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1842/display/redirect

Nescio added a reviewer: Restricted Owners Package.Jul 6 2019, 5:46 PM

removed when requirements prevent it for civs

The requirements may be changed, would it be an idea to keep those names, when correct, just in case? Otherwise they need to search for them again, perhaps?

The requirements may be changed, would it be an idea to keep those names, when correct, just in case? Otherwise they need to search for them again, perhaps?

Why? All information is preserved in the file history. Besides, the technologies in question are not even used, they're deprecated years ago; I think it would be best to simply remove those, but that discussion belongs elsewhere (D1775).

Nescio added a subscriber: Stan.Feb 7 2020, 10:53 PM

@Stan, interested in reviewing this one? It ought to be uncontroversial, just specific name strings.

Nescio planned changes to this revision.Sat, Jul 25, 11:19 AM
Nescio updated this revision to Diff 13000.Sat, Aug 1, 10:20 PM
Nescio retitled this revision from Technology specific names to correct technology specific names.
Nescio added a subscriber: Itms.
  • rebased and updated
Owners added a subscriber: Restricted Owners Package.Sat, Aug 1, 10:20 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2837/display/redirect