Page MenuHomeWildfire Games

Technology specific names
Needs ReviewPublic

Authored by Nescio on Jun 29 2019, 3:05 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

This patch affects the specific names in the technologies json files:

Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8112
Build 13204: Vulcan BuildJenkins
Build 13203: arc lint + arc unit

Event Timeline

Nescio created this revision.Jun 29 2019, 3:05 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1842/display/redirect

Nescio added a reviewer: Restricted Owners Package.Jul 6 2019, 5:46 PM

removed when requirements prevent it for civs

The requirements may be changed, would it be an idea to keep those names, when correct, just in case? Otherwise they need to search for them again, perhaps?

The requirements may be changed, would it be an idea to keep those names, when correct, just in case? Otherwise they need to search for them again, perhaps?

Why? All information is preserved in the file history. Besides, the technologies in question are not even used, they're deprecated years ago; I think it would be best to simply remove those, but that discussion belongs elsewhere (D1775).