Page MenuHomeWildfire Games

correct technology specific names
ClosedPublic

Authored by Nescio on Jun 29 2019, 3:05 PM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP24450: Correct technology specific names.
Summary

This patch affects the specific names in the technologies json files:

Test Plan

Check for mistakes and omissions.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Nescio created this revision.Jun 29 2019, 3:05 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1842/display/redirect

Nescio added a reviewer: Restricted Owners Package.Jul 6 2019, 5:46 PM

removed when requirements prevent it for civs

The requirements may be changed, would it be an idea to keep those names, when correct, just in case? Otherwise they need to search for them again, perhaps?

The requirements may be changed, would it be an idea to keep those names, when correct, just in case? Otherwise they need to search for them again, perhaps?

Why? All information is preserved in the file history. Besides, the technologies in question are not even used, they're deprecated years ago; I think it would be best to simply remove those, but that discussion belongs elsewhere (D1775).

Nescio added a subscriber: Stan.Feb 7 2020, 10:53 PM

@Stan, interested in reviewing this one? It ought to be uncontroversial, just specific name strings.

Nescio planned changes to this revision.Jul 25 2020, 11:19 AM
Nescio updated this revision to Diff 13000.Aug 1 2020, 10:20 PM
Nescio retitled this revision from Technology specific names to correct technology specific names.
Nescio added a subscriber: Itms.
  • rebased and updated
Owners added a subscriber: Restricted Owners Package.Aug 1 2020, 10:20 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/2837/display/redirect

The requirements may be changed, would it be an idea to keep those names, when correct, just in case? Otherwise they need to search for them again, perhaps?

How cute, I didn't have a clue how a versioning system worked back then xD

Anyway, this still applies, is it still complete?

Try arc patch D2025.

I'm not sure how that would tell me whether this is complete ^^

Apparently there's a misunderstanding: you initially asked whether it is still complete.
No new technologies with specific names have been added recently, so if a patch was complete and still applies, then it is still complete.
As for your follow-up question, whether it is complete, you could do a grep -r specificName in the technologies folder; a few more files will show up then (e.g. successors/special_war_horses.json), but you can open them manually and observe they don't need changing.
If I did overlook something, then please let me know.

Apparently there's a misunderstanding: you initially asked whether it is still complete.
No new technologies with specific names have been added recently, so if a patch was complete and still applies, then it is still complete.

Yes indeed, that was indeed what I wanted to know :)

As for your follow-up question, whether it is complete

Well, it was only one question actually. I have no clue about specific names whatsoever so I'm sailing on you here ;) Hence the question.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 26 2020, 7:21 AM
This revision was automatically updated to reflect the committed changes.