Page MenuHomeWildfire Games

Fix IsInjured overwrite in rP22411
ClosedPublic

Authored by wraitii on Sat, Jun 29, 9:37 PM.

Details

Summary

...

Test Plan

test-ingame and notice that this is indeed fixed.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Sat, Jun 29, 9:37 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (semi):
|    | Missing semicolon.
|----|    | /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Mirage.js
|    |++++| /mnt/data/jenkins-phabricator/workspace/differential/binaries/data/mods/public/simulation/components/Mirage.js
|  74|  74| 	this.classesList = clone(cmpIdentity.GetClassesList());
|  75|  75| };
|  76|  76| 
|  77|    |-Mirage.prototype.GetClassesList = function() { return this.classesList };
|    |  77|+Mirage.prototype.GetClassesList = function() { return this.classesList; };
|  78|  78| 
|  79|  79| // Foundation data
|  80|  80| 

binaries/data/mods/public/simulation/components/Mirage.js
|  77| Mirage.prototype.GetClassesList·=·function()·{·return·this.classesList·};
|    | [NORMAL] JSHintBear:
|    | Missing semicolon.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/differential/1846/display/redirect

This revision was not accepted when it landed; it landed in state Needs Review.Sat, Jun 29, 9:43 PM
This revision was automatically updated to reflect the committed changes.