Page MenuHomeWildfire Games

Update wxWidgets readme [VS2013 -> VS2015]
AcceptedPublic

Authored by Angen on Sun, Jun 30, 7:00 PM.

Details

Reviewers
Itms
asterix
Summary

We are moving to VS2015 so update readme for wxWidgets to reflect changes

Test Plan

Check version of vs and wxWidgets is correct to reflect changes

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8392
Build 13708: Vulcan BuildJenkins
Build 13707: arc lint + arc unit

Event Timeline

Angen created this revision.Sun, Jun 30, 7:00 PM
Owners added a subscriber: Restricted Owners Package.Sun, Jun 30, 7:00 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1856/display/redirect

asterix accepted this revision.Sun, Jun 30, 7:58 PM
asterix added a subscriber: asterix.

Wording and grammar are correct, it looks immediately commitable to me.

This revision is now accepted and ready to land.Sun, Jun 30, 7:58 PM
vladislavbelov added inline comments.
libraries/win32/wxwidgets/README.txt
3–4

At least 3.0.4, not only?

Angen updated this revision to Diff 8928.Tue, Jul 16, 1:50 PM

at least

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/94/display/redirect

Why 3.0.4 in particular? I've built against 3.0.2 and it works (see also #2891, not sure which version the autobuilder currently uses -- it was 3.0.2 back then). We could simply say "the latest stable release", or something like that.

historic_bruno added a comment.EditedTue, Jul 16, 9:08 PM

Ah, thanks! :) That makes sense then.

Although I would note that we can't count on 3.0.4 features/fixes being available on all OSes (some only package 3.0.2), which might be misleading for developers.

It does make sense to have all Windows builds using the same wxWidgets version by default though.