Page MenuHomeWildfire Games

Update wxWidgets readme [VS2013 -> VS2015]
ClosedPublic

Authored by Angen on Jun 30 2019, 7:00 PM.

Details

Summary

We are moving to VS2015 so update readme for wxWidgets to reflect changes

Test Plan

Check version of vs and wxWidgets is correct to reflect changes

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Angen created this revision.Jun 30 2019, 7:00 PM
Owners added a subscriber: Restricted Owners Package.Jun 30 2019, 7:00 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1856/display/redirect

asterix accepted this revision.Jun 30 2019, 7:58 PM
asterix added a subscriber: asterix.

Wording and grammar are correct, it looks immediately commitable to me.

This revision is now accepted and ready to land.Jun 30 2019, 7:58 PM
vladislavbelov added inline comments.
libraries/win32/wxwidgets/README.txt
3 ↗(On Diff #8660)

At least 3.0.4, not only?

Angen updated this revision to Diff 8928.Jul 16 2019, 1:50 PM

at least

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/94/display/redirect

Why 3.0.4 in particular? I've built against 3.0.2 and it works (see also #2891, not sure which version the autobuilder currently uses -- it was 3.0.2 back then). We could simply say "the latest stable release", or something like that.

historic_bruno added a comment.EditedJul 16 2019, 9:08 PM

Ah, thanks! :) That makes sense then.

Although I would note that we can't count on 3.0.4 features/fixes being available on all OSes (some only package 3.0.2), which might be misleading for developers.

It does make sense to have all Windows builds using the same wxWidgets version by default though.

historic_bruno requested changes to this revision.Jul 17 2019, 5:16 PM
historic_bruno added inline comments.
libraries/win32/wxwidgets/README.txt
3 ↗(On Diff #8660)

wxWidgets 3.0.4 doesn't include a wx_vc14.sln. At least the one I downloaded here:

"E:\devel\wxWidgets-3.0.4\build\msw\wx_vc8.sln"
"E:\devel\wxWidgets-3.0.4\build\msw\wx_vc9.sln"
"E:\devel\wxWidgets-3.0.4\build\msw\wx_vc10.sln"
"E:\devel\wxWidgets-3.0.4\build\msw\wx_vc11.sln"
"E:\devel\wxWidgets-3.0.4\build\msw\wx_vc12.sln"
"E:\devel\wxWidgets-3.0.4\build\msw\wx_vc7.sln"
This revision now requires changes to proceed.Jul 17 2019, 5:16 PM
Angen added a comment.Jul 17 2019, 6:38 PM

@Itms whit which version did you build wxWidgets 3.0.4 ?

Itms added a comment.Jul 17 2019, 6:52 PM

I used the latest one (probably vc12) with the compiler I wanted to build the game with. Recent versions of visual studio can open slightly older solutions without issue 🙂

Sorry, I should have seen this revision earlier.

In D2030#87141, @Itms wrote:

I used the latest one (probably vc12) with the compiler I wanted to build the game with. Recent versions of visual studio can open slightly older solutions without issue 🙂
Sorry, I should have seen this revision earlier.

Indeed VS 2015 build works fine with upgraded wx_vc12.sln.

(wxWidgets 3.1.2 (unstable/dev) on the other hand does include wx_vc14.sln, so I'm sure 3.2 (stable) will:)

"E:\devel\wxWidgets-3.1.2\build\msw\wx_vc8.sln"
"E:\devel\wxWidgets-3.1.2\build\msw\wx_vc9.sln"
"E:\devel\wxWidgets-3.1.2\build\msw\wx_vc10.sln"
"E:\devel\wxWidgets-3.1.2\build\msw\wx_vc11.sln"
"E:\devel\wxWidgets-3.1.2\build\msw\wx_vc12.sln"
"E:\devel\wxWidgets-3.1.2\build\msw\wx_vc14.sln"
"E:\devel\wxWidgets-3.1.2\build\msw\wx_vc15.sln"
"E:\devel\wxWidgets-3.1.2\build\msw\wx_vc7.sln"
Angen updated this revision to Diff 8957.Jul 17 2019, 7:03 PM

revert wxw sln version

historic_bruno accepted this revision.Jul 17 2019, 7:04 PM
This revision is now accepted and ready to land.Jul 17 2019, 7:04 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/116/display/redirect

This revision was automatically updated to reflect the committed changes.