Page MenuHomeWildfire Games

hellenic_royal_stoa → stoa
ClosedPublic

Authored by Nescio on Jul 3 2019, 6:33 PM.

Details

Reviewers
wraitii
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rP22770: Common template name change: hellenic_royal_stoa → stoa
Summary

This patch moves template_structure_civic_hellenic_royal_stoa.xml to simply template_structure_civic_stoa.xml and updates its children's parent accordingly.
Not only was the old name unnecessary long, but also potentially misleading: stoas are Greek, but not necessary royal, and there are no other stoas in game. Just “stoa” is clearer, more correct, and more consistent with other template_structure_*.xml names.

Test Plan

Ought to be uncontroversial.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8171
Build 13316: Vulcan BuildJenkins
Build 13309: arc lint + arc unit

Event Timeline

Nescio created this revision.Jul 3 2019, 6:33 PM
Vulcan added a comment.Jul 3 2019, 7:02 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/differential/1888/display/redirect

Nescio added a reviewer: Restricted Owners Package.Jul 6 2019, 5:32 PM
wraitii accepted this revision.Aug 24 2019, 10:57 AM

Yup.

Complete.

This revision is now accepted and ready to land.Aug 24 2019, 10:57 AM
This revision was automatically updated to reflect the committed changes.