There was a ToDo in Formation.js to let the function actually return some kind of primary member.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
Currently the code is not called, but that does not mean it will never ;)
- Add this.PlaySound(...) to a formation order in UnitAI.
- Combine several entities into a formation.
- Give the above mentioned order to the formation.
- Verify that the correct sound is played (that of the "most important" entity).
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Branch
- /ps/trunk
- Lint
Lint OK - Unit
No Unit Test Coverage - Build Status
Buildable 8280 Build 13508: Vulcan Build Jenkins Build 13507: arc lint + arc unit
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/21/display/redirect
Comment Actions
I am not so sure whether this is any less arbitrary. In other games, the primary member seems to be the bulk of the army. That doesn’t necessarily mean numerically.
(Just a random thought, do what the reviewer says and you will be good)
Comment Actions
First we should have use-case and then implement what is needed, no other side around. Without having clear use-case we cannot know what we need to implement in the function.