Differential D2063
Unit motion - Check the return value of ComputeGoal and handle failure cases Authored by wraitii on Jul 12 2019, 4:06 PM.
Details
As reported by @Freagarach on #5496, there can be broken behaviour as UnitMotion::PathResult may call RequestLongPath with a garbage path goal when ComputeGoal fails. This checks the return value everywhere and reacts accordingly in case of failure, to prevent such issues. Notice that the commands.txt in 5496 no longer crash.
Diff Detail
Event TimelineComment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/36/display/redirect Comment Actions Build failure - The Moirai have given mortals hearts that can endure. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/37/display/redirect Comment Actions Successful build - Chance fights ever on the side of the prudent. Link to build: https://jenkins.wildfiregames.com/job/docker-differential/40/display/redirect Comment Actions The two replays don't crash anymore for me, but I didn't check whether this is a false positive (since the replays don't store hashes) |