Superfluous call; lobby bots decide when to send gameLists (also reduces overhead).
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
The change is correct, because XPartaMupp.py sends the gamelist to clients who just joined in L238 regardless.
This has been the last call to SendGetGameList from JS and C++ and we likely don't have any valid use case for this anymore.
Adding a comment to XmppClient::SendIqGetGameList that this is unused but still supported (XpartaMupp.py L283) might be a possibility, but that sounds like it will be forgotton to be updated with the next patch.
Comment Actions
Build is green
Updating workspaces. Build (release)... Build (debug)... Running release tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK! Running debug tests... Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
http://jw:8080/job/phabricator/494/ for more details.