Page MenuHomeWildfire Games

Fix undefined behaviour introduced in rP22473

Authored by wraitii on Jul 15 2019, 7:17 PM.


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
rP22483: Fix undefined behaviour introduced in rP22473
Trac Tickets

rP22473 introduces undefined behaviour: for vertices that are part of non-AA squares, the value of "quadOutward" is undefined.
I noticed a somewhat similar issue earlier in D1908 and fixed it, but I failed to noticed this one.

Test Plan

Run MP games locally, replay them and notice that it no longer OOS-es

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Jul 15 2019, 7:17 PM
wraitii updated the Trac tickets for this revision.

Successful build - Chance fights ever on the side of the prudent.

Link to build:

elexis accepted this revision.Jul 15 2019, 7:53 PM
elexis added a subscriber: elexis.

After applying this patch, my visual replay and nonvisual replay mode hashes match again.

This revision is now accepted and ready to land.Jul 15 2019, 7:53 PM
This revision was automatically updated to reflect the committed changes.