Differential D2082

Fix undefined behaviour introduced in rP22473
ClosedPublic
Actions

Authored by wraitii on Jul 15 2019, 7:17 PM.

Details

Reviewers

elexis

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rP22483: Fix undefined behaviour introduced in rP22473

Trac Tickets

#5508

Summary

rP22473 introduces undefined behaviour: for vertices that are part of non-AA squares, the value of "quadOutward" is undefined.
I noticed a somewhat similar issue earlier in D1908 and fixed it, but I failed to noticed this one.

Test Plan

Run MP games locally, replay them and notice that it no longer OOS-es

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

temp

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 8381
Build 13691: Vulcan Build	Jenkins
Build 13690: arc lint + arc unit

Event Timeline

wraitii created this revision.Jul 15 2019, 7:17 PM

wraitii updated the Trac tickets for this revision.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/89/display/redirect

Harbormaster completed remote builds in B8381: Diff 8915.Jul 15 2019, 7:22 PM

After applying this patch, my visual replay and nonvisual replay mode hashes match again.

This revision is now accepted and ready to land.Jul 15 2019, 7:53 PM

Closed by commit rP22483: Fix undefined behaviour introduced in rP22473 (authored by wraitii). · Explain WhyJul 15 2019, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

simulation2/

helpers/

VertexPathfinder.cpp

1 line

Diff 8915

View Options

source/simulation2/helpers/VertexPathfinder.cpp

Fix undefined behaviour introduced in rP22473ClosedPublicActions