As mentioned by @bb (here) there are some schema's duplicated in Attack.js and DeathDamage.js (and in the future maybe in ProximityDamage.js; D1838), which could be moved to a seperate helper.
Currently moved:
- Status effects (introduced in rP22304)
- Bonuses (introduced in rP10804)
Preferred classes (introduced in rP11710)Restricted classes (introduced in rP11710)
The reason that the bonus schema was duplicated was that it was first only called from Attack.js itself, but with the introduction of DeathDamage.js (rP19950) it was copy-pastad to that file as well. In the future, we probably want to support status effects for death damage as well.
With that in mind the move is even more logical.