I believe a c_str() is missing in rP22558.
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths)
- rP22561: Fix rP22558 - clang-specific error at compilation time
Compile on clang
Thanks for the catch and patch.
(I was wondering whether these statements in MapGenerator.cpp had it also missing, as I most often saw it with c_str, but apparently that uses fmt::sprintf supporting strings (source/third_party/cppformat/):
16187 philip LOGMESSAGE("Loading RMS '%s'", m_ScriptPath.string8());
16187 philip LOGERROR("CMapGeneratorWorker::Run: Failed to load RMS '%s'", m_ScriptPath.string8());
22466 elexis LOGERROR("Could not load heightmap file '%s'", filename.string8());