I believe a c_str() is missing in rP22558.
Details
Details
- Reviewers
elexis - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rP22561: Fix rP22558 - clang-specific error at compilation time
Compile on clang
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Link to build: https://jenkins.wildfiregames.com/job/docker-differential/246/display/redirect
Comment Actions
Thanks for the catch and patch.
(I was wondering whether these statements in MapGenerator.cpp had it also missing, as I most often saw it with c_str, but apparently that uses fmt::sprintf supporting strings (source/third_party/cppformat/):
16187 philip LOGMESSAGE("Loading RMS '%s'", m_ScriptPath.string8());
16187 philip LOGERROR("CMapGeneratorWorker::Run: Failed to load RMS '%s'", m_ScriptPath.string8());
22466 elexis LOGERROR("Could not load heightmap file '%s'", filename.string8());
)