Page MenuHomeWildfire Games

Diplomacy page hotkey

Authored by elexis on Jul 27 2019, 10:58 PM.



As requested by minohaka, it would be handy to open the diplomacy page using a hotkey.

Test Plan

Possibly find a better key combination. Possibly argue about the hotkey assignment being better placed in button_diplomacy.xml.

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Jul 27 2019, 10:58 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build:

Idea by minohaka

20:44 < minohaka> Is there a shortcut for opening the diplomacy modal/window?

There are 4 buttons:
objectives, diplomacy, trade & barter, gamespeed.

3 of them open dialogs, so I add it for objectives as well.

The gamespeed button however doesn't open a dialog, it only unhides a dropdown.

But if there should be hotkeys to interact with the gamespeed, it seems preferable if there is a hotkey to increase gamespeed and a hotkey to decrease it.

Until then such a gamespeed dropdown visibility trigger hotkey seems like incomplete work to me, i.e. work for an independent diff.

Also tooltips should display the hotkeys.

And will be updated.

Also we can avoid misc.xml and insert the hotkey in place.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 12 2019, 12:54 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Aug 12 2019, 12:54 PM