Page MenuHomeWildfire Games

Diplomacy page hotkey
ClosedPublic

Authored by elexis on Sat, Jul 27, 10:58 PM.

Details

Summary

As requested by minohaka, it would be handy to open the diplomacy page using a hotkey.

Test Plan

Possibly find a better key combination. Possibly argue about the hotkey assignment being better placed in button_diplomacy.xml.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Sat, Jul 27, 10:58 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/249/display/redirect

Idea by minohaka
http://irclogs.wildfiregames.com/2019-07/2019-07-27-QuakeNet-%230ad-dev.log

20:44 < minohaka> Is there a shortcut for opening the diplomacy modal/window?

There are 4 buttons:
objectives, diplomacy, trade & barter, gamespeed.

3 of them open dialogs, so I add it for objectives as well.

The gamespeed button however doesn't open a dialog, it only unhides a dropdown.

But if there should be hotkeys to interact with the gamespeed, it seems preferable if there is a hotkey to increase gamespeed and a hotkey to decrease it.

Until then such a gamespeed dropdown visibility trigger hotkey seems like incomplete work to me, i.e. work for an independent diff.

Also tooltips should display the hotkeys.

And https://trac.wildfiregames.com/wiki/HotKeys will be updated.

Also we can avoid misc.xml and insert the hotkey in place.

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Aug 12, 12:54 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Mon, Aug 12, 12:54 PM