Differential D2148

Fix no-pch build following renderer options refactoring rP22610
ClosedPublic
Actions

Authored by wraitii on Aug 4 2019, 9:30 PM.

Details

Reviewers

elexis

Commits

rP22612: Fix no-pch build following renderer options refactoring rP22610

Summary

LOGWARNING requires CLogger following

See refactoring of renderer options in rP22610.

Test Plan

Compile without precompiled headers.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

temp

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 8736
Build 14314: Vulcan Build	Jenkins
Build 14313: arc lint + arc unit

Event Timeline

wraitii created this revision.Aug 4 2019, 9:30 PM

Owners added a subscriber: Restricted Owners Package.Aug 4 2019, 9:30 PM

Build failure - The Moirai have given mortals hearts that can endure.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/308/display/redirect

Harbormaster failed remote builds in B8736: Diff 9225!Aug 4 2019, 9:32 PM

The inclusion is correct, just not in alphabetic order.

Seems like this file is in reverse alphebtic order, so the insertion is consistent :P

(One can be lazy and copy&paste headers to https://alphabetizer.flap.tv/)

Also newline for `RenderingOptions.h, so that it stands out as the header of the current file, see https://trac.wildfiregames.com/wiki/Coding_Conventions#Preprocessorinstructions

This revision is now accepted and ready to land.Aug 4 2019, 9:37 PM

elexis retitled this revision from Fix no-pch build following rP22610 to Fix no-pch build following renderer options refactoring rP22610.Aug 4 2019, 9:40 PM

elexis edited the summary of this revision. (Show Details)

Our sorting is case-insensitive so the file was actually ordered correctly before. Will fix when committing.

This revision was landed with ongoing or failed builds.Aug 4 2019, 10:08 PM

Closed by commit rP22612: Fix no-pch build following renderer options refactoring rP22610 (authored by wraitii). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

renderer/

RenderingOptions.cpp

1 line

Diff 9225

View Options

source/renderer/RenderingOptions.cpp

Fix no-pch build following renderer options refactoring rP22610ClosedPublicActions