Move handleKick below init following 19250
ClosedPublic
Actions

Authored by elexis on Mar 12 2017, 5:09 PM.

Details

Reviewers

Summary

In D116 we added a new function handleKick with rP19250, but we added it above the init function which should always stay the first function.
This patch moves it below returnToMainMenu and initGameFilters which are called from init and below the other related filter functions,
above updateSubject which is called from that array too which calls handleKick.

JSdoc still seems unneeded.

Test Plan

Make sure each character remains the same.

Diff Detail

Repository

rP 0 A.D. Public Repository

Branch

/ps/trunk

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 745
Build 1183: Vulcan Build	Jenkins
Build 1182: arc lint + arc unit

Event Timeline

elexis created this revision.Mar 12 2017, 5:09 PM

Imarok accepted this revision.Mar 12 2017, 5:11 PM

This revision is now accepted and ready to land.Mar 12 2017, 5:11 PM

Build is green

Updating workspaces.
Build (release)...
Build (debug)...
Running release tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!
Running debug tests...
Running cxxtest tests (302 tests)..............................................................................................................................................................................................................................................................................................................OK!

http://jw:8080/job/phabricator/509/ for more details.

Harbormaster completed remote builds in B745: Diff 782.Mar 12 2017, 5:53 PM

Fixed by rP19291