Upgrade into a %(name)s → Upgrade to %(name)s
ClosedPublic
Actions

Authored by Gallaecio on Aug 10 2019, 12:00 PM.

Details

Reviewers

Nescio
elexis
Itms
Stan

Commits

rP22685: Upgrade into a %(name)s → Upgrade to %(name)s

Summary

Reported by kingu in Transifex: “Pretty sure genders come into play here and with 142”

I think the English string change makes gender less of an issue for most languages.

Test Plan

Only affects user-visible strings.

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gallaecio created this revision.Aug 10 2019, 12:00 PM

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (space-before-function-paren):
|    | Unexpected space before function parentheses.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/selection_panels.js
| 763| 763| 				addResearchToQueue(data.item.researchFacilityId, t);
| 764| 764| 			})(tech);
| 765| 765| 
| 766|    |-			button.onPressRight = (t => function () {
|    | 766|+			button.onPressRight = (t => function() {
| 767| 767| 				showTemplateDetails(
| 768| 768| 					t,
| 769| 769| 					GetTemplateData(data.unitEntStates.find(state => state.id == data.item.researchFacilityId).template).nativeCiv);

binaries/data/mods/public/gui/session/selection_panels.js
|  48| »   »   »   switch·(data.item)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/selection_panels.js
|  59| »   »   switch·(data.item)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/selection_panels.js
| 731| »   »   »   »   »   »   switch·(entity.check)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/349/display/redirect

Harbormaster completed remote builds in B8799: Diff 9283.Aug 10 2019, 12:04 PM

Nescio accepted this revision.Aug 10 2019, 7:06 PM

This revision is now accepted and ready to land.Aug 10 2019, 7:06 PM

Gallaecio added reviewers: Itms, Stan.Aug 16 2019, 9:39 PM

Closed by commit rP22685: Upgrade into a %(name)s → Upgrade to %(name)s (authored by Gallaecio). · Explain WhyAug 18 2019, 3:03 PM

This revision was automatically updated to reflect the committed changes.

Gallaecio added a commit: rP22685: Upgrade into a %(name)s → Upgrade to %(name)s.

Owners added a subscriber: Restricted Owners Package.Aug 18 2019, 3:03 PM