Page MenuHomeWildfire Games


Authored by elexis on Aug 11 2019, 10:15 PM.


Summary and premake5.lua were missing in D1510 / rP22627.

Test Plan

Go through the list of files of the project again.

Diff Detail

rP 0 A.D. Public Repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

elexis created this revision.Aug 11 2019, 10:15 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build:

  • The flag was introduced in rP10534, all files touched in that commit are addressed.
  • source/tools/dist/0ad.nsi and source/tools/dist/ don't need a change
  • extern_libs5.lua,, had been updated correctly
  • found source/nvtt/patches/arm64-fix.patch having an empty hunk for libraries/source/spidermonkey/mozjs-31.2.0.rc0.tar.bz2 from rP16872, but it looks like it's ignored when applying. NVTT needs some attention anyhow I suppose.
  • still had old mozjs shared libraries around: source/spidermonkey/lib/,
  • Checked all folders that contains one of the files touched in that commit or mentioned here. In particular build/, grep for spider -i and mozjs.
  • Found an unrevisioned in my osx/ folder, it seems to come from D1483 which I don't recollect applying. As it's not a revisioned file, it shouldn't be an issue. The header is the same as in
  • dehydra/printf-type-check.js also has something hardcoded about SpiderMonkey, but doesn't seem to need an update:
// SpiderMonkey:
if (name == 'JS_ReportError')
    return ['a', 'printf', 2, 3];
else if (name == 'JS_ReportWarning')
    return ['a', 'printf', 2, 3];

but should be remembered in case those two functions change.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 13 2019, 1:30 PM
This revision was automatically updated to reflect the committed changes.
Owners added a subscriber: Restricted Owners Package.Aug 13 2019, 1:30 PM