Page MenuHomeWildfire Games

Handle orderone hotkey also for construct buildings and walls
Needs ReviewPublic

Authored by luiko on Aug 12 2019, 9:28 AM.

Details

Reviewers
None
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Summary

When using the "order one" hotkey I tried and failed to build many houses when I was running low in population capacity very useful in some civilization like Ptolemies.

I notice the walls set apart to buildings in the code so I also add those.

Test Plan

Select a group of units then try to place buildings and walls with alt pressed, you can use shift(queue hotkey) to spam buildings but the unit will queue the order which is fine

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 8816
Build 14459: Vulcan BuildJenkins

Event Timeline

luiko created this revision.Aug 12 2019, 9:28 AM
luiko retitled this revision from Handle hotkey orderone also for construct buildings and walls to Handle orderone hotkey also for construct buildings and walls.

Successful build - Chance fights ever on the side of the prudent.

Linter detected issues:
Executing section Source...
Executing section JS...
|    | [NORMAL] ESLintBear (space-unary-ops):
|    | Unary word operator 'typeof' must be followed by whitespace.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 326| 326| 	}
| 327| 327| 
| 328| 328| 	var wallPlacementInfo = updateBuildingPlacementPreview(); // entities making up the wall (wall segments, towers, ...)
| 329|    |-	if (!(wallPlacementInfo === false || typeof(wallPlacementInfo) === "object"))
|    | 329|+	if (!(wallPlacementInfo === false || typeof (wallPlacementInfo) === "object"))
| 330| 330| 	{
| 331| 331| 		error("Invalid updateBuildingPlacementPreview return value: " + uneval(wallPlacementInfo));
| 332| 332| 		return false;
|    | [NORMAL] ESLintBear (operator-linebreak):
|    | '&&' should be placed at the end of the line.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 497| 497| 	mouseIsOverObject = (hoveredObject != null);
| 498| 498| 
| 499| 499| 	// Close the menu when interacting with the game world
| 500|    |-	if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown")
| 501|    |-		&& (ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT))
|    | 500|+	if (!mouseIsOverObject && (ev.type =="mousebuttonup" || ev.type == "mousebuttondown") &&
|    | 501|+		(ev.button == SDL_BUTTON_LEFT || ev.button == SDL_BUTTON_RIGHT))
| 502| 502| 		closeMenu();
| 503| 503| 
| 504| 504| 	// State-machine processing:
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 3.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 658| 658| 		// user to continue building walls.
| 659| 659| 		switch (ev.type)
| 660| 660| 		{
| 661|    |-			case "mousemotion":
|    | 661|+		case "mousemotion":
| 662| 662| 				placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
| 663| 663| 
| 664| 664| 				// Update the building placement preview, and by extension, the list of snapping candidate entities for both (!)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 659| 659| 		switch (ev.type)
| 660| 660| 		{
| 661| 661| 			case "mousemotion":
| 662|    |-				placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
|    | 662|+			placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
| 663| 663| 
| 664| 664| 				// Update the building placement preview, and by extension, the list of snapping candidate entities for both (!)
| 665| 665| 				// the ending point and the starting point to snap to.
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 661| 661| 			case "mousemotion":
| 662| 662| 				placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
| 663| 663| 
| 664|    |-				// Update the building placement preview, and by extension, the list of snapping candidate entities for both (!)
|    | 664|+			// Update the building placement preview, and by extension, the list of snapping candidate entities for both (!)
| 665| 665| 				// the ending point and the starting point to snap to.
| 666| 666| 				//
| 667| 667| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 662| 662| 				placementSupport.wallEndPosition = Engine.GetTerrainAtScreenPoint(ev.x, ev.y);
| 663| 663| 
| 664| 664| 				// Update the building placement preview, and by extension, the list of snapping candidate entities for both (!)
| 665|    |-				// the ending point and the starting point to snap to.
|    | 665|+			// the ending point and the starting point to snap to.
| 666| 666| 				//
| 667| 667| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 668| 668| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 663| 663| 
| 664| 664| 				// Update the building placement preview, and by extension, the list of snapping candidate entities for both (!)
| 665| 665| 				// the ending point and the starting point to snap to.
| 666|    |-				//
|    | 666|+			//
| 667| 667| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 668| 668| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 669| 669| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 664| 664| 				// Update the building placement preview, and by extension, the list of snapping candidate entities for both (!)
| 665| 665| 				// the ending point and the starting point to snap to.
| 666| 666| 				//
| 667|    |-				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
|    | 667|+			// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 668| 668| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 669| 669| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 670| 670| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 665| 665| 				// the ending point and the starting point to snap to.
| 666| 666| 				//
| 667| 667| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 668|    |-				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
|    | 668|+			// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 669| 669| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 670| 670| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 671| 671| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 666| 666| 				//
| 667| 667| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 668| 668| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 669|    |-				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
|    | 669|+			// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 670| 670| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 671| 671| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 672| 672| 				// points.
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 667| 667| 				// TODO: Note that here, we need to fetch all similar entities, including any offscreen ones, to support the case
| 668| 668| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 669| 669| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 670|    |-				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
|    | 670|+			// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 671| 671| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 672| 672| 				// points.
| 673| 673| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 668| 668| 				// where the snap entity for the starting point has moved offscreen, or has been deleted/destroyed, or was a
| 669| 669| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 670| 670| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 671|    |-				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
|    | 671|+			// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 672| 672| 				// points.
| 673| 673| 
| 674| 674| 				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 669| 669| 				// foundation and has been replaced with a completed entity since the user first chose it. Fetching all towers on
| 670| 670| 				// the entire map instead of only the current screen might get expensive fast since walls all have a ton of towers
| 671| 671| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 672|    |-				// points.
|    | 672|+			// points.
| 673| 673| 
| 674| 674| 				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
| 675| 675| 				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 671| 671| 				// in them. Might be useful to query only for entities within a certain range around the starting point and ending
| 672| 672| 				// points.
| 673| 673| 
| 674|    |-				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
|    | 674|+			placementSupport.wallSnapEntitiesIncludeOffscreen = true;
| 675| 675| 				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
| 676| 676| 
| 677| 677| 				if (result && result.cost)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 672| 672| 				// points.
| 673| 673| 
| 674| 674| 				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
| 675|    |-				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
|    | 675|+			var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
| 676| 676| 
| 677| 677| 				if (result && result.cost)
| 678| 678| 				{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 674| 674| 				placementSupport.wallSnapEntitiesIncludeOffscreen = true;
| 675| 675| 				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
| 676| 676| 
| 677|    |-				if (result && result.cost)
|    | 677|+			if (result && result.cost)
| 678| 678| 				{
| 679| 679| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 680| 680| 					placementSupport.tooltipMessage = [
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 675| 675| 				var result = updateBuildingPlacementPreview(); // includes an update of the snap entity candidates
| 676| 676| 
| 677| 677| 				if (result && result.cost)
| 678|    |-				{
|    | 678|+			{
| 679| 679| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 680| 680| 					placementSupport.tooltipMessage = [
| 681| 681| 						getEntityCostTooltip(result),
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 676| 676| 
| 677| 677| 				if (result && result.cost)
| 678| 678| 				{
| 679|    |-					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
|    | 679|+				var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 680| 680| 					placementSupport.tooltipMessage = [
| 681| 681| 						getEntityCostTooltip(result),
| 682| 682| 						getNeededResourcesTooltip(neededResources)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 677| 677| 				if (result && result.cost)
| 678| 678| 				{
| 679| 679| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 680|    |-					placementSupport.tooltipMessage = [
|    | 680|+				placementSupport.tooltipMessage = [
| 681| 681| 						getEntityCostTooltip(result),
| 682| 682| 						getNeededResourcesTooltip(neededResources)
| 683| 683| 					].filter(tip => tip).join("\n");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 678| 678| 				{
| 679| 679| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 680| 680| 					placementSupport.tooltipMessage = [
| 681|    |-						getEntityCostTooltip(result),
|    | 681|+					getEntityCostTooltip(result),
| 682| 682| 						getNeededResourcesTooltip(neededResources)
| 683| 683| 					].filter(tip => tip).join("\n");
| 684| 684| 				}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 679| 679| 					var neededResources = Engine.GuiInterfaceCall("GetNeededResources", { "cost": result.cost });
| 680| 680| 					placementSupport.tooltipMessage = [
| 681| 681| 						getEntityCostTooltip(result),
| 682|    |-						getNeededResourcesTooltip(neededResources)
|    | 682|+					getNeededResourcesTooltip(neededResources)
| 683| 683| 					].filter(tip => tip).join("\n");
| 684| 684| 				}
| 685| 685| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 680| 680| 					placementSupport.tooltipMessage = [
| 681| 681| 						getEntityCostTooltip(result),
| 682| 682| 						getNeededResourcesTooltip(neededResources)
| 683|    |-					].filter(tip => tip).join("\n");
|    | 683|+				].filter(tip => tip).join("\n");
| 684| 684| 				}
| 685| 685| 
| 686| 686| 				break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 681| 681| 						getEntityCostTooltip(result),
| 682| 682| 						getNeededResourcesTooltip(neededResources)
| 683| 683| 					].filter(tip => tip).join("\n");
| 684|    |-				}
|    | 684|+			}
| 685| 685| 
| 686| 686| 				break;
| 687| 687| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 683| 683| 					].filter(tip => tip).join("\n");
| 684| 684| 				}
| 685| 685| 
| 686|    |-				break;
|    | 686|+			break;
| 687| 687| 
| 688| 688| 			case "mousebuttondown":
| 689| 689| 				if (ev.button == SDL_BUTTON_LEFT)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 2 tabs but found 3.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 685| 685| 
| 686| 686| 				break;
| 687| 687| 
| 688|    |-			case "mousebuttondown":
|    | 688|+		case "mousebuttondown":
| 689| 689| 				if (ev.button == SDL_BUTTON_LEFT)
| 690| 690| 				{
| 691| 691| 					var queued = Engine.HotkeyIsPressed("session.queue");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 686| 686| 				break;
| 687| 687| 
| 688| 688| 			case "mousebuttondown":
| 689|    |-				if (ev.button == SDL_BUTTON_LEFT)
|    | 689|+			if (ev.button == SDL_BUTTON_LEFT)
| 690| 690| 				{
| 691| 691| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 692| 692| 					if (tryPlaceWall(queued))
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 687| 687| 
| 688| 688| 			case "mousebuttondown":
| 689| 689| 				if (ev.button == SDL_BUTTON_LEFT)
| 690|    |-				{
|    | 690|+			{
| 691| 691| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 692| 692| 					if (tryPlaceWall(queued))
| 693| 693| 					{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 688| 688| 			case "mousebuttondown":
| 689| 689| 				if (ev.button == SDL_BUTTON_LEFT)
| 690| 690| 				{
| 691|    |-					var queued = Engine.HotkeyIsPressed("session.queue");
|    | 691|+				var queued = Engine.HotkeyIsPressed("session.queue");
| 692| 692| 					if (tryPlaceWall(queued))
| 693| 693| 					{
| 694| 694| 						if (queued)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 689| 689| 				if (ev.button == SDL_BUTTON_LEFT)
| 690| 690| 				{
| 691| 691| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 692|    |-					if (tryPlaceWall(queued))
|    | 692|+				if (tryPlaceWall(queued))
| 693| 693| 					{
| 694| 694| 						if (queued)
| 695| 695| 						{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 690| 690| 				{
| 691| 691| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 692| 692| 					if (tryPlaceWall(queued))
| 693|    |-					{
|    | 693|+				{
| 694| 694| 						if (queued)
| 695| 695| 						{
| 696| 696| 							// continue building, just set a new starting position where we left off
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 691| 691| 					var queued = Engine.HotkeyIsPressed("session.queue");
| 692| 692| 					if (tryPlaceWall(queued))
| 693| 693| 					{
| 694|    |-						if (queued)
|    | 694|+					if (queued)
| 695| 695| 						{
| 696| 696| 							// continue building, just set a new starting position where we left off
| 697| 697| 							placementSupport.position = placementSupport.wallEndPosition;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 692| 692| 					if (tryPlaceWall(queued))
| 693| 693| 					{
| 694| 694| 						if (queued)
| 695|    |-						{
|    | 695|+					{
| 696| 696| 							// continue building, just set a new starting position where we left off
| 697| 697| 							placementSupport.position = placementSupport.wallEndPosition;
| 698| 698| 							placementSupport.wallEndPosition = undefined;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 693| 693| 					{
| 694| 694| 						if (queued)
| 695| 695| 						{
| 696|    |-							// continue building, just set a new starting position where we left off
|    | 696|+						// continue building, just set a new starting position where we left off
| 697| 697| 							placementSupport.position = placementSupport.wallEndPosition;
| 698| 698| 							placementSupport.wallEndPosition = undefined;
| 699| 699| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 694| 694| 						if (queued)
| 695| 695| 						{
| 696| 696| 							// continue building, just set a new starting position where we left off
| 697|    |-							placementSupport.position = placementSupport.wallEndPosition;
|    | 697|+						placementSupport.position = placementSupport.wallEndPosition;
| 698| 698| 							placementSupport.wallEndPosition = undefined;
| 699| 699| 
| 700| 700| 							inputState = INPUT_BUILDING_WALL_CLICK;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 695| 695| 						{
| 696| 696| 							// continue building, just set a new starting position where we left off
| 697| 697| 							placementSupport.position = placementSupport.wallEndPosition;
| 698|    |-							placementSupport.wallEndPosition = undefined;
|    | 698|+						placementSupport.wallEndPosition = undefined;
| 699| 699| 
| 700| 700| 							inputState = INPUT_BUILDING_WALL_CLICK;
| 701| 701| 						}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 697| 697| 							placementSupport.position = placementSupport.wallEndPosition;
| 698| 698| 							placementSupport.wallEndPosition = undefined;
| 699| 699| 
| 700|    |-							inputState = INPUT_BUILDING_WALL_CLICK;
|    | 700|+						inputState = INPUT_BUILDING_WALL_CLICK;
| 701| 701| 						}
| 702| 702| 						else
| 703| 703| 						{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 698| 698| 							placementSupport.wallEndPosition = undefined;
| 699| 699| 
| 700| 700| 							inputState = INPUT_BUILDING_WALL_CLICK;
| 701|    |-						}
|    | 701|+					}
| 702| 702| 						else
| 703| 703| 						{
| 704| 704| 							placementSupport.Reset();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 699| 699| 
| 700| 700| 							inputState = INPUT_BUILDING_WALL_CLICK;
| 701| 701| 						}
| 702|    |-						else
|    | 702|+					else
| 703| 703| 						{
| 704| 704| 							placementSupport.Reset();
| 705| 705| 							inputState = INPUT_NORMAL;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 700| 700| 							inputState = INPUT_BUILDING_WALL_CLICK;
| 701| 701| 						}
| 702| 702| 						else
| 703|    |-						{
|    | 703|+					{
| 704| 704| 							placementSupport.Reset();
| 705| 705| 							inputState = INPUT_NORMAL;
| 706| 706| 						}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 701| 701| 						}
| 702| 702| 						else
| 703| 703| 						{
| 704|    |-							placementSupport.Reset();
|    | 704|+						placementSupport.Reset();
| 705| 705| 							inputState = INPUT_NORMAL;
| 706| 706| 						}
| 707| 707| 					}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 702| 702| 						else
| 703| 703| 						{
| 704| 704| 							placementSupport.Reset();
| 705|    |-							inputState = INPUT_NORMAL;
|    | 705|+						inputState = INPUT_NORMAL;
| 706| 706| 						}
| 707| 707| 					}
| 708| 708| 					else
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 703| 703| 						{
| 704| 704| 							placementSupport.Reset();
| 705| 705| 							inputState = INPUT_NORMAL;
| 706|    |-						}
|    | 706|+					}
| 707| 707| 					}
| 708| 708| 					else
| 709| 709| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 704| 704| 							placementSupport.Reset();
| 705| 705| 							inputState = INPUT_NORMAL;
| 706| 706| 						}
| 707|    |-					}
|    | 707|+				}
| 708| 708| 					else
| 709| 709| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 710| 710| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 705| 705| 							inputState = INPUT_NORMAL;
| 706| 706| 						}
| 707| 707| 					}
| 708|    |-					else
|    | 708|+				else
| 709| 709| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 710| 710| 
| 711| 711| 					updateBuildingPlacementPreview();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 706| 706| 						}
| 707| 707| 					}
| 708| 708| 					else
| 709|    |-						placementSupport.tooltipMessage = translate("Cannot build wall here!");
|    | 709|+					placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 710| 710| 
| 711| 711| 					updateBuildingPlacementPreview();
| 712| 712| 					return true;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 708| 708| 					else
| 709| 709| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 710| 710| 
| 711|    |-					updateBuildingPlacementPreview();
|    | 711|+				updateBuildingPlacementPreview();
| 712| 712| 					return true;
| 713| 713| 				}
| 714| 714| 				else if (ev.button == SDL_BUTTON_RIGHT)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 709| 709| 						placementSupport.tooltipMessage = translate("Cannot build wall here!");
| 710| 710| 
| 711| 711| 					updateBuildingPlacementPreview();
| 712|    |-					return true;
|    | 712|+				return true;
| 713| 713| 				}
| 714| 714| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 715| 715| 				{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 710| 710| 
| 711| 711| 					updateBuildingPlacementPreview();
| 712| 712| 					return true;
| 713|    |-				}
|    | 713|+			}
| 714| 714| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 715| 715| 				{
| 716| 716| 					// reset to normal input mode
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 711| 711| 					updateBuildingPlacementPreview();
| 712| 712| 					return true;
| 713| 713| 				}
| 714|    |-				else if (ev.button == SDL_BUTTON_RIGHT)
|    | 714|+			else if (ev.button == SDL_BUTTON_RIGHT)
| 715| 715| 				{
| 716| 716| 					// reset to normal input mode
| 717| 717| 					placementSupport.Reset();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 712| 712| 					return true;
| 713| 713| 				}
| 714| 714| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 715|    |-				{
|    | 715|+			{
| 716| 716| 					// reset to normal input mode
| 717| 717| 					placementSupport.Reset();
| 718| 718| 					updateBuildingPlacementPreview();
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 713| 713| 				}
| 714| 714| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 715| 715| 				{
| 716|    |-					// reset to normal input mode
|    | 716|+				// reset to normal input mode
| 717| 717| 					placementSupport.Reset();
| 718| 718| 					updateBuildingPlacementPreview();
| 719| 719| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 714| 714| 				else if (ev.button == SDL_BUTTON_RIGHT)
| 715| 715| 				{
| 716| 716| 					// reset to normal input mode
| 717|    |-					placementSupport.Reset();
|    | 717|+				placementSupport.Reset();
| 718| 718| 					updateBuildingPlacementPreview();
| 719| 719| 
| 720| 720| 					inputState = INPUT_NORMAL;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 715| 715| 				{
| 716| 716| 					// reset to normal input mode
| 717| 717| 					placementSupport.Reset();
| 718|    |-					updateBuildingPlacementPreview();
|    | 718|+				updateBuildingPlacementPreview();
| 719| 719| 
| 720| 720| 					inputState = INPUT_NORMAL;
| 721| 721| 					return true;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 717| 717| 					placementSupport.Reset();
| 718| 718| 					updateBuildingPlacementPreview();
| 719| 719| 
| 720|    |-					inputState = INPUT_NORMAL;
|    | 720|+				inputState = INPUT_NORMAL;
| 721| 721| 					return true;
| 722| 722| 				}
| 723| 723| 				break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 718| 718| 					updateBuildingPlacementPreview();
| 719| 719| 
| 720| 720| 					inputState = INPUT_NORMAL;
| 721|    |-					return true;
|    | 721|+				return true;
| 722| 722| 				}
| 723| 723| 				break;
| 724| 724| 		}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 719| 719| 
| 720| 720| 					inputState = INPUT_NORMAL;
| 721| 721| 					return true;
| 722|    |-				}
|    | 722|+			}
| 723| 723| 				break;
| 724| 724| 		}
| 725| 725| 		break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 720| 720| 					inputState = INPUT_NORMAL;
| 721| 721| 					return true;
| 722| 722| 				}
| 723|    |-				break;
|    | 723|+			break;
| 724| 724| 		}
| 725| 725| 		break;
| 726| 726| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 876| 876| 			break;
| 877| 877| 
| 878| 878| 		case "hotkeydown":
| 879|    |-				if (ev.hotkey.indexOf("selection.group.") == 0)
|    | 879|+			if (ev.hotkey.indexOf("selection.group.") == 0)
| 880| 880| 				{
| 881| 881| 					let now = Date.now();
| 882| 882| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 877| 877| 
| 878| 878| 		case "hotkeydown":
| 879| 879| 				if (ev.hotkey.indexOf("selection.group.") == 0)
| 880|    |-				{
|    | 880|+			{
| 881| 881| 					let now = Date.now();
| 882| 882| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 883| 883| 					{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 878| 878| 		case "hotkeydown":
| 879| 879| 				if (ev.hotkey.indexOf("selection.group.") == 0)
| 880| 880| 				{
| 881|    |-					let now = Date.now();
|    | 881|+				let now = Date.now();
| 882| 882| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 883| 883| 					{
| 884| 884| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 879| 879| 				if (ev.hotkey.indexOf("selection.group.") == 0)
| 880| 880| 				{
| 881| 881| 					let now = Date.now();
| 882|    |-					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
|    | 882|+				if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 883| 883| 					{
| 884| 884| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 885| 885| 						{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 880| 880| 				{
| 881| 881| 					let now = Date.now();
| 882| 882| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 883|    |-					{
|    | 883|+				{
| 884| 884| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 885| 885| 						{
| 886| 886| 							var sptr = ev.hotkey.split(".");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 881| 881| 					let now = Date.now();
| 882| 882| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 883| 883| 					{
| 884|    |-						if (ev.hotkey.indexOf("selection.group.select.") == 0)
|    | 884|+					if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 885| 885| 						{
| 886| 886| 							var sptr = ev.hotkey.split(".");
| 887| 887| 							performGroup("snap", sptr[3]);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 882| 882| 					if (now - doublePressTimer < doublePressTime && ev.hotkey == prevHotkey)
| 883| 883| 					{
| 884| 884| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 885|    |-						{
|    | 885|+					{
| 886| 886| 							var sptr = ev.hotkey.split(".");
| 887| 887| 							performGroup("snap", sptr[3]);
| 888| 888| 						}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 883| 883| 					{
| 884| 884| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 885| 885| 						{
| 886|    |-							var sptr = ev.hotkey.split(".");
|    | 886|+						var sptr = ev.hotkey.split(".");
| 887| 887| 							performGroup("snap", sptr[3]);
| 888| 888| 						}
| 889| 889| 					}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 6 tabs but found 7.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 884| 884| 						if (ev.hotkey.indexOf("selection.group.select.") == 0)
| 885| 885| 						{
| 886| 886| 							var sptr = ev.hotkey.split(".");
| 887|    |-							performGroup("snap", sptr[3]);
|    | 887|+						performGroup("snap", sptr[3]);
| 888| 888| 						}
| 889| 889| 					}
| 890| 890| 					else
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 885| 885| 						{
| 886| 886| 							var sptr = ev.hotkey.split(".");
| 887| 887| 							performGroup("snap", sptr[3]);
| 888|    |-						}
|    | 888|+					}
| 889| 889| 					}
| 890| 890| 					else
| 891| 891| 					{
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 886| 886| 							var sptr = ev.hotkey.split(".");
| 887| 887| 							performGroup("snap", sptr[3]);
| 888| 888| 						}
| 889|    |-					}
|    | 889|+				}
| 890| 890| 					else
| 891| 891| 					{
| 892| 892| 						var sptr = ev.hotkey.split(".");
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 887| 887| 							performGroup("snap", sptr[3]);
| 888| 888| 						}
| 889| 889| 					}
| 890|    |-					else
|    | 890|+				else
| 891| 891| 					{
| 892| 892| 						var sptr = ev.hotkey.split(".");
| 893| 893| 						performGroup(sptr[2], sptr[3]);
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 888| 888| 						}
| 889| 889| 					}
| 890| 890| 					else
| 891|    |-					{
|    | 891|+				{
| 892| 892| 						var sptr = ev.hotkey.split(".");
| 893| 893| 						performGroup(sptr[2], sptr[3]);
| 894| 894| 
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 889| 889| 					}
| 890| 890| 					else
| 891| 891| 					{
| 892|    |-						var sptr = ev.hotkey.split(".");
|    | 892|+					var sptr = ev.hotkey.split(".");
| 893| 893| 						performGroup(sptr[2], sptr[3]);
| 894| 894| 
| 895| 895| 						doublePressTimer = now;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 890| 890| 					else
| 891| 891| 					{
| 892| 892| 						var sptr = ev.hotkey.split(".");
| 893|    |-						performGroup(sptr[2], sptr[3]);
|    | 893|+					performGroup(sptr[2], sptr[3]);
| 894| 894| 
| 895| 895| 						doublePressTimer = now;
| 896| 896| 						prevHotkey = ev.hotkey;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 892| 892| 						var sptr = ev.hotkey.split(".");
| 893| 893| 						performGroup(sptr[2], sptr[3]);
| 894| 894| 
| 895|    |-						doublePressTimer = now;
|    | 895|+					doublePressTimer = now;
| 896| 896| 						prevHotkey = ev.hotkey;
| 897| 897| 					}
| 898| 898| 				}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 5 tabs but found 6.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 893| 893| 						performGroup(sptr[2], sptr[3]);
| 894| 894| 
| 895| 895| 						doublePressTimer = now;
| 896|    |-						prevHotkey = ev.hotkey;
|    | 896|+					prevHotkey = ev.hotkey;
| 897| 897| 					}
| 898| 898| 				}
| 899| 899| 				break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 4 tabs but found 5.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 894| 894| 
| 895| 895| 						doublePressTimer = now;
| 896| 896| 						prevHotkey = ev.hotkey;
| 897|    |-					}
|    | 897|+				}
| 898| 898| 				}
| 899| 899| 				break;
| 900| 900| 		}
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 895| 895| 						doublePressTimer = now;
| 896| 896| 						prevHotkey = ev.hotkey;
| 897| 897| 					}
| 898|    |-				}
|    | 898|+			}
| 899| 899| 				break;
| 900| 900| 		}
| 901| 901| 		break;
|    | [NORMAL] ESLintBear (indent):
|    | Expected indentation of 3 tabs but found 4.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
| 896| 896| 						prevHotkey = ev.hotkey;
| 897| 897| 					}
| 898| 898| 				}
| 899|    |-				break;
|    | 899|+			break;
| 900| 900| 		}
| 901| 901| 		break;
| 902| 902| 
|    | [NORMAL] ESLintBear (space-in-parens):
|    | There should be no spaces inside this paren.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|1534|1534| 		g_BatchTrainingEntityAllowedCount < batchedSize * appropriateBuildings.length)
|1535|1535| 	{
|1536|1536| 		// Train as many full batches as we can
|1537|    |-		let buildingsCountToTrainFullBatch = Math.floor( g_BatchTrainingEntityAllowedCount / batchedSize);
|    |1537|+		let buildingsCountToTrainFullBatch = Math.floor(g_BatchTrainingEntityAllowedCount / batchedSize);
|1538|1538| 		Engine.PostNetworkCommand({
|1539|1539| 			"type": "train",
|1540|1540| 			"entities": appropriateBuildings.slice(0, buildingsCountToTrainFullBatch),
|    | [NORMAL] ESLintBear (comma-spacing):
|    | A space is required after ','.
|----|    | /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|    |++++| /zpool0/trunk/binaries/data/mods/public/gui/session/input.js
|1613|1613| 	var selectall = Engine.HotkeyIsPressed("selection.offscreen");
|1614|1614| 
|1615|1615| 	// Reset the last idle unit, etc., if the selection type has changed.
|1616|    |-	if (selectall || classes.length != lastIdleClasses.length || !classes.every((v,i) => v === lastIdleClasses[i]))
|    |1616|+	if (selectall || classes.length != lastIdleClasses.length || !classes.every((v, i) => v === lastIdleClasses[i]))
|1617|1617| 		resetIdleUnit();
|1618|1618| 	lastIdleClasses = classes;
|1619|1619| 

binaries/data/mods/public/gui/session/input.js
| 228| »   »   var·entState·=·GetEntityState(ent);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'entState' is already declared in the upper scope.

binaries/data/mods/public/gui/session/input.js
| 235| »   var·target·=·undefined;
|    | [NORMAL] ESLintBear (no-undef-init):
|    | It's not necessary to initialize 'target' to undefined.

binaries/data/mods/public/gui/session/input.js
| 249| »   var·actionInfo·=·undefined;
|    | [NORMAL] ESLintBear (no-undef-init):
|    | It's not necessary to initialize 'actionInfo' to undefined.

binaries/data/mods/public/gui/session/input.js
| 373| function·checkOrderOneOnSelection()·{
|    | [NORMAL] ESLintBear (brace-rules/brace-on-same-line):
|    | Opening curly brace appears on the same line as controlling statement.

binaries/data/mods/public/gui/session/input.js
| 486| »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 513| »   switch·(inputState)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 517| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 572| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 582| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 630| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 659| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 728| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 845| »   switch·(inputState)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 848| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 948| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
|1037| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
|1051| »   »   »   »   let·action·=·determineAction(ev.x,·ev.y);
|    | [NORMAL] ESLintBear (no-shadow):
|    | 'action' is already declared in the upper scope.

binaries/data/mods/public/gui/session/input.js
|1060| »   »   switch·(ev.type)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
|1129| »   »   »   switch·(ev.hotkey)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
|1564| »   switch·(action)
|    | [NORMAL] ESLintBear (default-case):
|    | Expected a default case.

binaries/data/mods/public/gui/session/input.js
| 235| »   var·target·=·undefined;
|    | [NORMAL] JSHintBear:
|    | It's not necessary to initialize 'target' to 'undefined'.

binaries/data/mods/public/gui/session/input.js
| 249| »   var·actionInfo·=·undefined;
|    | [NORMAL] JSHintBear:
|    | It's not necessary to initialize 'actionInfo' to 'undefined'.

binaries/data/mods/public/gui/session/input.js
| 263| »   for·(var·action·of·actions)
|    | [NORMAL] JSHintBear:
|    | 'action' is already defined.

binaries/data/mods/public/gui/session/input.js
| 266| »   »   »   var·r·=·g_UnitActions[action].hotkeyActionCheck(target,·selection);
|    | [NORMAL] JSHintBear:
|    | 'r' is already defined.

binaries/data/mods/public/gui/session/input.js
| 271| »   for·(var·action·of·actions)
|    | [NORMAL] JSHintBear:
|    | 'action' is already defined.

binaries/data/mods/public/gui/session/input.js
| 274| »   »   »   var·r·=·g_UnitActions[action].actionCheck(target,·selection);
|    | [NORMAL] JSHintBear:
|    | 'r' is already defined.

binaries/data/mods/public/gui/session/input.js
| 501| »   »   &&·(ev.button·==·SDL_BUTTON_LEFT·||·ev.button·==·SDL_BUTTON_RIGHT))
|    | [NORMAL] JSHintBear:
|    | Misleading line break before '&&'; readers may interpret this as an expression boundary.

binaries/data/mods/public/gui/session/input.js
| 531| »   »   »   »   var·rect·=·updateBandbox(bandbox,·ev,·true);
|    | [NORMAL] JSHintBear:
|    | 'rect' is already defined.

binaries/data/mods/public/gui/session/input.js
| 534| »   »   »   »   var·ents·=·getPreferredEntities(Engine.PickPlayerEntitiesInRect(rect[0],·rect[1],·rect[2],·rect[3],·g_ViewedPlayer));
|    | [NORMAL] JSHintBear:
|    | 'ents' is already defined.

binaries/data/mods/public/gui/session/input.js
| 691| »   »   »   »   »   var·queued·=·Engine.HotkeyIsPressed("session.queue");
|    | [NORMAL] JSHintBear:
|    | 'queued' is already defined.

binaries/data/mods/public/gui/session/input.js
| 762| »   »   »   »   var·queued·=·Engine.HotkeyIsPressed("session.queue");
|    | [NORMAL] JSHintBear:
|    | 'queued' is already defined.

binaries/data/mods/public/gui/session/input.js
| 892| »   »   »   »   »   »   var·sptr·=·ev.hotkey.split(".");
|    | [NORMAL] JSHintBear:
|    | 'sptr' is already defined.

binaries/data/mods/public/gui/session/input.js
| 908| »   »   »   var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y);
|    | [NORMAL] JSHintBear:
|    | 'ent' is already defined.

binaries/data/mods/public/gui/session/input.js
| 934| »   »   »   }
|    | [NORMAL] JSHintBear:
|    | Expected a 'break' statement before 'default'.

binaries/data/mods/public/gui/session/input.js
| 958| »   »   »   var·ent·=·Engine.PickEntityAtPoint(ev.x,·ev.y);
|    | [NORMAL] JSHintBear:
|    | 'ent' is already defined.
Executing section cli...

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/362/display/redirect

luiko edited the summary of this revision. (Show Details)Aug 12 2019, 6:14 PM