Do not quote philosopher names in quotes.txt
ClosedPublic
Actions

Authored by Gallaecio on Aug 15 2019, 12:04 PM.

Details

Reviewers

Itms
Nescio
elexis

Commits

rP22771: Quote all book names in quotes.txt

Summary

Brought up by @Itms at https://www.transifex.com/wildfire-games/0ad/translate/#gl/$/112552127?q=issue%3Aopen

Test Plan

Only affects user-visible strings

Diff Detail

Repository

rP 0 A.D. Public Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Gallaecio created this revision.Aug 15 2019, 12:04 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/384/display/redirect

Harbormaster completed remote builds in B8861: Diff 9339.Aug 15 2019, 12:08 PM

Those are not philosopher names, those are titles of works.

Then let’s add quotes to those similar lines missing them.

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/409/display/redirect

Harbormaster completed remote builds in B8900: Diff 9374.Aug 18 2019, 3:14 PM

Nescio accepted this revision.Aug 18 2019, 4:03 PM

This revision is now accepted and ready to land.Aug 18 2019, 4:03 PM

Nescio added inline comments.Aug 19 2019, 10:34 AM

binaries/data/mods/public/gui/text/quotes.txt
28 ↗	(On Diff #9374)	Anacharsis

Closed by commit rP22771: Quote all book names in quotes.txt (authored by Gallaecio). · Explain WhyAug 24 2019, 11:24 AM

This revision was automatically updated to reflect the committed changes.

Gallaecio marked an inline comment as done.

Gallaecio added a commit: rP22771: Quote all book names in quotes.txt.

Owners added a subscriber: Restricted Owners Package.Aug 24 2019, 11:24 AM

Gallaecio added inline comments.Aug 24 2019, 11:24 AM

binaries/data/mods/public/gui/text/quotes.txt
28 ↗	(On Diff #9374)	Applied upon merging.

Revision Contents
Changeset List

Path

Size

ps/

trunk/

binaries/

data/

mods/

public/

gui/

text/

quotes.txt

10 lines

Diff 9475

View Options

ps/trunk/binaries/data/mods/public/gui/text/quotes.txt

Do not quote philosopher names in quotes.txtClosedPublicActions