Page MenuHomeWildfire Games

Fix rP22668 Wind computation - move back to signed integers
ClosedPublic

Authored by wraitii on Aug 15 2019, 6:50 PM.

Details

Summary

Had it like that originally, shouldn't have doubted...

rP22668

Test Plan

Compile.

Diff Detail

Repository
rP 0 A.D. Public Repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

wraitii created this revision.Aug 15 2019, 6:50 PM
Owners added a subscriber: Restricted Owners Package.Aug 15 2019, 6:50 PM
wraitii edited the summary of this revision. (Show Details)Aug 15 2019, 6:50 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/391/display/redirect

elexis added a subscriber: elexis.Aug 15 2019, 6:59 PM

Ideally there would be no type conversions and all values are constructed in the right type, and the functions receiving them expect exactly that type.
I didnt check much of the code, but GetVertexGroundLevel expects the signed variant already, so it might be right with signed.
Should check that there arent unintented implicit type conversions.

Compile warning is gone.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2019, 7:03 PM
This revision was automatically updated to reflect the committed changes.

m_MapSize ought to be signed but that sounded like it'd change many more lines.