The function FallBackSprite and FallBackColor are located in GUIutil.h, which is unfortunate, because if they were gone, the entire file would solely be about management of GUIObject settings and could be unified / homogenized further.
Details
Details
- Reviewers
- None
- Commits
- rP22689: Move GUI<>::FallBackSprite and GUI<>::FallBackColor to CGUIColor::operator||…
See GUIutil.h asking to become one class. See the operator and see that it's good.
Diff Detail
Diff Detail
- Repository
- rP 0 A.D. Public Repository
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Successful build - Chance fights ever on the side of the prudent.
Linter detected issues:
Executing section Source...
source/gui/GUIutil.h
| 44| template<typename·T>·class·GUI;
| | [MAJOR] CPPCheckBear (syntaxError):
| | Code 'template<...' is invalid C code. Use --std or --language to configure the language.
source/gui/CGUISprite.h
| 176| » » if·(*this)
| | [MAJOR] CPPCheckBear (syntaxError):
| | Code 'classCClientArea{' is invalid C code. Use --std or --language to configure the language.
source/graphics/Color.h
| 74| » » » static_cast<u8>(r·*·255.f),
| | [MAJOR] CPPCheckBear (syntaxError):
| | Code 'C++ cast <...' is invalid C code. Use --std or --language to configure the language.
Executing section JS...
Executing section cli...Link to build: https://jenkins.wildfiregames.com/job/docker-differential/411/display/redirect