Page MenuHomeWildfire Games

correct descriptions and tooltips of siege technologies
ClosedPublic

Authored by Nescio on Aug 18 2019, 4:38 PM.

Details

Summary

This patch corrects the descriptions and tooltips of siege technologies, consistently referring to the Siege class as “Siege Engines”, per https://trac.wildfiregames.com/wiki/EnglishStyleGuide#Units and standardizing the tooltip format to [class] [change] [attributes].

See also D1720, D1806, D1807, D1808.

Test Plan

Check for mistakes.

Diff Detail

Repository
rP 0 A.D. Public Repository
Branch
/ps/trunk
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8929
Build 14655: Vulcan BuildJenkins
Build 14654: arc lint + arc unit

Event Timeline

Nescio created this revision.Aug 18 2019, 4:38 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/413/display/redirect

Nescio added inline comments.Aug 18 2019, 4:42 PM
binaries/data/mods/public/simulation/data/technologies/siege_bolt_accuracy.json
13

We might as well use "civ": instead of "notciv": here.

Freagarach added inline comments.
binaries/data/mods/public/simulation/data/technologies/successors/special_parade_of_daphne.json
3

This implies that the units are automatically trained in large batches/battalions from now on? So by -> when? And remove battalions perhaps.

Nescio updated this revision to Diff 9406.Aug 19 2019, 11:27 PM

Successful build - Chance fights ever on the side of the prudent.

Link to build: https://jenkins.wildfiregames.com/job/docker-differential/429/display/redirect

Gallaecio accepted this revision.Aug 24 2019, 10:57 AM
This revision is now accepted and ready to land.Aug 24 2019, 10:57 AM
This revision was automatically updated to reflect the committed changes.